Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01BA6C05027 for ; Thu, 2 Feb 2023 03:25:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231200AbjBBDZv (ORCPT ); Wed, 1 Feb 2023 22:25:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbjBBDZt (ORCPT ); Wed, 1 Feb 2023 22:25:49 -0500 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 474784FAE7; Wed, 1 Feb 2023 19:25:48 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1pNQE9-006bCQ-NC; Thu, 02 Feb 2023 11:25:34 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Thu, 02 Feb 2023 11:25:33 +0800 Date: Thu, 2 Feb 2023 11:25:33 +0800 From: Herbert Xu To: Neal Liu Cc: Joel Stanley , Andrew Jeffery , "David S . Miller" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" Subject: Re: [PATCH-next] crypto: aspeed: fix type warnings Message-ID: References: <20230202025600.2598548-1-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 02, 2023 at 03:23:29AM +0000, Neal Liu wrote: > > I cannot tell which way is better. Do you prefer to keep the iomem marker? The whole point of iomem is to prevent you from directly dereferencing that memory. So casting it away to remove the warning simply defeats its purpose. If you're worried about the overhead of readb perhaps you can look into readb_relaxed after considering the effects of the barriers. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt