From:   Parav Pandit <parav@nvidia.com>
To:     Si-Wei Liu <si-wei.liu@oracle.com>,
        "mst@redhat.com" <mst@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        Eli Cohen <elic@nvidia.com>
CC:     "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/7] vdpa: fix improper error message when adding vdpa
 dev
Thread-Topic: [PATCH v2 1/7] vdpa: fix improper error message when adding vdpa
 dev
Thread-Index: AQHZNcrtYY1KrfDk7UG+prT+QyItbq67FgIA
Date:   Thu, 2 Feb 2023 04:45:23 +0000
Message-ID: <PH0PR12MB5481DFAE7928CDCB5E189C97DCD69@PH0PR12MB5481.namprd12.prod.outlook.com>
References: <1675207345-22328-1-git-send-email-si-wei.liu@oracle.com>
 <1675207345-22328-2-git-send-email-si-wei.liu@oracle.com>
In-Reply-To: <1675207345-22328-2-git-send-email-si-wei.liu@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HCU4Y4jrULn6nQ9G2jnoz7rjRKcyeWf/yYdnJ6ZTtb20davuXilxBqOTALyu?=
 =?us-ascii?Q?N4UHe0/Cgbc2Ck+aEGsj0KiIYrMoyiSKHuLOaLsVjAK8C/FlNCUBb3Q0YtyZ?=
 =?us-ascii?Q?behqGwC2NcS92dmhwRg6EhQhkt7LjXht9uEFi8VMoLcdketA+vkZ2bWWD0dm?=
 =?us-ascii?Q?YlG0c6LvwWmZeY+m4Qm6/c6Z9m0rCYobA1p7umV8m0H0CbJ2xJykL5E/RJtd?=
 =?us-ascii?Q?jfj4IXiOtNAfAU5bCjZA9kOQcXChom1J/bjHRjBI4iqP2w7i/IkNgwgxjLhK?=
 =?us-ascii?Q?Eqb74Au0e/uI4QYMQXinRGUJCGtgExtETrT96k5bRlmmSyjherBf55QP5hps?=
 =?us-ascii?Q?Hdzbprn5+ZNwpESXuIDwkG+V311rTRcEimco4QBrf/ccpRBGNQYkzxUA2US3?=
 =?us-ascii?Q?hnb38uiWhzevSTH9PhNIZn1DdxGJElsXOCvGpiat2cPcG++esjPSl07UoabH?=
 =?us-ascii?Q?ZjwbvXPqfTFsHCWI4FK0qqPzV9oRq5AmPNsxpOq8R7pEytsCeMazwgnfhfo8?=
 =?us-ascii?Q?zgAx799d5wrTipTQ/Nym0gRM0yVRVULBCaII98CP4RYmJj+s2DDhsjKvzAnh?=
 =?us-ascii?Q?1SCf3qiOhTB/VuKc7vN+QgldKmIRWaNbpXUronY+qNs7AkiFKTiwFHgaeWUw?=
 =?us-ascii?Q?MQ72VbSiSXHyAbcltAvfDye0u27xFSNVbGDayC8WbdqT32GQ+mq2n0OkkCv8?=
 =?us-ascii?Q?MoKrokcbtB4VvoEG273tpCahQieLMVG5VgO1PACiR4m+rbJ1A05uX1u88yDJ?=
 =?us-ascii?Q?Lcn+8ljYMjyaeDfr/mg+5Af96C2g5tA3u9lcBZRIB1QtVYt/RzyYFPrR58FI?=
 =?us-ascii?Q?5a3aVUrdgeQV55wk9nzlgZLdSzHroEX1Tz7IN6jAnbQsjoj85PnfyhetIYfB?=
 =?us-ascii?Q?SCHtx4nwQh6bywbN+j5bOuTpjYJtzm8lZaNSySW4/Ob/l87aNl7NEytM2Rlp?=
 =?us-ascii?Q?tjAfdX79hjaUDR4x+2craVmqiAP6clP1mciL2HgG2XPVWVbTE8VWfqwL7fid?=
 =?us-ascii?Q?XGLh29glqsXrdsnDOkutlXsHl75/Rlj0uCGB+hAGRNEGoQmeBXBDjnOfaDCf?=
 =?us-ascii?Q?4+A7yfDRQYg/NKooaFSPiC5cuQiqHTU7jRxyTWkxr7RhaKL950wG1cMzpqF5?=
 =?us-ascii?Q?jD7+zL31gyfn/1+b6HzYR/2OyZO63qeb44SUg+w3mNJynpOyExaN2qG1rQgc?=
 =?us-ascii?Q?jR72rHxkIl4GME31QIs7wTluuiB6mSH+wWTvGVpDF2qTiabkquUPfgJj3iCR?=
 =?us-ascii?Q?6ZOP6q4dsHpzU0KcAfvpvCVEar5NhM7D3ujcBQRaYdiVBuoCEkuovzcMVw95?=
 =?us-ascii?Q?szSebptLU/Q+/K5EqBAg58T2KGOFksHUJpLgNS6asyu02DjInjXRu4bAqANm?=
 =?us-ascii?Q?TzVzL0VSOYwrXktNUNr9muYjYzQMt/p2ESAd75vY57GJu2J4waJWgq1efb+w?=
 =?us-ascii?Q?RqhXUqX8ZUAqwZtOw9wRn26QMKUZkywew2YJK522Q3ZV3pkZ00yYoNd9uruJ?=
 =?us-ascii?Q?BCZi67okTnkzo22TMTaBwhc8jZHbh+3HdpefvIgQL3/ZIQCrbB8IdXcFlS+3?=
 =?us-ascii?Q?6XLkbInRjGvIBkI+7kk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB5481.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69ccc2f7-7ebe-4824-04e6-08db04d84b98
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 04:45:23.0445
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RKOjFpNL/C6TSBVs+7WF+QMBH6DN+JgydbkL2QjU+bTGgXDJErbjzXwcxu/OqLJeUvVWDCnpGO15CLFRmcjnyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6463
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> From: Si-Wei Liu <si-wei.liu@oracle.com>
> Sent: Tuesday, January 31, 2023 6:22 PM
>=20
> In below example, before the fix, mtu attribute is supported by the paren=
t
> mgmtdev, but the error message showing "All provided are not supported" i=
s
> just misleading.
>=20
> $ vdpa mgmtdev show
> vdpasim_net:
>   supported_classes net
>   max_supported_vqs 3
>   dev_features MTU MAC CTRL_VQ CTRL_MAC_ADDR ANY_LAYOUT VERSION_1
> ACCESS_PLATFORM
>=20
> $ vdpa dev add mgmtdev vdpasim_net name vdpasim0 mtu 5000 max_vqp 2
> Error: vdpa: All provided attributes are not supported.
> kernel answers: Operation not supported
>=20
> After fix, the relevant error message will be like:
>=20
> $ vdpa dev add mgmtdev vdpasim_net name vdpasim0 mtu 5000 max_vqp 2
> Error: vdpa: Some provided attributes are not supported: 0x1000.
> kernel answers: Operation not supported
>=20
> Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
Please add fixes tag so that older kernel gets this fix.
With that change,
Reviewed-by: Parav Pandit <parav@nvidia.com>

> ---
>  drivers/vdpa/vdpa.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c index 8ef7aa1..3a8=
2ca78
> 100644
> --- a/drivers/vdpa/vdpa.c
> +++ b/drivers/vdpa/vdpa.c
> @@ -622,9 +622,11 @@ static int vdpa_nl_cmd_dev_add_set_doit(struct
> sk_buff *skb, struct genl_info *i
>  		err =3D PTR_ERR(mdev);
>  		goto err;
>  	}
> +
>  	if ((config.mask & mdev->config_attr_mask) !=3D config.mask) {
> -		NL_SET_ERR_MSG_MOD(info->extack,
> -				   "All provided attributes are not supported");
> +		NL_SET_ERR_MSG_FMT_MOD(info->extack,
> +				       "Some provided attributes are not
> supported: 0x%llx",
> +				       config.mask & ~mdev->config_attr_mask);
>  		err =3D -EOPNOTSUPP;
>  		goto err;
>  	}
> --
> 1.8.3.1