Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6472BC61DA4 for ; Thu, 2 Feb 2023 08:21:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231779AbjBBIU7 (ORCPT ); Thu, 2 Feb 2023 03:20:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231821AbjBBIU4 (ORCPT ); Thu, 2 Feb 2023 03:20:56 -0500 Received: from out-198.mta1.migadu.com (out-198.mta1.migadu.com [IPv6:2001:41d0:203:375::c6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AE7F84B79 for ; Thu, 2 Feb 2023 00:20:55 -0800 (PST) Message-ID: <3e3fd166-6a71-cec8-7d85-6d6b2515d7f6@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1675326053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OUivNFXjv8moUaUjEogbM+eU3r3jETmBMqQBNTfTjgA=; b=iaPbxOxJv1my76gfF2mKmO3Aa7Fbl6hRurWZVKqWhtaa2av/E9JIITQE1850MUBjirL3JX IlDRJBnjMVA53TvYoeUJiYGAP2Tl2iWGg3N38IFeJtYxl/letInvEZcPMXvYeI1a6h6iV1 rqXog+PgBIdxPG82FvTgdZJE9OA0sg8= Date: Thu, 2 Feb 2023 16:20:57 +0800 MIME-Version: 1.0 Subject: Re: [PATCH RFC] RDMA/rtrs: Don't call kobject_del for srv_path->kobj Content-Language: en-US To: "lizhijian@fujitsu.com" , "haris.iqbal@ionos.com" , "jinpu.wang@ionos.com" , "linux-rdma@vger.kernel.org" Cc: "jgg@ziepe.ca" , "leon@kernel.org" , "linux-kernel@vger.kernel.org" References: <1675261833-2-1-git-send-email-lizhijian@fujitsu.com> <6bcba397-f4f1-26df-f8cd-1dbebf111932@linux.dev> <42e231f5-63bb-e145-ce80-d9651a9afee1@fujitsu.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Guoqing Jiang In-Reply-To: <42e231f5-63bb-e145-ce80-d9651a9afee1@fujitsu.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/2/23 15:59, lizhijian@fujitsu.com wrote: > 6af4609c18b3 seems make senses, so i don't want to revert it entirely if possible. > > I have a update for this path like below, i am no longer get problem with this new update. > > index c76ba29da1e2..5adba0f754b6 100644 > --- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c > +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c > @@ -312,9 +312,8 @@ void rtrs_srv_destroy_path_files(struct rtrs_srv_path *srv_path) > > if (srv_path->kobj.state_in_sysfs) { > sysfs_remove_group(&srv_path->kobj, &rtrs_srv_path_attr_group); > - kobject_del(&srv_path->kobj); > kobject_put(&srv_path->kobj); > + rtrs_srv_destroy_once_sysfs_root_folders(srv_path); > } > > - rtrs_srv_destroy_once_sysfs_root_folders(srv_path); > } Hmm, I overlooked the kobject hierarchy ????.        err = kobject_init_and_add(&srv_path->kobj, &ktype, srv->kobj_paths, "%s", str); Pls send a formal patch, and feel free to add my Acked-by. Thanks, Guoqing