Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CE3C61DA4 for ; Thu, 2 Feb 2023 08:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232129AbjBBIfA (ORCPT ); Thu, 2 Feb 2023 03:35:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232076AbjBBIew (ORCPT ); Thu, 2 Feb 2023 03:34:52 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D199986EA9 for ; Thu, 2 Feb 2023 00:33:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 32DB8619B9 for ; Thu, 2 Feb 2023 08:33:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39ABFC433D2; Thu, 2 Feb 2023 08:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675326838; bh=xBMp1O9N/F7RyeQsYOUc+GkIYLasNOIQKN7ooKC5xX8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WsO9wa/d7H6GTZdQ/QqgP/MYd1IQCoxVSRHI1+XogRpFzO2iWVSDPWhK0zixZQPZh fir+Sk23YjYw/3khTPhqZLEMYvYVFjDM+9+CtFe50X3jGadiAcSJxAjDZv6QmCEKKA 3p0Nq7JjVmtWw5PzU/w+AoIHmEKRRer1/SWDfzg8= Date: Thu, 2 Feb 2023 09:33:55 +0100 From: Greg KH To: Longlong Xia Cc: rafael@kernel.org, linux-kernel@vger.kernel.org, chenwandun@huawei.com, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH -next 1/3] devtmpfs: convert to pr_fmt Message-ID: References: <20230202033203.1239239-1-xialonglong1@huawei.com> <20230202033203.1239239-2-xialonglong1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202033203.1239239-2-xialonglong1@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 02, 2023 at 03:32:01AM +0000, Longlong Xia wrote: > Use the pr_fmt() macro to prefix all the output with "devtmpfs: ". > while at it, convert printk() to pr_(). > > Signed-off-by: Longlong Xia > --- > drivers/base/devtmpfs.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) Nice! I'll take this one now, the other two I've sent review comments on already. Please fix them up and resend them and I'll be glad to consider taking them. thanks, greg k-h