Date:   Thu, 2 Feb 2023 09:08:38 +0000
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Chen Guokai <chenguokai17@mails.ucas.ac.cn>
CC:     <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
        <aou@eecs.berkeley.edu>, <rostedt@goodmis.org>, <mingo@redhat.com>,
        <sfr@canb.auug.org.au>, <linux-riscv@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <liaochang1@huawei.com>,
        =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@kernel.org>
Subject: Re: [PATCH v6 09/13] riscv/kprobe: Search free registers from unused
 caller-saved ones
Message-ID: <Y9t9ljSEJtnr835Y@wendy>
References: <20230127130541.1250865-1-chenguokai17@mails.ucas.ac.cn>
 <20230127130541.1250865-10-chenguokai17@mails.ucas.ac.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="aHQm0zwpXHrO71dn"
Content-Disposition: inline
In-Reply-To: <20230127130541.1250865-10-chenguokai17@mails.ucas.ac.cn>
Precedence: bulk

--aHQm0zwpXHrO71dn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hey Chen,

Was looking at the insn manipulation code in 4/13 and noticed a minor
nit in this patch in the process.

On Fri, Jan 27, 2023 at 09:05:37PM +0800, Chen Guokai wrote:
> +/*
> + * Register	ABI Name	Saver
> + * x0		zero		--
> + * x1		ra		Caller
> + * x2		sp		Callee
> + * x3		gp		--
> + * x4		tp		--
> + * x5-7 	t0-2		Caller

I know it's just a comment, but this line here has a space before the
first tab that makes nvim unhappy.

Thanks,
Conor.


--aHQm0zwpXHrO71dn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY9t9igAKCRB4tDGHoIJi
0iRMAP9UcWucUeNFvkwtiH1LHVHVWEqdLTuGy49K60zsCtS9uQEAtBfuqg0Ovlw3
ybWuIvRwhcGgmKIQ6dTMACFSeuUXYAY=
=qR8Q
-----END PGP SIGNATURE-----

--aHQm0zwpXHrO71dn--