Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC85CC636D4 for ; Thu, 2 Feb 2023 09:36:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232022AbjBBJgG (ORCPT ); Thu, 2 Feb 2023 04:36:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231643AbjBBJfy (ORCPT ); Thu, 2 Feb 2023 04:35:54 -0500 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69A0B88F01; Thu, 2 Feb 2023 01:35:24 -0800 (PST) Received: by mail-ej1-f48.google.com with SMTP id p26so4122843ejx.13; Thu, 02 Feb 2023 01:35:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X4P+6DJXMGU/GZ6vC+OA7Rv2lwEcUeLQojPFdj2bMYU=; b=1wpFaF0JJoOmsBhpQcnNXAtTKL1PYZOGSTE32mv02CxHwk+YVimytfWUZ/gxWxWM18 18+MeFygUWFLJgHtRQO7Ujp9QWUvcyWPEU1MEUI7ck6LGDvHBKmyXVLGxLl3zWjHrjOY RwhiFsM7PSJev5GAekI0aaLgjGUg7LYBJ2VaLSSFMm7CEUXi724S86pXzuV42ac/O09t EGkAUc9hs9btAHzeBCt7umXWrKWApqqJ+iu9nFW/oebiwTwwIsXlT3swwSdGSZ1RLiBI wP6D8CBhG5HfLB7L2ncO9/aYXrZIoDq33/zV/dxXbILBavn/FRG+Cr5mW2khKudcyxuk 8Mpw== X-Gm-Message-State: AO0yUKVW6UWQy8Q951Dtbojc6a75viv4fh8M9cFFwQyf0WEYN1q8ilvV L0qugfeAdB18HidTgaDvtqmfHKNyRnHi+uvWHPU= X-Google-Smtp-Source: AK7set9sKQAZXmRj4+REuiGeggHYJ4JQtQBqgzxnG0dm+vm9SPQgzRMqJSX3pLIlMO165L8G/PnH4sIuciDlDxViMNA= X-Received: by 2002:a17:906:6886:b0:877:612e:517e with SMTP id n6-20020a170906688600b00877612e517emr1692509ejr.152.1675330502794; Thu, 02 Feb 2023 01:35:02 -0800 (PST) MIME-Version: 1.0 References: <20230131233755.58942-1-pedro.falcato@gmail.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Thu, 2 Feb 2023 10:34:51 +0100 Message-ID: Subject: Re: [PATCH] ACPI: Make custom_method use per-open state To: "Marty E. Plummer" Cc: rafael@kernel.org, Pedro Falcato , lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, rui.zhang@intel.com, swiftgeek@gmail.com, zh.nvgt@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 2, 2023 at 2:04 AM Marty E. Plummer wrote: > > From: "Rafael J. Wysocki" > > > On Wed, Feb 1, 2023 at 12:38 AM Pedro Falcato wrote: > > > > > > Make custom_method keep its own per-file-open state instead of global > > > state in order to avoid race conditions[1] and other possible conflicts > > > with other concurrent users. > > > > > > Link: https://lore.kernel.org/linux-acpi/20221227063335.61474-1-zh.nvgt@gmail.com/ # [1] > > > Reported-by: Hang Zhang > > > Cc: Swift Geek > > > Signed-off-by: Pedro Falcato > > > --- > > > This patch addresses Hang's problems plus the ones raised by Rafael in his review (see link above). > > > https://lore.kernel.org/lkml/2667007.mvXUDI8C0e@kreacher/ was submitted but since there were still people > > > that wanted this feature, I took my time to write up a patch that should fix the issues. > > > Hopefully the linux-acpi maintainers have not decided to remove custom_method just yet. > > > > Well, thanks for the patch, but yes, they have. Sorry. > > Honestly, I think that's a bit of a cop out. This is git. git revert exists, > and you're crippling the abilities of quite a lot of coreboot/etc development. Perhaps they can try to use the ACPI debugger that's in the kernel now instead of a known-broken interface?