Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-107-g82c3c54364-fm-20230131.002-g82c3c543
Mime-Version: 1.0
Message-Id: <566b855b-dbdd-4c10-aac2-262b64343ae6@app.fastmail.com>
In-Reply-To: <20230201215320.528319-1-dmitry.torokhov@gmail.com>
References: <20230201215320.528319-1-dmitry.torokhov@gmail.com>
Date:   Thu, 02 Feb 2023 10:47:58 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
        "Wei Fang" <wei.fang@nxp.com>, "Jakub Kicinski" <kuba@kernel.org>,
        "Andrew Lunn" <andrew@lunn.ch>
Cc:     "Shenwei Wang" <shenwei.wang@nxp.com>,
        "Clark Wang" <xiaoning.wang@nxp.com>,
        "NXP Linux Team" <linux-imx@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        "Paolo Abeni" <pabeni@redhat.com>,
        "Marc Kleine-Budde" <mkl@pengutronix.de>,
        Netdev <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] net: fec: restore handling of PHY reset line as optional
Content-Type: text/plain
Precedence: bulk

On Wed, Feb 1, 2023, at 22:53, Dmitry Torokhov wrote:
> Conversion of the driver to gpiod API done in 468ba54bd616 ("fec:
> convert to gpio descriptor") incorrectly made reset line mandatory and
> resulted in aborting driver probe in cases where reset line was not
> specified (note: this way of specifying PHY reset line is actually
> deprecated).
>
> Switch to using devm_gpiod_get_optional() and skip manipulating reset
> line if it can not be located.
>
> Fixes: 468ba54bd616 ("fec: convert to gpio descriptor")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> v3: removed handling of 'phy-reset-active-high', it was moved to patch #2
> v2: dropped conversion to generic device properties from the patch

Thanks for fixing it,

Reviewed-by: Arnd Bergmann <arnd@arndb.de>