Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 480EEC61DA4 for ; Thu, 2 Feb 2023 10:05:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232430AbjBBKFS (ORCPT ); Thu, 2 Feb 2023 05:05:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbjBBKFP (ORCPT ); Thu, 2 Feb 2023 05:05:15 -0500 Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [IPv6:2607:f8b0:4864:20::e30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1F486EAC2 for ; Thu, 2 Feb 2023 02:04:51 -0800 (PST) Received: by mail-vs1-xe30.google.com with SMTP id a24so1279271vsl.2 for ; Thu, 02 Feb 2023 02:04:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OTOvqWUVVZlijg12oIE77cCshSPOfIDDk+4jVZ655+k=; b=Y7i97OuPVRG0MgxTC9jku/WRmfXJzJgR11Xi60ud4fHWkw7cLDQYIdWugE6JNqWnhd zxDgruQpaaB4LFUDWXcMSYeomB81VQX+3ATeeEqUeEUcYV0EZUWrjL3wOBJblWbRpVW1 Gl7h9olEHVokDvWVeTLUZQkKU+OvOIiihhk0mCjAK4uwblHWRLHCA60HwPXBE/iCBa9n T8G8wzVtJ2m0TB3qrVKuJgHUhQkbAiqcJmN3TE6i/Qc8nDPNJRvHNU0ZJAANxudkyU5e ENdpuQzV9CWdipdZJs1aL1KBjiWwUgH58AUI9/UXDJp506L1+5IF8R62Rtxd6SUf3C9k a23Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OTOvqWUVVZlijg12oIE77cCshSPOfIDDk+4jVZ655+k=; b=2ZQbe777ZPuqRp2gs7zCyyN3lzlK8KYMa11rnkIB7b/H+oTJX+HyIDndREL3OCI+4D 65uXiAkTU3TafVJ5+T/h8j2atO3WlX/ra6oVAMVja+Zf9JHs/HKBO+OBlA4ePN0hwxmZ ObBS1xd3xmNhMfYWgwXAuJX+2/fCgq2D04flLLOn/IWodzySKRJ3yjw9vJeIp2mCs4tb ouLFrV9j+WMqqxiyLAj2OqbaQc1iAgf0DVYri3g1i+zegz9Ok7qFo5yDqUyHRxFojmyY bDOrgJrKbjOzN7P2byEmquXlTNdGtGfFG5Put0Mc2SE+9J9yevglzAef/eb1rJTm23OI 11CA== X-Gm-Message-State: AO0yUKWewREICtJNyHkChRr8G2lAciwh9Fons7qRBSWTQbRMG9CBq17U JZuYbXUnqIklx0vnlN3bF95+veUMfdDtLaEHOIAqFg== X-Google-Smtp-Source: AK7set+m0o4TzaHt7t+a9/rf2tPz/cn1DFL8um9JSDcZSJY/WerimKLUAL6/+SWq+cj4vMyKkMrrYJIk30w897DMp8k= X-Received: by 2002:a05:6102:1343:b0:3ed:1e92:a87f with SMTP id j3-20020a056102134300b003ed1e92a87fmr927918vsl.1.1675332290796; Thu, 02 Feb 2023 02:04:50 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Thu, 2 Feb 2023 11:04:14 +0100 Message-ID: Subject: Re: [PATCH 15/18] lib/stacktrace, kasan, kmsan: rework extra_bits interface To: Andrey Konovalov Cc: Marco Elver , andrey.konovalov@linux.dev, Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 31, 2023 at 7:58 PM Andrey Konovalov wrote: > > On Tue, Jan 31, 2023 at 9:54 AM Marco Elver wrote: > > > > > +depot_stack_handle_t stack_depot_set_extra_bits(depot_stack_handle_t handle, > > > + unsigned int extra_bits); > > > > Can you add __must_check to this function? Either that or making > > handle an in/out param, as otherwise it might be easy to think that it > > doesn't return anything ("set_foo()" seems like it sets the > > information in the handle-associated data but not handle itself ... in > > case someone missed the documentation). > > Makes sense, will do in v2 if Alexander doesn't object to the > interface change. Thanks! I do not object. Thanks for doing this!