Date:   Thu, 2 Feb 2023 11:32:33 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Viken Dadhaniya <quic_vdadhani@quicinc.com>
Cc:     jirislaby@kernel.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org, quic_msavaliy@quicinc.com,
        quic_vnivarth@quicinc.com, quic_vtanuku@quicinc.com,
        quic_arandive@quicinc.com
Subject: Re: [PATCH V2] Serial: core: Add compat ioctl support
Message-ID: <Y9uRQb72Y7byQiXa@kroah.com>
References: <20230125113418.7221-1-quic_vdadhani@quicinc.com>
 <Y9EfYCBngFAG+RBw@kroah.com>
 <10d91214-4106-7a9d-b1ac-68df1aa5f6c9@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <10d91214-4106-7a9d-b1ac-68df1aa5f6c9@quicinc.com>
Precedence: bulk

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Feb 02, 2023 at 03:44:45PM +0530, Viken Dadhaniya wrote:
> Hi Greg,
> 
> "Can you point us at the out-of-tree code please?"
> 
> Please refer: https://git.codelinaro.org/clo/la/kernel/msm-5.10/-/blob/KERNEL.PLATFORM.1.0.r3-01300-kernel.0/drivers/tty/serial/msm_geni_serial.c#L750

As this is a 5.10 link, are you sure this is the same codebase you are
using?

That ioctl handler does not touch the arg parameter at all, so what
would a compat_ioctl() handler be required for?

confused,

greg k-h