Message-ID: <9f37bea4eeb6340f5c20e74d134033d037fe969f.camel@redhat.com>
Subject: Re: [PATCH net-next 11/13] rxrpc: Show consumed and freed packets
 as non-dropped in dropwatch
From:   Paolo Abeni <pabeni@redhat.com>
To:     David Howells <dhowells@redhat.com>, netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Marc Dionne <marc.dionne@auristor.com>,
        linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Date:   Thu, 02 Feb 2023 11:42:28 +0100
In-Reply-To: <20230131171227.3912130-12-dhowells@redhat.com>
References: <20230131171227.3912130-1-dhowells@redhat.com>
         <20230131171227.3912130-12-dhowells@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-01-31 at 17:12 +0000, David Howells wrote:
> Set a reason when freeing a packet that has been consumed such that
> dropwatch doesn't complain that it has been dropped.
>=20
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Marc Dionne <marc.dionne@auristor.com>
> cc: linux-afs@lists.infradead.org
> ---
>  net/rxrpc/skbuff.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/net/rxrpc/skbuff.c b/net/rxrpc/skbuff.c
> index ebe0c75e7b07..944320e65ea8 100644
> --- a/net/rxrpc/skbuff.c
> +++ b/net/rxrpc/skbuff.c
> @@ -63,7 +63,7 @@ void rxrpc_free_skb(struct sk_buff *skb, enum rxrpc_skb=
_trace why)
>  	if (skb) {
>  		int n =3D atomic_dec_return(select_skb_count(skb));
>  		trace_rxrpc_skb(skb, refcount_read(&skb->users), n, why);
> -		kfree_skb(skb);
> +		kfree_skb_reason(skb, SKB_CONSUMED);

Just for the records, and not intending blocking this series, IMHO:

		consume_skb(skb);=20

would probably be more straight-forward/clear.

Cheers,

Paolo