Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753777AbXIAGwR (ORCPT ); Sat, 1 Sep 2007 02:52:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751595AbXIAGwG (ORCPT ); Sat, 1 Sep 2007 02:52:06 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:52831 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751504AbXIAGwE (ORCPT ); Sat, 1 Sep 2007 02:52:04 -0400 Date: Sat, 1 Sep 2007 15:53:53 +0900 From: KAMEZAWA Hiroyuki To: Andrew Morton Cc: linux-kernel@vger.kernel.org Subject: Re: 2.6.23-rc4-mm1 Message-Id: <20070901155353.8a09db69.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20070831215822.26e1432b.akpm@linux-foundation.org> References: <20070831215822.26e1432b.akpm@linux-foundation.org> Organization: Fujitsu X-Mailer: Sylpheed 2.4.2 (GTK+ 2.10.11; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1849 Lines: 52 I met 2 troubles while I compiled rc4-mm1 on x86/UP system, One on pcnet32.c (patch is attaced below). One on crypto CONFIG. == compile log == drivers/net/pcnet32.c: In function 'pcnet32_netif_stop': drivers/net/pcnet32.c:445: warning: unused variable 'lp' drivers/net/pcnet32.c: In function 'pcnet32_netif_start': drivers/net/pcnet32.c:455: warning: unused variable 'lp' drivers/net/pcnet32.c: In function 'pcnet32_interrupt': drivers/net/pcnet32.c:2622: error: 'struct net_device' has no member named 'napi' .... crypto/built-in.o: In function `update2': digest.c:(.text+0x94a): undefined reference to `crypto_km_types' digest.c:(.text+0x9bf): undefined reference to `crypto_km_types' digest.c (CONFIG_CRYPTO) uses crypto/scatterwalk.c's object (CONFIG_CRYPTO_ALGAPI) I meet this when CONFIG_CRYPTO_ALGAPI=m. I need to make CONFIG_CRYPTO_ALGAPI=y. Regards, -Kame. == cut from here == tiny bug fix for pcnet32.c (maybe works well. please confirm.) Signed-off-by: KAMEZAWA Hiroyuki drivers/net/pcnet32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: devel-2.6.23-rc4-mm1/drivers/net/pcnet32.c =================================================================== --- devel-2.6.23-rc4-mm1.orig/drivers/net/pcnet32.c +++ devel-2.6.23-rc4-mm1/drivers/net/pcnet32.c @@ -2619,7 +2619,7 @@ pcnet32_interrupt(int irq, void *dev_id) break; } #else - pcnet32_rx(dev, dev->napi.weight); + pcnet32_rx(dev, lp->napi.weight); if (pcnet32_tx(dev)) { /* reset the chip to clear the error condition, then restart */ lp->a.reset(ioaddr); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/