Message-ID: <839ac9f7-92ff-c04d-37d3-d12db91d8829@gmail.com>
Date:   Thu, 2 Feb 2023 19:46:44 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH v3 1/8] KVM: x86/pmu: Rename pmc_is_enabled() to
 pmc_is_globally_enabled()
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jim Mattson <jmattson@google.com>
References: <20221111102645.82001-1-likexu@tencent.com>
 <20221111102645.82001-2-likexu@tencent.com> <Y9Mw3pcW/SL/Mna8@google.com>
From:   Like Xu <like.xu.linux@gmail.com>
In-Reply-To: <Y9Mw3pcW/SL/Mna8@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/1/2023 10:03 am, Sean Christopherson wrote:
> On Fri, Nov 11, 2022, Like Xu wrote:
>> From: Like Xu<likexu@tencent.com>
>>
>> The name of function pmc_is_enabled() is a bit misleading. A PMC can
>> be disabled either by PERF_CLOBAL_CTRL or by its corresponding EVTSEL.
>> Add the global semantic to its name.
>>
>> Suggested-by: Jim Mattson<jmattson@google.com>
>> Signed-off-by: Like Xu<likexu@tencent.com>
>> ---
> ...
> 
>> diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c
>> index 684393c22105..e57f707fb940 100644
>> --- a/arch/x86/kvm/pmu.c
>> +++ b/arch/x86/kvm/pmu.c
>> @@ -83,7 +83,7 @@ void kvm_pmu_ops_update(const struct kvm_pmu_ops *pmu_ops)
>>   #undef __KVM_X86_PMU_OP
>>   }
>>   
>> -static inline bool pmc_is_enabled(struct kvm_pmc *pmc)
>> +static inline bool pmc_is_globally_enabled(struct kvm_pmc *pmc)
>>   {
>>   	return static_call(kvm_x86_pmu_pmc_is_enabled)(pmc);
> This doesn't compile.  v3, and I'm getting pings, and the very first patch doesn't
> compile.
> 

Oops, very sorry for this breaking the git-bisect attribute, it's my fault to 
split the code diff incorrectly
(weakly it compiles fine w/ 4th patch), I will enhance the process before 
sending any patches to you.
Thank you for taking time to review the rest of patches in detail as you always 
do. The new version is
under construction, apologies again.