Message-ID: <4c95d12d5d4c423adf78c2c859c09ea7dfe98740.camel@gmail.com>
Subject: Re: [PATCH 1/2] mfd: sec: Remove PMICs without compatibles
From:   David Virag <virag.david003@gmail.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Lee Jones <lee@kernel.org>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
        linux-rtc@vger.kernel.org
Date:   Thu, 02 Feb 2023 13:11:22 +0100
In-Reply-To: <35911bc7-6973-d4b0-18d4-22e93962f3c5@linaro.org>
References: <20230131183008.4451-1-virag.david003@gmail.com>
         <20230131183008.4451-2-virag.david003@gmail.com>
         <35911bc7-6973-d4b0-18d4-22e93962f3c5@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-02-02 at 12:24 +0100, Krzysztof Kozlowski wrote:
> On 31/01/2023 19:30, David Virag wrote:
> > The S5M8751 and S5M8763 PMIC chips have no corresponding compatible
> > values, so since board file support was removed for this driver,
> > there
> > is no way to specify these PMICs as present in boards anymore.
> > Remove leftovers of these chips since it's dead code.
> >=20
> > Signed-off-by: David Virag <virag.david003@gmail.com>
> > ---
>=20
> Thank you for your patch. There is something to discuss/improve.
>=20
> > =C2=A0int sec_irq_init(struct sec_pmic_dev *sec_pmic)
> > =C2=A0{
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0int ret =3D 0;
> > @@ -448,9 +362,6 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic)
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0}
> > =C2=A0
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0switch (type) {
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0case S5M8763X:
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0sec_irq_chip =3D &s5m8763_irq_chip;
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0break;
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0case S5M8767X:
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0sec_irq_chip =3D &s5m8767_irq_chip;
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0break;
> > diff --git a/include/linux/mfd/samsung/core.h
> > b/include/linux/mfd/samsung/core.h
> > index f92fe090473d..07aae649a86f 100644
> > --- a/include/linux/mfd/samsung/core.h
> > +++ b/include/linux/mfd/samsung/core.h
> > @@ -36,7 +36,6 @@
> > =C2=A0struct gpio_desc;
> > =C2=A0
> > =C2=A0enum sec_device_type {
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0S5M8751X,
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0S5M8763X,
>=20
> Drop also S5M8763X

Dropping it in the first patch would lead to build errors in the RTC
driver, so I do it in the second patch, but I see that you already
realized this in the 2nd reply.

>=20
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0S5M8767X,
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0S2MPA01,
> > diff --git a/include/linux/mfd/samsung/s5m8763.h
> > b/include/linux/mfd/samsung/s5m8763.h
> > deleted file mode 100644
>=20
>=20
> Best regards,
> Krzysztof
>=20

Best regards,
David