Date:   Thu, 2 Feb 2023 10:00:55 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Carsten Haitzler <Carsten.Haitzler@arm.com>
Cc:     Diederik de Haas <didi.debian@cknow.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <Mark.Rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] Script style improvements in lib/coresight.sh
Message-ID: <Y9u0B2RBiZYrJ5Kk@kernel.org>
References: <20230201214945.127474-1-didi.debian@cknow.org>
 <b13301b1-104f-ebb5-6b2a-3d6cc3eba8a3@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b13301b1-104f-ebb5-6b2a-3d6cc3eba8a3@arm.com>
Precedence: bulk

Em Thu, Feb 02, 2023 at 08:38:46AM +0000, Carsten Haitzler escreveu:
> On 2/1/23 21:49, Diederik de Haas wrote:
> > These 2 patches improve the efficiency and quality of the
> > lib/coresight.sh script.
> >
> > The first one uses grep's `-c` parameter to count the results instead of
> > piping it to `wc -l`.
> > The second one replaces the use of backticks (`...`) with $(...) as the
> > former has several potential issues while the latter does not.
> >
> > Diederik de Haas (2):
> >    perf test: Replace 'grep | wc -l' with 'grep -c'
> >    perf test: Replace legacy `...` with $(...)
> >
> >   tools/perf/tests/shell/lib/coresight.sh | 18 +++++++++---------
> >   1 file changed, 9 insertions(+), 9 deletions(-)
> >
> ACK to all of this series.

Thanks, added to the two patches, that I processed yesterday, still in
tmp.perf/core.

- Arnaldo