Date:   Thu, 2 Feb 2023 10:10:32 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Sandipan Das <sandipan.das@amd.com>
Cc:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        x86@kernel.org, peterz@infradead.org, bp@alien8.de,
        namhyung@kernel.org, jolsa@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, dave.hansen@linux.intel.com,
        james.clark@arm.com, irogers@google.com, eranian@google.com,
        maddy@linux.ibm.com, kjain@linux.ibm.com, tmricht@linux.ibm.com,
        ananth.narayan@amd.com, ravi.bangoria@amd.com,
        santosh.shukla@amd.com
Subject: Re: [PATCH v4 0/4] tools perf: Add branch speculation info
Message-ID: <Y9u2SKUYL5RgC0Cb@kernel.org>
References: <cover.1675333809.git.sandipan.das@amd.com>
 <Y9u0zJA05JNHpB+i@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Y9u0zJA05JNHpB+i@kernel.org>
Precedence: bulk

Em Thu, Feb 02, 2023 at 10:04:12AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Feb 02, 2023 at 05:56:13PM +0530, Sandipan Das escreveu:
> > AMD Last Branch Record Extension Version 2 (LbrExtV2) provides branch
> > speculation information and the perf UAPI is extended to provide this in
> > a generic way. Make perf tool show this additional information.
> > 
> > The UAPI changes can be found in commit 93315e46b000 ("perf/core: Add
> > speculation info to branch entries").
> > 
> > Requesting help from folks having access to big-endian systems to test
> > changes in the sample parsing test as I was only able to test these in
> > a ppc64 simulator.
> 
> I'll try folding some of these patches as 'perf test' must pass after
> each of them, so that we keep the codebase bisectable.
> 
> Right now, after appling the first patch on this v4 series:
> 
> ⬢[acme@toolbox perf]$ perf test 27
>  27: Sample parsing                                                  : FAILED!
> ⬢[acme@toolbox perf]$

So this is what I did:

$ git rebase -i HEAD~4
pick 266d6702711d299c perf script: Show branch speculation info
squash d2fa279aba8d2863 perf test sample-parsing: Update expected branch flags
pick b335ad966cadcbfa perf session: Show branch speculation info in raw dump
squash 272ce62f64e60fc7 perf test brstack: Update regex to include spec field

And then combined the commit messages. Please have bisectability in
mind, running 'perf test', and if it fails, add the fix to to 'perf
test' on the patch that introduced the problem.

Thanks,

- Arnaldo