Message-ID: <bae235dd-6d8b-908e-1544-df0f1be3f860@oracle.com>
Date:   Thu, 2 Feb 2023 20:31:24 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [External] : [PATCH v2 2/2] spi: intel: Add support for
 controllers
Content-Language: en-US
To:     Mauro Lima <mauro.lima@eclypsium.com>,
        mika.westerberg@linux.intel.com
Cc:     broonie@kernel.org, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230201205455.550308-1-mauro.lima@eclypsium.com>
 <20230201205455.550308-3-mauro.lima@eclypsium.com>
From:   ALOK TIWARI <alok.a.tiwari@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20230201205455.550308-3-mauro.lima@eclypsium.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2Y0cjVnQm1oaEJPcXpzZGhrSE15alcxNmhRZU5hamM2UzZQWGp6NThjNkgv?=
 =?utf-8?B?RTFyTUdqcW94OXNhUTJpTlNCeTQ5MzBockZNN0NZeFRLVzBlbU40eDV4NnZw?=
 =?utf-8?B?UERld1Z5MUxwbFN6MVhWWVZnVUgvNm5FYVd2VmNhQVRjTngzZ2Q3SFpGOXBH?=
 =?utf-8?B?VTk3c2lRZ01uL2RlMlBiakY3V2ViNDUzbTNtdzRST29RaS85KzcwRHpoeThy?=
 =?utf-8?B?NC9maGVnWVIwODlvUXdwaDM4R2F5NlBkbDB4YXpFZ2R0MEEwNG9sK0JDeWs3?=
 =?utf-8?B?Y2t3Qm93a241THlZekREa0FGckpUZzVCSTkzSmg1T2ZtYndwV1c0bDNpOXVK?=
 =?utf-8?B?a2ZqOU5yZmZVcEpLTm1FR2wwS1V2c1hUQ0hXSXY4OE9HL2RGSnJMeUFUS0pO?=
 =?utf-8?B?dTdWUWRZM0hpSURGUnpndDFwQVF6T2x0bjhJd1piWHc4SE9LMlRsZkpjQW9R?=
 =?utf-8?B?Vnp2UkZBdzQ3SXl0QmtCaXNNU0hwTGlEWlFFaERpMldTNkZnL0EvYU01MEEr?=
 =?utf-8?B?UkpOaWJQU0NuRDFHSGN4R05YYmhEOGl2WklsNEVnL0FwaXAyVWJwTklRR2V6?=
 =?utf-8?B?WGFycFdaZ3B0aXAxbkhkZk5abEVIKyt3TEdQNzErQWcrUUkwaDBHVGltVEll?=
 =?utf-8?B?a2FNNkN2cDI3eDI2QUFJSTd6OUxvWGhrb0JWa2JPdVVHL2EwMjY1UG1lMlZh?=
 =?utf-8?B?YU5PZlpsdlREdThhaWt4SUwyZEZYTmxhWnhydVNvL0dYVTVmNHBvaVRyVHFh?=
 =?utf-8?B?eVJrc0Zta2JnL3RuSSsrSCtMQ2ViaXZzdWkzOXRUbzVqNWRaK2tVZGlEcXFO?=
 =?utf-8?B?NmcyUjFEODNoVm1qSEZSSmMwdEZORVIzdnMzNmRONHhGcWtXWFJTMm5oYmw5?=
 =?utf-8?B?WTNXZFRBY0RxRjNwVENXWHFaU3Z5VDdyUVZoVXRQUTZicmlGcGlpeUt6V3l1?=
 =?utf-8?B?a1VWNGdvUEV3VEx3RWZoWHZBT2RTbmVuamF2VFNaTEQ0RFhEYUZPV3l0aC9N?=
 =?utf-8?B?RE04NzFaZ212ZTZmVXFMUHNXcG9tcS9vQmZqdm9heW1kbmF2Rm4zREZ3WGVs?=
 =?utf-8?B?ZGlLcXZyaXlRbHlNbFFHd1FDVGgvRkJDM0xLM2RhdGJsbllhWFdBNXdmdUs3?=
 =?utf-8?B?SVk0dkorQ1VnSElQbVlkQ1JGdSsvNjhKb0J3SXRpZW1IR1ZyY0JaSEVUQm5m?=
 =?utf-8?B?dmVJVW8rYlcyNDFiK0hpcjAwTmVvMzRkWWxwSTVMQWcxMmNHbGxwT29YNmJU?=
 =?utf-8?B?VGdvbTcxT01PWTlET0YzMFZBakhPSFZNRXVmV0txRVBqMnJpZUhYSmxVYkMy?=
 =?utf-8?B?RDdDSUV5cGZsdjRsbnJnT2Jld0Z4elB5VWhiUXNlS3dIU0Q3Vkk4RlNWaFFq?=
 =?utf-8?B?RW9JKzNhT3lZUHFORUtIVldaSGc2N0NNVkJ0azhBMG8zS0pJbVV3eTNMSFB6?=
 =?utf-8?B?elpNemh6SzEzWlhkNG1jWDlSZTkwU0huT1ltNU00ZEdYS2JZeHoyMjI0MXVi?=
 =?utf-8?B?RXNCdzA4YnVsMlBFdUVkWDdIcDh6eUo3ZGgzR2Q5VUI4WHNmSUc3QUVteXgr?=
 =?utf-8?B?ZWdwRVN5VVNacFErY09PVW1iOGNNOHZRUEZiWEtFVzlsemE3dENNbm5BdXAv?=
 =?utf-8?B?VW42bnBEaWlQZnhtQjBOY2l3R1lhL051bU5QaUF5YmVFaGZjYUU0eDFTaG9s?=
 =?utf-8?B?QkVhWDQ1OEdzd2VNampRVHRhU2Jyd3hZVW8ycEZiL1p5ZTRXOXZHUTBQQm5W?=
 =?utf-8?B?TWhrTkdqRWI5OTRDUXB1c3BheVZ3RldYQWxXOEdzRjRJNFR3T1U0TCtwc2hN?=
 =?utf-8?B?YXlRaXU5ZHc1NWVMRTVKRXFqdUVjZEQxOU15SG5IUU1mUmYwR1pjZUlhek9Z?=
 =?utf-8?B?dnVqakE2aThLQnJyQ1VVbm1XVXc1MFBuU2pxeHBkVVRJY2tTcnZhbVNvOHZX?=
 =?utf-8?B?NklSc2JvM28rdG5QOTVLQVBhSlVlOTdOM2wwd0dqOExZbk1keVZxaVZ6R1R3?=
 =?utf-8?B?TFU2ZGcxOTBnYzdMQUVLVDU4QW1mNDBKTGJRSjBtNlpBYXBkOFFEK2RTWE40?=
 =?utf-8?B?Skg0S0JOOVRTYWQ1NkhmQUt4UTRraVhQRXVRaUEwSW1hK05NaW5EVmt5MHJQ?=
 =?utf-8?B?aWh4ZXcrRW53L3QrbmV0aGtuZWFoczJDTXRxZ0c3NlQzdnR6eUpLbVUyc0Jk?=
 =?utf-8?B?U3c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kMMlm0kMlAB+bY/e/wFg7WJPLacjDkjh2oCYoa5HlEWe3B3ytSXKlUeOJryfrGUKST+MP9LKNzuBMwz48+eBahzDSje/2+xhJISodbQK2XerOcvuAHJoHnuYRGcj3CX5CKPlHHKLnc5SUKDfI/hml80ld1u6wP4cfCsXOsSjH9cmIh1dZ0WrCP7doBU9PnXY0GTeXhNwjQdZkzgDe0o4LLCVR98oJhc6tupfp95PEMxWVtZbkKlJTf0S5YGLh7KLX4p7uu6K3Iz1XWp4+E+v181MwP5DmMoiDFOuXVdUgKqAzaI+ViOHDx0CHu3fWvczny1MTtgQdDlhvYLa6oxPdOk9hS7BXKDBGKUjpvtWLMFL+0PH/d9H0JXSAkGEwk0M7GP/nnCs/tdLBZtA0D8uIg0TjGTbTC7hK1GDwlw4wSbggBhOD5yzoGAy14LDQiNtwocCgtJggUEXC4tmWDrNQwcOQlu2tRAOv6Bsr3Itu0yBBsqJJVbiTSana1j9xLlVHy5Jh/U6ohBzF+n+N6Lnh2MmZS5K47IXAsI1LvWbZo2lW+zirv9KXc5ganCcFkpylysSIeME3VTOs+XtgNPldFrnvjXVgoKLMVaoyLQxfexZbNSTyVcxfJugyzhMQuuZwWyfJt23K15C1/UiV9RmtpFWBl6BH14pdr663vvTXXDlbkDbjpgFC7uockxJwyPE7dVDWcaMNIkFv5T0bjRoNmkk29BOH0utpir7Lm2XdtXijwc3IKUngYI063NbyV0nfEFzfgC5lJ/VhuH9i0lw7MCTcfF8frvSsc3eDgEWBFUboa1uJiCtTUynNZ75yc8c+P+h9GEHfmFs2YwbULD0allg/FRk6o48EHA9rovJn+hS29Izwaa+ePWFOYtEpOJj
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37eb1004-0c90-45d7-7312-08db052e5f20
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4581.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 15:01:32.8153
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 98VM7E+EPEq/3QTHxL95lCIO1C2hXcOk2tFr8u0jalnMY07RSvoOpi4VH3lzyispYrSkcJU00HnI0Ssq10mC0B/UJfHWIM4Yj7qYTF7PPf8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6953
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-02-02_04,2023-02-02_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0
 suspectscore=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=999
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302020135
X-Proofpoint-GUID: D8OcrpOo5E0cPHDvG5horUm9KAJD8p0G
X-Proofpoint-ORIG-GUID: D8OcrpOo5E0cPHDvG5horUm9KAJD8p0G
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

look good.

Acked-by: Alok Tiwari <alok.a.tiwari@oracle.com>

On 2/2/2023 2:24 AM, Mauro Lima wrote:
> Add Device IDs to the module table for the following controllers:
> 	- 9da4  Cannon Lake 300 Series On-Package
> 	- a2a4  200 Series/Z370 Chipset Family SPI Controller
> 	- 9d24  Intel® 200 Series Chipset Family (Including Intel® X299),
> 		Intel® Z370 Intel® H310C,B365,
> 		also Intel® B460 and H410 Chipset Platform Controller Hub
>
> Signed-off-by: Mauro Lima <mauro.lima@eclypsium.com>
> ---
>   drivers/spi/spi-intel-pci.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/spi/spi-intel-pci.c b/drivers/spi/spi-intel-pci.c
> index 10fa3a7fa4f5..4d69e320d018 100644
> --- a/drivers/spi/spi-intel-pci.c
> +++ b/drivers/spi/spi-intel-pci.c
> @@ -75,9 +75,12 @@ static const struct pci_device_id intel_spi_pci_ids[] = {
>   	{ PCI_VDEVICE(INTEL, 0x7a24), (unsigned long)&cnl_info },
>   	{ PCI_VDEVICE(INTEL, 0x7aa4), (unsigned long)&cnl_info },
>   	{ PCI_VDEVICE(INTEL, 0x7e23), (unsigned long)&cnl_info },
> +	{ PCI_VDEVICE(INTEL, 0x9d24), (unsigned long)&cnl_info },
> +	{ PCI_VDEVICE(INTEL, 0x9da4), (unsigned long)&cnl_info },
>   	{ PCI_VDEVICE(INTEL, 0xa0a4), (unsigned long)&cnl_info },
>   	{ PCI_VDEVICE(INTEL, 0xa1a4), (unsigned long)&bxt_info },
>   	{ PCI_VDEVICE(INTEL, 0xa224), (unsigned long)&bxt_info },
> +	{ PCI_VDEVICE(INTEL, 0xa2a4), (unsigned long)&cnl_info },
>   	{ PCI_VDEVICE(INTEL, 0xa324), (unsigned long)&cnl_info },
>   	{ PCI_VDEVICE(INTEL, 0xa3a4), (unsigned long)&cnl_info },
>   	{ },