Message-ID: <41eafd31-558d-613c-69ef-15230a80db5c@gmail.com>
Date:   Thu, 2 Feb 2023 16:01:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v6 0/6] add support for MT8195 VPPSYS on MMSYS and MUTEX
Content-Language: en-US
From:   Matthias Brugger <matthias.bgg@gmail.com>
To:     Moudy Ho <moudy.ho@mediatek.com>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org,
        Project_Global_Chrome_Upstream_Group@mediatek.com
References: <20230118032122.29956-1-moudy.ho@mediatek.com>
 <cd82e2a1-dbf4-88ee-f658-f695ae9ef56a@gmail.com>
In-Reply-To: <cd82e2a1-dbf4-88ee-f658-f695ae9ef56a@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 02/02/2023 13:40, Matthias Brugger wrote:
> Whole series queued for the next merge window.
> 

I encountered some compile errors, so I deleted the whole series, please fix and 
resubmit. Thanks

drivers/soc/mediatek/mtk-mmsys.c: In function 'mtk_mmsys_vpp_rsz_merge_config':
drivers/soc/mediatek/mtk-mmsys.c:261:9: error: too few arguments to function 
'mtk_mmsys_update_bits'
   261 |         mtk_mmsys_update_bits(dev_get_drvdata(dev), reg, ~0, enable);
       |         ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
   129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys, u32 offset, 
u32 mask, u32 val,
       |             ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c: In function 'mtk_mmsys_vpp_rsz_dcm_config':
drivers/soc/mediatek/mtk-mmsys.c:270:9: error: too few arguments to function 
'mtk_mmsys_update_bits'
   270 |         mtk_mmsys_update_bits(dev_get_drvdata(dev),
       |         ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
   129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys, u32 offset, 
u32 mask, u32 val,
       |             ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:273:9: error: too few arguments to function 
'mtk_mmsys_update_bits'
   273 |         mtk_mmsys_update_bits(dev_get_drvdata(dev),
       |         ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
   129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys, u32 offset, 
u32 mask, u32 val,
       |             ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:278:9: error: too few arguments to function 
'mtk_mmsys_update_bits'
   278 |         mtk_mmsys_update_bits(dev_get_drvdata(dev),
       |         ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
   129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys, u32 offset, 
u32 mask, u32 val,
       |             ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:281:9: error: too few arguments to function 
'mtk_mmsys_update_bits'
   281 |         mtk_mmsys_update_bits(dev_get_drvdata(dev),
       |         ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-mmsys.c:129:13: note: declared here
   129 | static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys, u32 offset, 
u32 mask, u32 val,
       |             ^~~~~~~~~~~~~~~~~~~~~

Regards,
Matthias

> Thanks!
> 
> On 18/01/2023 04:21, Moudy Ho wrote:
>> Changes since v5:
>> - Depend on :
>>    [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=713031
>>
>> Changes since v4:
>> - Rebase on linux-next.
>> - Remove MMSYS fallback compatible.
>> - Migrate MT8195 VPPSYS0/1 from clock to mtk-mmsys driver.
>>
>> Changes since v3:
>> - Rebase on linux-next.
>>
>> Changes since v2:
>> - Depend on :
>>    [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097
>> - Split dts settings into two patches based on belonging to MMSYS or MUTEX.
>>
>> Changes since v1:
>> - Depend on :
>>    [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097
>> - Add compatible names to VPPSYS0 and VPPSYS1 in MMSYS binding file.
>> - Fix VPPSYS's MMSYS and MUTEX dts to pass the dtsb_check.
>> - Rename mtk_mmsys_merge_config() and mtk_mmsys_rsz_dcm_config() to
>>    mtk_mmsys_vpp_rsz_merge_config() and mtk_mmsys_vpp_rsz_dcm_config().
>> - Clean up mtk_mmsys_vpp_rsz_dcm_config().
>> - Add a comment to mtk_mutex_write_mod() and clean it up for use in more
>>    than 32 mods.
>>
>> Hi,
>>
>> This series add support for MT8195's two VPPSYS(Video Processor Pipe Subsystem),
>> under which there will be corresponding MMSYS and MUTEX settings that
>> need to be configured.
>>
>> Moudy Ho (1):
>>    arm64: dts: mediatek: mt8195: add MUTEX configuration for VPPSYS
>>
>> Roy-CW.Yeh (5):
>>    dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS
>>    arm64: dts: mediatek: mt8195: add MMSYS configuration for VPPSYS
>>    soc: mediatek: mmsys: add config api for RSZ switching and DCM
>>    soc: mediatek: mutex: Add mtk_mutex_set_mod support to set MOD1
>>    soc: mediatek: mutex: support MT8195 VPPSYS
>>
>>   .../bindings/soc/mediatek/mediatek,mutex.yaml |   1 +
>>   arch/arm64/boot/dts/mediatek/mt8195.dtsi      |  26 +++-
>>   drivers/soc/mediatek/mt8195-mmsys.h           |  13 ++
>>   drivers/soc/mediatek/mtk-mmsys.c              |  42 ++++++
>>   drivers/soc/mediatek/mtk-mutex.c              | 135 +++++++++++++++++-
>>   include/linux/soc/mediatek/mtk-mmsys.h        |   4 +
>>   include/linux/soc/mediatek/mtk-mutex.h        |  35 +++++
>>   7 files changed, 245 insertions(+), 11 deletions(-)
>>