Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754706AbXIAK5U (ORCPT ); Sat, 1 Sep 2007 06:57:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752495AbXIAK5H (ORCPT ); Sat, 1 Sep 2007 06:57:07 -0400 Received: from nic.NetDirect.CA ([216.16.235.2]:35613 "EHLO rubicon.netdirect.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753322AbXIAK5F (ORCPT ); Sat, 1 Sep 2007 06:57:05 -0400 X-Originating-Ip: 72.143.66.27 Date: Sat, 1 Sep 2007 06:44:06 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Randy Dunlap cc: Simon Arlott , Sam Ravnborg , Linux Kernel Mailing List , Stefan Richter , Adrian Bunk , Jeff Garzik , Gabriel C , netdev@vger.kernel.org Subject: Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus In-Reply-To: <20070831102527.09fb42c0.rdunlap@xenotime.net> Message-ID: References: <469E75AA.7040109@pimpmylinux.org> <20070718134012.cde2f956.randy.dunlap@oracle.com> <469E7BE1.6090401@garzik.org> <20070718210903.GM3801@stusta.de> <20070719054742.GN3801@stusta.de> <469F240E.9040205@s5r6.in-berlin.de> <20070719083109.13b2ab56.rdunlap@xenotime.net> <469FE045.3070403@simon.arlott.org.uk> <20070831102527.09fb42c0.rdunlap@xenotime.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-16.8, required 5, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -15.00, INIT_RECVD_OUR_AUTH -20.00, RCVD_IN_SORBS_DUL 20.00) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1790 Lines: 58 On Fri, 31 Aug 2007, Randy Dunlap wrote: > On Thu, 19 Jul 2007 23:05:57 +0100 Simon Arlott wrote: > > What about something like this? I'm not sure if the addition to > > sym_init is desirable... I also had to prefix _ to the name for > > now otherwise it conflicts badly with the current symbols. It > > probably should stop "depends on _BROKEN" etc. too. > > Hi Simon, > > (sorry for the delay) > > I like this patch very much... I just can't get it to build (on > 2.6.23-rc4). i got a patch from simon a while back, and it failed with "shift/reduce" conflicts. is that what you're seeing? > > while (1) { > > printf("%*s%s ", indent - 1, "", menu->prompt->text); > > + switch (sym->maturity) { > > + case M_EXPERIMENTAL: > > + printf("(EXPERIMENTAL) "); > > + break; > > + case M_DEPRECATED: > > + printf("(DEPRECATED) "); > > + break; > > + case M_OBSOLETE: > > + printf("(OBSOLETE) "); > > + break; > > + case M_BROKEN: > > + printf("(BROKEN) "); > > + break; > > + default: > > + break; > > + } > > if (sym->name) > > printf("(%s) ", sym->name); > > type = sym_get_type(sym); for now, simon, why not just reduce this to supporting only DEPRECATED and OBSOLETE so that it can be at least tested as "proof of concept?" rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/