Date:   Thu, 2 Feb 2023 16:40:54 +0100
From:   Lorenzo Pieralisi <lpieralisi@kernel.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Marek Vasut <marek.vasut+renesas@gmail.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        linux-renesas-soc@vger.kernel.org, Rob Herring <robh@kernel.org>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: rcar: avoid defines prefixed with CONFIG
Message-ID: <Y9vZhv2+F4e/Asko@lpieralisi>
References: <20230113084516.31888-1-lukas.bulwahn@gmail.com>
 <CAMuHMdX_TPgXO2KYNdD5rRzuE9m6_JxfW-otWzw7r7Wptq_rOQ@mail.gmail.com>
 <Y8GHICwCNRsYCva8@lpieralisi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y8GHICwCNRsYCva8@lpieralisi>
Precedence: bulk

On Fri, Jan 13, 2023 at 05:30:24PM +0100, Lorenzo Pieralisi wrote:
> On Fri, Jan 13, 2023 at 10:05:09AM +0100, Geert Uytterhoeven wrote:
> > Hi Lukas,
> > 
> > On Fri, Jan 13, 2023 at 9:52 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> > > Defines prefixed with "CONFIG" should be limited to proper Kconfig options,
> > > that are introduced in a Kconfig file.
> > >
> > > Here, a definition for a bitmask to configure the SEND_ENABLE mode is named
> > > CONFIG_SEND_ENABLE.
> > >
> > > Rename this local definition to CONFIGURE_SEND_ENABLE to avoid defines
> > > prefixed with "CONFIG".
> > >
> > > No functional change.
> > >
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > 
> > Thanks for your patch!
> > 
> > > --- a/drivers/pci/controller/pcie-rcar.h
> > > +++ b/drivers/pci/controller/pcie-rcar.h
> > > @@ -11,7 +11,7 @@
> > >
> > >  #define PCIECAR                        0x000010
> > >  #define PCIECCTLR              0x000018
> > > -#define  CONFIG_SEND_ENABLE    BIT(31)
> > > +#define  CONFIGURE_SEND_ENABLE BIT(31)
> > 
> > The R-Car Gen3 rev. 2.30 Hardware User's Manual calls the bit "CCIE".
> > 
> > Hence if I would have written the driver, I would have used
> > 
> >     #define PCIECCTLR_CCIE     BIT(31)   /* Configuration Send Enable */
> 
> Should I change it when I merge it ? That makes sense actually.

If I don't hear from anybody I will make the change above and merge it.

Thanks,
Lorenzo

> 
> Thanks,
> Lorenzo
> 
> > >  #define  TYPE0                 (0 << 8)
> > >  #define  TYPE1                 BIT(8)
> > >  #define PCIECDR                        0x000020
> > 
> > Gr{oetje,eeting}s,
> > 
> >                         Geert
> > 
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> > 
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> >                                 -- Linus Torvalds