Date:   Thu, 2 Feb 2023 16:44:17 +0100
From:   Jiri Pirko <jiri@resnulli.us>
To:     Moshe Shemesh <moshe@nvidia.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@nvidia.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/7] devlink: Move devlink dev code to a
 separate file
Message-ID: <Y9vaUZkiERmasO/9@nanopsycho>
References: <1675349226-284034-1-git-send-email-moshe@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1675349226-284034-1-git-send-email-moshe@nvidia.com>
Precedence: bulk

Thu, Feb 02, 2023 at 03:46:59PM CET, moshe@nvidia.com wrote:
>This patchset is moving code from the file leftover.c to new file dev.c.
>About 1.3K lines are moved by this patchset covering most of the devlink
>dev object callbacks and functionality: reload, eswitch, info, flash and
>selftest.
>
>Moshe Shemesh (7):
>  devlink: Split out dev get and dump code
>  devlink: Move devlink dev reload code to dev
>  devlink: Move devlink dev eswitch code to dev
>  devlink: Move devlink dev info code to dev
>  devlink: Move devlink dev flash code to dev
>  devlink: Move devlink_info_req struct to be local
>  devlink: Move devlink dev selftest code to dev
>
> net/devlink/Makefile        |    2 +-
> net/devlink/dev.c           | 1343 ++++++++++++++++++++++++++++++++
> net/devlink/devl_internal.h |   30 +
> net/devlink/leftover.c      | 1470 ++---------------------------------
> 4 files changed, 1435 insertions(+), 1410 deletions(-)
> create mode 100644 net/devlink/dev.c

Looks fine to me.

Thanks Moshe!

Reviewed-by: Jiri Pirko <jiri@nvidia.com>