MIME-Version: 1.0
References: <20230201182854.2158535-1-srinivas.pandruvada@linux.intel.com>
In-Reply-To: <20230201182854.2158535-1-srinivas.pandruvada@linux.intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 2 Feb 2023 17:20:34 +0100
Message-ID: <CAJZ5v0i7HXqHMm6ewfXKqNZ5+jCGHwueFeKyXNo-bwbc0CHOBg@mail.gmail.com>
Subject: Re: [PATCH v5 0/4] Use idle_inject framework for intel_powerclamp
To:     Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc:     rafael@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org,
        rui.zhang@intel.com, kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Feb 1, 2023 at 7:35 PM Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> Dropped the per core idle injection patch from this series. Hence the
> subject of this series is changed. Now it is just for using
> idle inject framework for intel_powerclamp.
> Add additionl patch for module paramters to set cpumask and max idle percent.
>
> The old cover letter:
> This series introduces per CPU idle injection. In preparation for this
> enhance the existing powercap/idle_inject and modify intel_powerclamp
> to use this. Then add per core idle injection driver.
>
> v5:
> - additionl patch for module paramters to set cpumask and max idle percent
> - One fix for update callback
> - Rebased on top of patch
>  "thermal: intel_powerclamp: Fix cur_state for multi package system"

Patches [1-3/4] have been applied as 6.3 material and I'll comment
patch [4/4] separately.

>
> v4:
> - Dropped the per core idle inject patch
>
> v3
> - Change callback from per CPU to per device and use in intel_powerclamp
> - Remove unused var in per cpu idle injection module
>
> v2
> - Update based on feedback from Rafael on patch 2/4
> - Kconfig dependency issue
> Reported-by: kernel test robot <lkp@intel.com>
>
> Srinivas Pandruvada (4):
>   powercap: idle_inject: Export symbols
>   powercap: idle_inject: Add update callback
>   thermal/drivers/intel_powerclamp: Use powercap idle-inject framework
>   thermal/drivers/intel_powerclamp: Add additional module params
>
>  .../driver-api/thermal/intel_powerclamp.rst   |  22 +
>  drivers/powercap/idle_inject.c                |  57 +-
>  drivers/thermal/intel/Kconfig                 |   2 +
>  drivers/thermal/intel/intel_powerclamp.c      | 512 ++++++++++--------
>  include/linux/idle_inject.h                   |   3 +
>  5 files changed, 367 insertions(+), 229 deletions(-)
>
> --
> 2.39.1
>