Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754813AbXIAMrx (ORCPT ); Sat, 1 Sep 2007 08:47:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751686AbXIAMrn (ORCPT ); Sat, 1 Sep 2007 08:47:43 -0400 Received: from pasmtpa.tele.dk ([80.160.77.114]:50006 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751655AbXIAMrm (ORCPT ); Sat, 1 Sep 2007 08:47:42 -0400 Date: Sat, 1 Sep 2007 14:49:01 +0200 From: Sam Ravnborg To: "Robert P. J. Day" Cc: Randy Dunlap , Simon Arlott , Linux Kernel Mailing List , Stefan Richter , Adrian Bunk , Jeff Garzik , Gabriel C , netdev@vger.kernel.org Subject: Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus Message-ID: <20070901124901.GA2935@uranus.ravnborg.org> References: <20070719054742.GN3801@stusta.de> <469F240E.9040205@s5r6.in-berlin.de> <20070719083109.13b2ab56.rdunlap@xenotime.net> <469FE045.3070403@simon.arlott.org.uk> <20070831102527.09fb42c0.rdunlap@xenotime.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1825 Lines: 54 On Sat, Sep 01, 2007 at 06:44:06AM -0400, Robert P. J. Day wrote: > > > > while (1) { > > > printf("%*s%s ", indent - 1, "", menu->prompt->text); > > > + switch (sym->maturity) { > > > + case M_EXPERIMENTAL: > > > + printf("(EXPERIMENTAL) "); > > > + break; > > > + case M_DEPRECATED: > > > + printf("(DEPRECATED) "); > > > + break; > > > + case M_OBSOLETE: > > > + printf("(OBSOLETE) "); > > > + break; > > > + case M_BROKEN: > > > + printf("(BROKEN) "); > > > + break; > > > + default: > > > + break; > > > + } > > > if (sym->name) > > > printf("(%s) ", sym->name); > > > type = sym_get_type(sym); > > for now, simon, why not just reduce this to supporting only DEPRECATED > and OBSOLETE so that it can be at least tested as "proof of concept?" The principle with letting a dependency add text to the promts are good. But the implementation done by Simon with a language extension is not good. A simple and better approach would be to use the newly added option support for this and let the backend generate the promtps. I have not yet tried to cook up a patch for it, but it should be quite generaic and doable. config EXPERIMENTAL option appendprompt=" (EXPERIMENTAL) config DEPRECATED option appendprompt=" (DEPRECATED) Then the dependency added will automatically append to the prompt. It would probarly have be done in two steps. One that introduce a helper function to retreive the prompt text and introduce it. And next a patch to add a text if a symbol has a dependency on a symbol with a specific option assigned. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/