Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754059AbXIANJq (ORCPT ); Sat, 1 Sep 2007 09:09:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751743AbXIANJg (ORCPT ); Sat, 1 Sep 2007 09:09:36 -0400 Received: from nic.NetDirect.CA ([216.16.235.2]:39024 "EHLO rubicon.netdirect.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751419AbXIANJf (ORCPT ); Sat, 1 Sep 2007 09:09:35 -0400 X-Originating-Ip: 72.143.66.27 Date: Sat, 1 Sep 2007 08:56:30 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Sam Ravnborg cc: Randy Dunlap , Simon Arlott , Linux Kernel Mailing List , Stefan Richter , Adrian Bunk , Jeff Garzik , Gabriel C , netdev@vger.kernel.org Subject: Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus In-Reply-To: <20070901124901.GA2935@uranus.ravnborg.org> Message-ID: References: <20070719054742.GN3801@stusta.de> <469F240E.9040205@s5r6.in-berlin.de> <20070719083109.13b2ab56.rdunlap@xenotime.net> <469FE045.3070403@simon.arlott.org.uk> <20070831102527.09fb42c0.rdunlap@xenotime.net> <20070901124901.GA2935@uranus.ravnborg.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-16.723, required 5, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -15.00, INIT_RECVD_OUR_AUTH -20.00, RCVD_IN_SORBS_DUL 20.00, TW_VN 0.08) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2385 Lines: 68 On Sat, 1 Sep 2007, Sam Ravnborg wrote: > On Sat, Sep 01, 2007 at 06:44:06AM -0400, Robert P. J. Day wrote: > > > > > > while (1) { > > > > printf("%*s%s ", indent - 1, "", menu->prompt->text); > > > > + switch (sym->maturity) { > > > > + case M_EXPERIMENTAL: > > > > + printf("(EXPERIMENTAL) "); > > > > + break; > > > > + case M_DEPRECATED: > > > > + printf("(DEPRECATED) "); > > > > + break; > > > > + case M_OBSOLETE: > > > > + printf("(OBSOLETE) "); > > > > + break; > > > > + case M_BROKEN: > > > > + printf("(BROKEN) "); > > > > + break; > > > > + default: > > > > + break; > > > > + } > > > > if (sym->name) > > > > printf("(%s) ", sym->name); > > > > type = sym_get_type(sym); > > > > for now, simon, why not just reduce this to supporting only DEPRECATED > > and OBSOLETE so that it can be at least tested as "proof of concept?" > > The principle with letting a dependency add text to the promts are good. > But the implementation done by Simon with a language extension is not good. > A simple and better approach would be to use the newly added option > support for this and let the backend generate the promtps. > > I have not yet tried to cook up a patch for it, but it should be > quite generaic and doable. > > config EXPERIMENTAL > option appendprompt=" (EXPERIMENTAL) > > config DEPRECATED > option appendprompt=" (DEPRECATED) but this is deviating from the basic principle that these things are not regular Kconfig "config" settings -- they are a new beast entirely, and need a new infrastructure to support them. put another way, they are not a normal kernel feature to be selected or deselected. they are, rather, *attributes* that can be *applied* to kernel features, in the same way as is done with "bool" or "string". making these things regular config directives defeats the whole purpose. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/