From:   Jay Vosburgh <jay.vosburgh@canonical.com>
To:     Qi Zheng <zhengqi.arch@bytedance.com>
cc:     gregkh@linuxfoundation.org, rafael@kernel.org, vfalico@gmail.com,
        andy@greyhouse.net, vireshk@kernel.org, nm@ti.com,
        sboyd@kernel.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] bonding: fix error checking in bond_debug_reregister()
In-reply-to: <20230202093256.32458-3-zhengqi.arch@bytedance.com>
References: <20230202093256.32458-1-zhengqi.arch@bytedance.com> <20230202093256.32458-3-zhengqi.arch@bytedance.com>
Comments: In-reply-to Qi Zheng <zhengqi.arch@bytedance.com>
   message dated "Thu, 02 Feb 2023 17:32:55 +0800."
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <20120.1675363297.1@famine>
Content-Transfer-Encoding: quoted-printable
Date:   Thu, 02 Feb 2023 10:41:37 -0800
Message-ID: <20121.1675363297@famine>
Precedence: bulk

Qi Zheng <zhengqi.arch@bytedance.com> wrote:

>Since commit ff9fb72bc077 ("debugfs: return error values,
>not NULL") changed return value of debugfs_rename() in
>error cases from %NULL to %ERR_PTR(-ERROR), we should
>also check error values instead of NULL.
>
>Fixes: ff9fb72bc077 ("debugfs: return error values, not NULL")
>Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>

Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>

>---
> drivers/net/bonding/bond_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bon=
d_debugfs.c
>index 4f9b4a18c74c..594094526648 100644
>--- a/drivers/net/bonding/bond_debugfs.c
>+++ b/drivers/net/bonding/bond_debugfs.c
>@@ -76,7 +76,7 @@ void bond_debug_reregister(struct bonding *bond)
> =

> 	d =3D debugfs_rename(bonding_debug_root, bond->debug_dir,
> 			   bonding_debug_root, bond->dev->name);
>-	if (d) {
>+	if (!IS_ERR(d)) {
> 		bond->debug_dir =3D d;
> 	} else {
> 		netdev_warn(bond->dev, "failed to reregister, so just unregister old o=
ne\n");
>-- =

>2.20.1
>