Date:   Thu, 2 Feb 2023 12:13:02 -0800
From:   Sukadev Bhattiprolu <quic_sukadev@quicinc.com>
To:     Roman Gushchin <roman.gushchin@linux.dev>
CC:     Chris Goldsworthy <quic_cgoldswo@quicinc.com>,
        Rik van Riel <riel@surriel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Roman Gushchin <guro@fb.com>, Vlastimil Babka <vbabka@suse.cz>,
        Joonsoo Kim <js1304@gmail.com>,
        Minchan Kim <minchan@kernel.org>,
        Georgi Djakov <quic_c_gdjako@quicinc.com>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm,page_alloc,cma: configurable CMA utilization
Message-ID: <20230202201302.GB22373@hu-sbhattip-lv.qualcomm.com>
References: <20230131071052.GB19285@hu-sbhattip-lv.qualcomm.com>
 <Y9lZoI89Nw4bjjOZ@P9FQF9L96D.corp.robot.car>
 <20230131201001.GA8585@hu-sbhattip-lv.qualcomm.com>
 <Y9mraBHucYdnHXiS@P9FQF9L96D.corp.robot.car>
 <20230201040628.GA3767@hu-cgoldswo-sd.qualcomm.com>
 <Y9q2yUZmCiNd7iYC@P9FQF9L96D.corp.robot.car>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y9q2yUZmCiNd7iYC@P9FQF9L96D.corp.robot.car>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk


Hi Roman,

On Wed, Feb 01, 2023 at 11:00:25AM -0800, Roman Gushchin wrote:
> Then _maybe_ a new knob is justified, at least I don't have better ideas.
> Rik, do you have any input here?
> 
> Let's then define it in a more generic way and _maybe_ move to the cma
> sysfs/debugfs (not 100% sure about this part, but probably worth exploring).

We should be able to use a sysfs parameter too. Will try that out. But could
you elaborate on what is more generic way?

Also regarding following in the earlier message:

> Also, if decide to go with a new sysctl, we probably want to define it differently,
> e.g. as a [0-1000)/1000 of the zone size. But, honestly, I'm not sold yet.

Are you saying that the ratio should be limited to 1000th of the zone size?
Or of the free pages in the zone? If the zone is large, 1000th of it would
still be quite big?

Sukadev