Message-ID: <57fe17e4-b60a-49aa-4661-bf88b0753953@oracle.com>
Date:   Thu, 2 Feb 2023 14:00:59 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v2 4/7] virtio: VIRTIO_DEVICE_F_MASK for all per-device
 features
Content-Language: en-US
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     jasowang@redhat.com, parav@nvidia.com, elic@nvidia.com,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <1675207345-22328-1-git-send-email-si-wei.liu@oracle.com>
 <1675207345-22328-5-git-send-email-si-wei.liu@oracle.com>
 <20230202122851-mutt-send-email-mst@kernel.org>
From:   Si-Wei Liu <si-wei.liu@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20230202122851-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTVNdEQwNUFwVFl6cFlVSTVYYVlMQllkNFlwZ0dYUzFCbkJXL2x2UGVqYmRh?=
 =?utf-8?B?QWtuY2lRTzZRN3ZGWWs4T0JIQ1J3c0s4d3JzM2Z6Z3Zwa3RDU014amVNeHdQ?=
 =?utf-8?B?Y3ZnRCszL1pMNkNvQ0kzMFNrK0JmZWVlQjgweEZDUGxOZ2pSUjUwMXd2UFRI?=
 =?utf-8?B?V3kyUjh2UzBvN2M0bkFiUldEZHlRTlBPUW1YYWhvQm4yMlR1cE1aUkZMZzhp?=
 =?utf-8?B?Q1V4YXBUc3pFY3dsNTVwOE1FUHB6ZXI3bTFwWjdDWk1IRDd3bTBHTTJVOGNx?=
 =?utf-8?B?OWRpUENwOGQwVnd2YUFEdHVwallybjBzMU5DOFBPekZCNjFlMGl5OHFkeXho?=
 =?utf-8?B?eXBwQWdqS3p1YnFBQXZGT09uWmY0UGRMY3NVTnlLTzVia0dyOG9Ebm1Pa29F?=
 =?utf-8?B?ZXE0ekhEWW9ZK3hJVnFuR3RjM0ZFNU5EUUxOWmVDQVJJMkltR3Y5bE5JWlZ3?=
 =?utf-8?B?Z0dqbEgyZ0lTQmhpNHQvVjNTbHhHbVoyb3M4czN2UU8vR2FBUWVZa0F0ckdi?=
 =?utf-8?B?RXNCSEx4c245cXUxTis2VnZzVW12ejhkcHhyS0E0RDdiT3FtQmtEaTd3Rk45?=
 =?utf-8?B?aXUrSlFoTFhzQ3lZV2hNVXFGcGZlcURCeVk3Z3hFK0FhQ2tlTDRQU1pkNlJq?=
 =?utf-8?B?eVB1S3VnU0RUUFhISXhmUDM2OHpYcW82aGpRbFkyWGNvb3JjeEF5UC8vVjJF?=
 =?utf-8?B?bDdRTERaZ1ZxQVo0YVMremhJeHNveTNBNTZTRFdVWGJpL0hWRTErY2MyZnRh?=
 =?utf-8?B?S040ekQ2cHplZWxZT1g5ZFdDSGxqREJSektWN1RTV0pmOUZ2Q0t3RnllQUp6?=
 =?utf-8?B?Y2pSbDdjcGtjcHY4VHJkR2hhS2ZrK0ZaUFFTMlNGSm9seEJvdzliTDlqNDZn?=
 =?utf-8?B?b0RXbU5aVHJnUXN1OEQrelpQNHFFdTBHZUQvaWt3R09LNk1zRkdBcFVCWHpK?=
 =?utf-8?B?eEJ6RnJmRUNlVFRmVTBBSjc3S0RSRDlkcjNpMXhjejRxOXgrcGlkS09CN2FR?=
 =?utf-8?B?RDhlem5SYmUwYUZvem5lTG5jZlVsdHVGQW15OGxSQThnTGQ5WWlPMEhLOEFU?=
 =?utf-8?B?TDdhTjFoRUxpVkFqV3RvM0lGSCtLTk15dDhMQkhFNUtLRzJlYTlYdGFPdUlO?=
 =?utf-8?B?alozL1hnZTdpWlYzREsycFk2M29wdU82VENRY1FKWGVEMjdORlVqaERNNWs3?=
 =?utf-8?B?dEpOTGVFblpMdnI4bUllTFpYeEovUWJ5OXowUldvZzlQSm9KWWdYM0JzaEtw?=
 =?utf-8?B?ZUI4a2xuWjR3MmdyQUhtcnpNQ0FGdmRqZG9ZYVk0VWpqRDhmUzdtQ1VCck9V?=
 =?utf-8?B?Q1JaQVU2bndsNXMrekdyY0NKelI3bHhWbmIwd2RTRWxBZnhLVTkvY1dwaENT?=
 =?utf-8?B?RnZibzkxMnF0cDhidlhJR1ZXZjBFR2I4U2RPNkc4RzlLMkN0TUJCK3RHcWtW?=
 =?utf-8?B?RDJvM3g2U3NBQ0g1NXJOKzBGU0x2M0xic1lWd1Uwd0ZJSWtQWVBWUWJVYmRj?=
 =?utf-8?B?YjhXT0NWVTRjKzdOK3VabHFWZmlEWE9DWGI5RlplRTlkbFErZGRYcGxlcXJn?=
 =?utf-8?B?Rm1GTERhT0hCS0JrZFNROG0waUJ4WFNsUUVpbU5qVTJYZDFSNFBWRHhiQWZR?=
 =?utf-8?B?VFlSU28yQ3RERUlmRzU4QzZtRUNjYVFVNmh1ZGgya2p5OWhHemVDR2JzZ3Bs?=
 =?utf-8?B?VVhJbGZYd0dLY0h6aXBhU21SV1dpN0hpdHlXaVpxNmgxaWRxa1VCV2hzK2tz?=
 =?utf-8?B?OHZpZVhHSUJCeDBLVDhRMHRmNHQyWkNhZ1pXaVlGanhFZGxSeDNLdW16M1NH?=
 =?utf-8?B?ZFdGUDFaVytxQzY0bWh2dmtyck1HTHYzd2lHNkxNUVVZTmV6TmJkOFBwYytL?=
 =?utf-8?B?eXFtMmFGcWJGSnJLKzkvR1A2ckJWL2VtNUpuOStLSytNMS93QmNwanhGYVlT?=
 =?utf-8?B?L1g2TmpSczhyODFrdDdkallGVTd0SjR1K0hXRzViV3c0cXJ6cmFpVUdmWTZa?=
 =?utf-8?B?dlA2UXZlYldpY1M1SGt4bitDbSt5L0NNeVpoVlViK3lBTUNOQmZmdDFsdjVy?=
 =?utf-8?B?M05hZEVHMmpYU0c2bDFxUFZTdXhjVnpiOXFuU1FuMTlmZVhSTDB3Y1VtTTlv?=
 =?utf-8?Q?EJoDVKtBBZrelAIOUY2lJ5CTk?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /DH4tlTDHH6yngcsMrhGvVuXXNbjI9Bf7Sdj1gp4WYlotEegjcoQHlKLDlPqSTbPteLGWRpCm0biPzx+YgeCHTTVafjZgH/xxsQR7RC7lJ0g9vDVW3e3Ada8RNlhZeAd2OWZEEHGAHCZuHo/te3IdmmK1MFBJPWuy5u6BPjB8vH93kfOyMyyXFTFlOXz+hFBm4/zlJdii8lr77LxlYVAQUUm5NrcVmETWZuxvIXI0dW6NoF1LdEY84i6dGNIoC82GLa/C3liy8Ram0fMY0L44jQBBShHo0SpVMwvPfR3yt1TSeVbeUeqm50VxqI2PCBRT1XCZ98yYHPodoj2JA/fkI3cpZWQR1vaLvsWXAsaJF2UoKdrInFi6itd4oSRVTYxIq/Ne+2VkYv7dBEpo80WAO3+ZbBPveoYt5/1PwejuZOnGIeRjVIIzbYyqJRWC3DXZpb0FJAmDIuDoeQkZd+x1NioWZIgRw7Ace1pduJQPJH/EdY9g3Bb5vcjY+bLukcXtyO/dp74+PMr4HcXUC8KJqZQMEwacnq5yYxjsup6z2bdGPT4teBSeI8F5zRanVARnr48hWpIQGuii9ono9Fk60KgpdY4DBsnrrSFXWN5U31zRXPRFHgh5vT0YFdQtM+pAszEf0xc86XEhhuEcHKhKLkP8V4HaG3vuyPI01KpuQHj6qt61ZjTjVB6pZZliW2Cd+CClNZmnr3kEUVzFJRY/EN5/XANInc60pEvSfVvle8iMRyMsrAdhVvK3F/EADNr8Y3MemzcyE7tb4MuH/Hukzn89D6+e1T0ptNP6he2vc1biVJiOmZaOzLT1b+Ua/4vV92BdP6fxq7+dC+VBcLPSyUyCJfBFZOvkfC+B+XTH+21k61bRqAp/rvLy+rQazHPz28MNq19wWhYwxnuUgPgYw==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 423dcf1f-d065-44b9-6faf-08db0568f950
X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6535.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 22:01:02.1530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /auGOaYc9FGYceBGm5HBMvbG1DGKV5cP520/Vf5GyV95iilFWo8uTKfFhaNIBhXzwAEGoOoaDrMtfMkvUyN3zQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4881
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-02-02_14,2023-02-02_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0
 adultscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302020195
X-Proofpoint-GUID: 0X7ROxRar9p5cu6wa4l77EhDNQGlAxx6
X-Proofpoint-ORIG-GUID: 0X7ROxRar9p5cu6wa4l77EhDNQGlAxx6
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/2/2023 9:29 AM, Michael S. Tsirkin wrote:
> On Tue, Jan 31, 2023 at 03:22:22PM -0800, Si-Wei Liu wrote:
>> Introduce VIRTIO_DEVICE_F_MASK bitmask used for identification
>> of per-device features. Feature bits VIRTIO_TRANSPORT_F_START
>> through VIRTIO_TRANSPORT_F_END are reserved for transport
>> features hence are not counted as per-device features against
>> the 64bit feature space.
>>
>> Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
>> ---
>>   include/uapi/linux/virtio_config.h | 8 ++++++++
>>   1 file changed, 8 insertions(+)
> Pls don't add this in uapi, people tend to depend on this and then
> things fail when we extend virtio. For example this won't work with >64
> feature bits.
Good point. Then keep this macro private to vdpa.c for now?

-Siwei
>
>> diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h
>> index 3c05162..3bdc7ed 100644
>> --- a/include/uapi/linux/virtio_config.h
>> +++ b/include/uapi/linux/virtio_config.h
>> @@ -54,6 +54,14 @@
>>   #define VIRTIO_TRANSPORT_F_START	28
>>   #define VIRTIO_TRANSPORT_F_END		41
>>   
>> +/*
>> + * Bitmask for all per-device features: feature bits VIRTIO_TRANSPORT_F_START
>> + * through VIRTIO_TRANSPORT_F_END are unset, i.e. 0xfffffc000fffffff for
>> + * all 64bit features
>> + */
>> +#define VIRTIO_DEVICE_F_MASK (~0ULL << (VIRTIO_TRANSPORT_F_END + 1) | \
>> +			      ((1ULL << VIRTIO_TRANSPORT_F_START) - 1))
>> +
>>   #ifndef VIRTIO_CONFIG_NO_LEGACY
>>   /* Do we get callbacks when the ring is completely used, even if we've
>>    * suppressed them? */
>> -- 
>> 1.8.3.1