From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
Cc:     davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 02/13] net: Replace all spi->chip_select and
 spi->cs_gpiod references with function call
Date:   Thu, 02 Feb 2023 23:36:33 +0100
In-Reply-To: <20230202152258.512973-3-amit.kumar-mahapatra@amd.com> (Amit
        Kumar Mahapatra's message of "Thu, 2 Feb 2023 20:52:47 +0530")
Message-ID: <dleftjedr7itji.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20230202152258.512973-3-amit.kumar-mahapatra@amd.com>
        <CGME20230202223633eucas1p2d9ec5e0fee227cb5a1bcb81c3c137859@eucas1p2.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2023-02-02 czw 20:52>, when Amit Kumar Mahapatra wrote:
> Supporting multi-cs in spi drivers would require the chip_select & cs_gpi=
od
> members of struct spi_device to be an array. But changing the type of the=
se
> members to array would break the spi driver functionality. To make the
> transition smoother introduced four new APIs to get/set the
> spi->chip_select & spi->cs_gpiod and replaced all spi->chip_select and
> spi->cs_gpiod references with get or set API calls.
> While adding multi-cs support in further patches the chip_select & cs_gpi=
od
> members of the spi_device structure would be converted to arrays & the
> "idx" parameter of the APIs would be used as array index i.e.,
> spi->chip_select[idx] & spi->cs_gpiod[idx] respectively.
>
> Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
> Reviewed-by: Michal Simek <michal.simek@amd.com>
> ---
>  drivers/net/ethernet/adi/adin1110.c            | 2 +-
>  drivers/net/ethernet/asix/ax88796c_main.c      | 2 +-

For ax88796c
Acked-by: Lukasz Stelmach <l.stelmach@samsung.com>

Thanks.

>  drivers/net/ethernet/davicom/dm9051.c          | 2 +-
>  drivers/net/ethernet/qualcomm/qca_debug.c      | 2 +-
>  drivers/net/ieee802154/ca8210.c                | 2 +-
>  drivers/net/wan/slic_ds26522.c                 | 2 +-
>  drivers/net/wireless/marvell/libertas/if_spi.c | 2 +-
>  drivers/net/wireless/silabs/wfx/bus_spi.c      | 2 +-
>  drivers/net/wireless/st/cw1200/cw1200_spi.c    | 2 +-
>  9 files changed, 9 insertions(+), 9 deletions(-)
>

[...]

> --- a/drivers/net/ethernet/asix/ax88796c_main.c
> +++ b/drivers/net/ethernet/asix/ax88796c_main.c
> @@ -1006,7 +1006,7 @@ static int ax88796c_probe(struct spi_device *spi)
>  	ax_local->mdiobus->parent =3D &spi->dev;
>=20=20
>  	snprintf(ax_local->mdiobus->id, MII_BUS_ID_SIZE,
> -		 "ax88796c-%s.%u", dev_name(&spi->dev), spi->chip_select);
> +		 "ax88796c-%s.%u", dev_name(&spi->dev), spi_get_chipselect(spi, 0));
>=20=20
>  	ret =3D devm_mdiobus_register(&spi->dev, ax_local->mdiobus);
>  	if (ret < 0) {

[...]

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAmPcOvEACgkQsK4enJil
gBBFfAf+LyND8/gjCylBNt7dTY3hKO00SkUXx6a05q1IlpefmnqZT0yft7oOQXwl
JP0KaUIeFwoByUpqpp9hzVpNcj+7qTPlpgIuI+t5fpUw2RTD6SZ2rsCiBKmtlN5/
bTORNHHcCTYTH94yWEm66ijd3mgbz9M8X3eWhxirDgsU6zCE0AtXPzDzkRLv5xbX
W4J+MK5Dsd8dvQ5uJ27LyJn0jF1jI6NQtxlno81DYxvhc/DnH7Nx/MFO5Jr2gAZm
zw+jorF8IW4XOHVexTQBWpBvyXzhn6GFlX6SzoRMYa48Gbw2fNeSxHEoaAnhOh4r
yezVLOhcR3ZGuPNzXSPXwnyNbwIpuA==
=Vt06
-----END PGP SIGNATURE-----
--=-=-=--