From:   Mike Christie <michael.christie@oracle.com>
To:     hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org, brauner@kernel.org,
        ebiederm@xmission.com, torvalds@linux-foundation.org,
        konrad.wilk@oracle.com, linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>,
        Christoph Hellwig <hch@lst.de>
Subject: [PATCH v11 3/8] fork: add USER_WORKER flag to not dup/clone files
Date:   Thu,  2 Feb 2023 17:25:12 -0600
Message-Id: <20230202232517.8695-4-michael.christie@oracle.com>
In-Reply-To: <20230202232517.8695-1-michael.christie@oracle.com>
References: <20230202232517.8695-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4hE4RgG/rRhhJ4YrbWLgJV2DwCxrT5INnhKjvHurzMwWkLXZnQVFc/ynbsVx?=
 =?us-ascii?Q?Gfprhc1/qOt8TbwarZrteNgVQgpejS2taA6qbKEtJbLniDJPyKvsCHEveS5B?=
 =?us-ascii?Q?SELy++FP8aEi2xZAKd5Vxl1sENDHVWrr74JCb4/ItuLMNBml4k52Q3dnkG+Z?=
 =?us-ascii?Q?Vp7Fw3E0Kf+/l257VJ/AXX+d1X0mnj3UTcFXgPENPBqCtpDO8k2jVuzPoymb?=
 =?us-ascii?Q?wEr6F5Pq2YX5XSOX/vhU77ruqeboEoPlI034hky8ho8f3ugWJ9elqG3trdeg?=
 =?us-ascii?Q?Ir+U34J5m4m8OQ17R/T8N6X/8WVyzVnqOcVQu9bsZKrrOZjAo6XqFZ3CHx1r?=
 =?us-ascii?Q?pAujCFtVcmPRgTdHeX9OwF5QdZZlSgN2FM1B7HBMnls+wjlLC0Vh7j28WY0p?=
 =?us-ascii?Q?avSo4UQknLPcygzaq/BDp5O52HzYNNDVUqSMMBLhWfjIH1zdz3lHJTxP2Ce5?=
 =?us-ascii?Q?HjfTjczyFL7dHmJL7SprDUne7RAE69EsL8vu6Xq0SQ8SEoi1j/D3dH9qlj/c?=
 =?us-ascii?Q?MtPX7yKjH1kPxYC21eHjXp49aOjBW+IfUhhl4ZCni0zl1Jxgi3rIZKXkjn4t?=
 =?us-ascii?Q?XxYG62AmUyA/xTnFcqvov6iD4anCI1KWl3PyKgUsJGuNsiS+HZuzRnJN3vqd?=
 =?us-ascii?Q?EnOWgHGLfadRC+YtRgtpYGcRef8gKGEhiLmZWstFZLcoRpZ2sr+G5HPnDk/8?=
 =?us-ascii?Q?lDf9mySJC5/XEuEaZRgaIzD/L+ilw+VhilzX74x3bXeNEuHWOEEXlVNplNNf?=
 =?us-ascii?Q?ucTLic5d4sXMmrk/fLdp5MLh0dkEPx123sqKjUJbGMAnMunyw3eXsPIYUZac?=
 =?us-ascii?Q?JvRPry8tJjg6ZozVdGMHR7ch26X8zfnih2WcT8WO8wdnOdxbX/b0xba6lgfD?=
 =?us-ascii?Q?YO/bsvWw7Gsw9g7v6HkKr8tV4JQxRW28o61alBANo4qvA1ct/ZQUjVBC+m0g?=
 =?us-ascii?Q?zNvaVnLuYnnolvyZVG6hZFmupF9NDOxhSwsv2SOnenvi3zL+tMOJukrUa0+s?=
 =?us-ascii?Q?BqtVm0yjYYyzw/IE5n6r4GGcYsAICcMOc6Qzs4P2Av129405xUIIVePHy93p?=
 =?us-ascii?Q?VlnCuBfV46EKOwQSe+ppcpJbBg64zcWDoEsmDYQJsZINCA8IqkTUmB24rfBW?=
 =?us-ascii?Q?al5IKHOhFewoF7nZ6+El/x3GjNthe+0+MSxDuZ9+otrXnXQdgbykBqxUutY1?=
 =?us-ascii?Q?bB6HkiN31k1rs1rBuE/TZEc+dsaFVGGLziSUkWGOeKWWAaunFwP6pXTrwQ5W?=
 =?us-ascii?Q?x+cZtBY0VqMbLbgY6Q8YE4TGaxW5m2EPx7NO0KlKLsUSQsZsUWLkYnn/Cvu1?=
 =?us-ascii?Q?BBs1OpOLNpnhpWdFwQke1hg1XBk/PMGSNCJwZUfcbCDf9WEQKz/05FZyNbJU?=
 =?us-ascii?Q?BWHnvODuEuwZvJoQXw2lMWnnKSt+Brt1NC2QZ08NaQZeJuQoaDkTL9SZ0b7d?=
 =?us-ascii?Q?RF4Kri8JMst6lp7zUh2z9Bnqa+HSgJ+5qqgySpALSszcrKKSIRnkjg5pvEpo?=
 =?us-ascii?Q?7BmbzpB+OofObBZ9erlIhhcBQ8E+NNx3doLVVOURQs5ciOzLIlrQv3yCXygZ?=
 =?us-ascii?Q?1gR4tFfQ1GnSPgqOFQ18TNMA52uTLcwD5RuuY8wPBexxEKH+0BhDJz4lPb+k?=
 =?us-ascii?Q?7A=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?GZ2hvMsBeh5klrRMUxySMBMYcdgsDVwelbLUTb9McunURlPiOC5bAGvyBPWZ?=
 =?us-ascii?Q?cbBvZCRgmmpSpj9KQ6FtCLRh8j97Z0ro+nb8BoYvzgE+F7m0idT7fhypASPI?=
 =?us-ascii?Q?F/0MLG2V21nRR1fH8VBu8Je+T9WLWZV6pzPhH8vWI0QZi92p2W5RSXDVNg00?=
 =?us-ascii?Q?dwI7iHgJFr02Hemc7eujWZWCTbVwNgGZKiTabPDSfA82tb2HBEY1Ea/xoZfr?=
 =?us-ascii?Q?mtQIVefyWwv1iyHq2vhJZhon/+qNkdP5ObVsVf5nDh+NYtuPTmPeNJJDLePO?=
 =?us-ascii?Q?R7uGc/XK81XqGHRbvmk0tA1UVAr2qWGKMj0MnLTfGOocCspbVlZYypholwRz?=
 =?us-ascii?Q?uBvFAfuwllT7TG0HOEsBap2L90QAdDikn7DgqvIDg8BLoBcvdSyZZMauZUVB?=
 =?us-ascii?Q?anDEBmdFfA0cSQ73P5tg4Q4FogUaqZgT6kmR735n9cEWmg7FJcXTEYRY55EE?=
 =?us-ascii?Q?85WedLCzRxp18PU/Rb+ZYWLgqVMICxb20XPkcT4EJSHHlZAJeaX1A3iahLlC?=
 =?us-ascii?Q?4BjnQ/RqYcM1Bzcgii/NtZzwxaX/VXtpcFEi8CARHtyaNvk1ccEoOdWu7wYn?=
 =?us-ascii?Q?R6o4vSVg0sKgZfoQORRzMLut05oEm2uOPNoOEtaukSgenxbvZ7KGJvToi01g?=
 =?us-ascii?Q?uLEH4VQxRasOUarP63aLX+Ko6dE7/BJjV7VNNqp7XVcroQ1VUWQ1dHNuL/Z9?=
 =?us-ascii?Q?JwPU2P5VZ9VZZ64UYMBAHV5f6tuw6AVbhdc4Dgxyd3pXGVvub66t4RjcsYuf?=
 =?us-ascii?Q?QBMy40B3zuKDa4DBUxSQ0+SdGp1UqnFPg2ZOycVhI2sjhRwvtdxBTn29wFXs?=
 =?us-ascii?Q?ObsiWvpSa4LLRRCsAXEuXk9SPNtAKIwinl4Oy/aBDAuEkHbOeHV1bBtc2D06?=
 =?us-ascii?Q?5pEfdqyyd0XP9uPUE8378vwKFDP+mCFf3ifFjS5QjBgzGyx0mQXdjovsdcHA?=
 =?us-ascii?Q?GFP/rnJgMkXtpxtwdC1mnHNX76KBftOMWKPSYuMIANE0K9oJcsVLgghfHS8d?=
 =?us-ascii?Q?HJu9XCyfS/d0waZrMBireedmBDrR3EIuzkdwSnqeFeGmsc8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66a94706-aebd-4179-bf9b-08db0574c451
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 23:25:27.2500
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bSkvBy7SA6bxEOsO+0r/hKqPvpfS90gSUm5k9u3n7PrsmIgMGI0Eyp85E6XdGvmaBZQmgvaKV7BiDiozPSodxaZu08dLqsBBq8ZOkNhcNHA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4536
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-02-02_14,2023-02-02_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=992 adultscore=0
 suspectscore=0 mlxscore=0 spamscore=0 phishscore=0 bulkscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302020207
X-Proofpoint-GUID: M_sWB8op24b0vVimBPAZQmsCnWUG9IFM
X-Proofpoint-ORIG-GUID: M_sWB8op24b0vVimBPAZQmsCnWUG9IFM
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Each vhost device gets a thread that is used to perform IO and management
operations. Instead of a thread that is accessing a device, the thread is
part of the device, so when it creates a thread using a helper based on
copy_process we can't dup or clone the parent's files/FDS because it
would do an extra increment on ourself.

Later, when we do:

Qemu process exits:
        do_exit -> exit_files -> put_files_struct -> close_files

we would leak the device's resources because of that extra refcount
on the fd or file_struct.

This patch adds a no_files option so these worker threads can prevent
taking an extra refcount on themselves.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Christian Brauner <brauner@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/linux/sched/task.h |  1 +
 kernel/fork.c              | 11 +++++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index dfc585e0373c..18e614591c24 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -20,6 +20,7 @@ struct css_set;
 
 #define USER_WORKER		BIT(0)
 #define USER_WORKER_IO		BIT(1)
+#define USER_WORKER_NO_FILES	BIT(2)
 
 struct kernel_clone_args {
 	u64 flags;
diff --git a/kernel/fork.c b/kernel/fork.c
index 77d2c527e917..bb98b48bc35c 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1624,7 +1624,8 @@ static int copy_fs(unsigned long clone_flags, struct task_struct *tsk)
 	return 0;
 }
 
-static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
+static int copy_files(unsigned long clone_flags, struct task_struct *tsk,
+		      int no_files)
 {
 	struct files_struct *oldf, *newf;
 	int error = 0;
@@ -1636,6 +1637,11 @@ static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
 	if (!oldf)
 		goto out;
 
+	if (no_files) {
+		tsk->files = NULL;
+		goto out;
+	}
+
 	if (clone_flags & CLONE_FILES) {
 		atomic_inc(&oldf->count);
 		goto out;
@@ -2255,7 +2261,8 @@ static __latent_entropy struct task_struct *copy_process(
 	retval = copy_semundo(clone_flags, p);
 	if (retval)
 		goto bad_fork_cleanup_security;
-	retval = copy_files(clone_flags, p);
+	retval = copy_files(clone_flags, p,
+			    args->worker_flags & USER_WORKER_NO_FILES);
 	if (retval)
 		goto bad_fork_cleanup_semundo;
 	retval = copy_fs(clone_flags, p);
-- 
2.25.1