From:   Mike Christie <michael.christie@oracle.com>
To:     hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org, brauner@kernel.org,
        ebiederm@xmission.com, torvalds@linux-foundation.org,
        konrad.wilk@oracle.com, linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>,
        Christoph Hellwig <hch@lst.de>
Subject: [PATCH v11 1/8] fork: Make IO worker options flag based
Date:   Thu,  2 Feb 2023 17:25:10 -0600
Message-Id: <20230202232517.8695-2-michael.christie@oracle.com>
In-Reply-To: <20230202232517.8695-1-michael.christie@oracle.com>
References: <20230202232517.8695-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jdNKRCFx1rup9EQvUJaM+q5T4AqSLdqROhfo1HQaRWbaZCy7g+4znfBTXTUY?=
 =?us-ascii?Q?2HGNFKU4g5k67+n+v677mrWjhr+VdG8zPDm1VfW2Kiq8J39EUMLZDk05oEP7?=
 =?us-ascii?Q?N3cQknBps3m+pCAVHQMyQdSi+hoWmQxQcgPtJ0Kq5mXj/NDE/f8G9uWpKnA9?=
 =?us-ascii?Q?YkuVHsm9FVjEHJMYEnWmknDkkyg2EK8RJhVm1TfULBtGurELXPDcQa7DX+A7?=
 =?us-ascii?Q?+dEYFnqmTu/iB41KeMSDZyK109HO/eyGkrRjRmRhhj1uyr7jymJ1xS9cSW1p?=
 =?us-ascii?Q?c+J8sC4S98/Od0/BUtrT35LsBfbVtkthuIjqCyRCPLboNNIorRCChLIARNpA?=
 =?us-ascii?Q?jhkHBQk7NAQF/a5rTDM7iV6/7iQ2w5A30oTNknnEoFbhsm+cFSEPj3sozM0A?=
 =?us-ascii?Q?NXSCTCol8p5dKNaWJcQTiAkl+M2ayA4HhyMTM44ZkOnSNYbUWNmnOhawbQWo?=
 =?us-ascii?Q?b7O7Y8AVt2CPmC0K1hoa/qB5q0kDun44PBsECeYDlvty9A+PKsGTLENX7W1f?=
 =?us-ascii?Q?G5Elc9lcPggHheRSc1Yf4mnPUdeFJZOU/GENUq2NE6MLRav6ygbKKI6WyzU0?=
 =?us-ascii?Q?xQ0DyigY3tTSL1I96BgchJ4mu111S4vm2sYB+yYBLMkXXrx5yqmYBHivvlyR?=
 =?us-ascii?Q?1HhGknQVn+9Z29p0wvDeiYiLbGQeD9ZbBMlyBlQQF5TtlVlaSN8cLUTYe2+a?=
 =?us-ascii?Q?WrwSuedFxCvCJLS/kcsDFkLdSPecCjkNFLlVPgUv+SXDGwYfSs98SkTHHEvH?=
 =?us-ascii?Q?vNVCLSLY5XONc6xqeXhwhydKxNAXKnGHsuhz9rXwJLSEgVk3sZ2rVf+shetP?=
 =?us-ascii?Q?k6ogpO/lgfVJNQzdjouo0b/GPMbVu1sAcWACr1wvV04vabuRfxmGPNwQPOng?=
 =?us-ascii?Q?wBVgFOZ+httZiul9lwa+yH2UE/69USKp904tYBDgvpf7d6ZmVrrmJBFi14wW?=
 =?us-ascii?Q?uMe3aoah0JDcnplecoM/j5k5q25Hd/fGBdvXNrHAIQjUTMOpC5KpM9bh1uHe?=
 =?us-ascii?Q?rlz+12W3eGsB8c7fHH9EzQ+FRT2XYiuUvVVJ2GyigQpc08ZxmG5lzSj6bfYB?=
 =?us-ascii?Q?8wpUkm2Uw8d210BePXNZl8MBw/w0l72BhSU41PRl5vnVAuCzZ5KorjL6/knt?=
 =?us-ascii?Q?bV/RK4hIRsRwHHxQoYzWjz2rIJ/uOIEKsW/c8zHYwvZX12TXRy9bqe9ArOHc?=
 =?us-ascii?Q?BIqsYIbKfiNXnjjNTVOCog4zbwoQaAVWA/wsM2r8PU44EUASU/JLpmiYMtkS?=
 =?us-ascii?Q?ZD0d89+Wmpb2PnJff0EcvBWuZqbQyG1PSy+s1bRiR2g1heiLWJNSHPYpciPa?=
 =?us-ascii?Q?2P/Om4ForOfDXGP7iHO/pyjHAQSEWM0wkMZkbEHfpOwqCbVDCxNNpmGMNxoN?=
 =?us-ascii?Q?0kiWXV+ndyZKT52VM0JT3SE5W+aNuR256MIvQk8TSLJYdi7rnqiks5l/tAiY?=
 =?us-ascii?Q?tP3qsIrWvUCcLJr6UM1KNORTgJkHL4Nf7hymCjgIn+E6iivjkXBU5jv7lq7H?=
 =?us-ascii?Q?Qm0W6/eyRer/sVkpQ48xzN7J7mOiENWSS/safd50InPydHIR25Rnq8N4zqlL?=
 =?us-ascii?Q?9w68ii4Kdk9EvA7g2XgBr2JfL7yEQP3N42tDcI3EUcHW+wQr6+w0C1h2vZWb?=
 =?us-ascii?Q?KQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?Ql7FI7Gu+mbk3Q9tBS7QeyF71ywcwIze9LR2RBOgIvs0e/j5AZ6thcaxtGcl?=
 =?us-ascii?Q?5j4KW+jz/2H2yAR/DshTaojmZdORqjtI5YvDrnDOmKrzLvYWdPM90VI7mQxz?=
 =?us-ascii?Q?9Jk4YcWsy0sIljBMoyVJF7xJqtGTMCX1w+pgBWz4ykRM5duBHVIgcxh38ALN?=
 =?us-ascii?Q?aH24SiQuLiUQ6QLP9L5+aE4acdLHrelYs4GhSZ34//UybOmt6OKuG4hYRxsK?=
 =?us-ascii?Q?Ls959sWK8Rv8OprDFgqxyQ8Ma2Vov4vFsI/qfTfjNSdcrhjW478ilHZRTMR9?=
 =?us-ascii?Q?W6fJkDQm7uWVdGX7j6yXO5NOyEXV5lwyHC+0M9sXt/evfzMY534ec1VTa+ru?=
 =?us-ascii?Q?Q3xjaJmDEsfdvkgfbLLd+0b0bOVKTuSeV0IXRC3lCD0FTp1Va64jYgYaBg5b?=
 =?us-ascii?Q?C3R73yFnhDSjP3K6oFTtj8zgDQ987Q7RcXojMr1VkEcx2+vRYLRaI1r75Ftb?=
 =?us-ascii?Q?iGAj2FG+Pml6H7MErRtvXonyf7HRhlI3+ipBZKOMFt+ZoKn1VaEOuy/HnRV/?=
 =?us-ascii?Q?lnVTI21Bm/U1lVPLaSbzguNsjS72uEi0GwnzYBecHeOT4cxwWCTcTLc9wTq4?=
 =?us-ascii?Q?i9FImaEsNvwLjjA6pxgQVVHPkahIMP5+YyXqURcQFyMr1XPS19DhET6Q1fsU?=
 =?us-ascii?Q?KNNG3A9LAiprDwF8GosOv3UJ7FEyOHfc5F952Y4p3ztRoCQ4GsPlOnMMnCG0?=
 =?us-ascii?Q?nTU8+w+oLdkEKWpRccLdEBVyV5L9Lv1TE2I3ybACzG06dpjDwYaTds1AiEmS?=
 =?us-ascii?Q?9hJVRfjtv7usnWD0kcZ7kL1clb6DtV+Y2d8CGq3NkQhGVKY8v2Xw7/t5G5nl?=
 =?us-ascii?Q?Mvx1J2aaCJ//h1pp/8qyz9u1eEX8IKj0BKOqpFRQdBQMwsQH6VbqzvGaJtHN?=
 =?us-ascii?Q?uZnc/CEH4NsI52kKm6yi0Y5MQV3weDCJttyqlSTPraMO88GkfuNS4WdvH9xb?=
 =?us-ascii?Q?38Pru5CaA7upLbiONtZu3Mh2v6AE0+QZgvdARxGDZZXZDRDQe3EDT1mZa9Un?=
 =?us-ascii?Q?RaqOO3UvIAmr6OSrhZ7Lp6TDW169wpdUaS3FFMjP0ewI3So=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2cee94e-9fa3-4de6-2709-08db0574c1c2
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 23:25:22.9691
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 43zstFgS75PyIT6ypGvOyGZ4g84uddxr8GldfrbRkLl0xEU48n38ZvBlyx2AoHJv/QqFyB3gGe1twBJ81i7lbCOF5jiJPa9IWQWcBjO3gBw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4536
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-02-02_14,2023-02-02_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=797 adultscore=0
 suspectscore=0 mlxscore=0 spamscore=0 phishscore=0 bulkscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302020207
X-Proofpoint-GUID: CufellArNNF9kTfh6LlNPXgt_F5t2lsq
X-Proofpoint-ORIG-GUID: CufellArNNF9kTfh6LlNPXgt_F5t2lsq
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patchset adds a couple new options to kernel_clone_args for the vhost
layer which is going to work like PF_IO_WORKER but will differ enough that
we will need to add several fields to kernel_clone_args. This patch moves
us to a flags based approach for these types of users.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Suggested-by: Christian Brauner <brauner@kernel.org>
Acked-by: Christian Brauner <brauner@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/linux/sched/task.h | 4 +++-
 kernel/fork.c              | 4 ++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index 357e0068497c..a759ce5aa603 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -18,8 +18,11 @@ struct css_set;
 /* All the bits taken by the old clone syscall. */
 #define CLONE_LEGACY_FLAGS 0xffffffffULL
 
+#define USER_WORKER_IO		BIT(0)
+
 struct kernel_clone_args {
 	u64 flags;
+	u32 worker_flags;
 	int __user *pidfd;
 	int __user *child_tid;
 	int __user *parent_tid;
@@ -31,7 +34,6 @@ struct kernel_clone_args {
 	/* Number of elements in *set_tid */
 	size_t set_tid_size;
 	int cgroup;
-	int io_thread;
 	int kthread;
 	int idle;
 	int (*fn)(void *);
diff --git a/kernel/fork.c b/kernel/fork.c
index 9f7fe3541897..b030aefba26c 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -2100,7 +2100,7 @@ static __latent_entropy struct task_struct *copy_process(
 	p->flags &= ~PF_KTHREAD;
 	if (args->kthread)
 		p->flags |= PF_KTHREAD;
-	if (args->io_thread) {
+	if (args->worker_flags & USER_WORKER_IO) {
 		/*
 		 * Mark us an IO worker, and block any signal that isn't
 		 * fatal or STOP
@@ -2623,7 +2623,7 @@ struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node)
 		.exit_signal	= (lower_32_bits(flags) & CSIGNAL),
 		.fn		= fn,
 		.fn_arg		= arg,
-		.io_thread	= 1,
+		.worker_flags	= USER_WORKER_IO,
 	};
 
 	return copy_process(NULL, 0, node, &args);
-- 
2.25.1