From:   Mike Christie <michael.christie@oracle.com>
To:     hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org, brauner@kernel.org,
        ebiederm@xmission.com, torvalds@linux-foundation.org,
        konrad.wilk@oracle.com, linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>
Subject: [PATCH v11 6/8] vhost_task: Allow vhost layer to use copy_process
Date:   Thu,  2 Feb 2023 17:25:15 -0600
Message-Id: <20230202232517.8695-7-michael.christie@oracle.com>
In-Reply-To: <20230202232517.8695-1-michael.christie@oracle.com>
References: <20230202232517.8695-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UlTaSGrfMWfOzYjEyBwOMbznnU+50LVoCrcUbSV77drkBWziMTq1d3+Abot5?=
 =?us-ascii?Q?YZatVNLbWUVomD+DV50EJ+xCS+VWVSSvbRy8mmG9OWRR/FH6FrXg87v9+XnZ?=
 =?us-ascii?Q?wDoWiEYjGKZSPK/A9s3Y2sxXdYAdNoO8xEVzsiXiUoBIzNVlcmTq5oPX5Gbf?=
 =?us-ascii?Q?75LcxUnCARy1zTLkk+bU2ho2p/rUtRweHxcaTdKIQZqUH4Ngp/XUTE5D3GxN?=
 =?us-ascii?Q?6cUWBXDREj3QLH4N2QsgGNJhTGXMGViqPsY8VKWD1pICFPqBD4VJ1xOkKXmi?=
 =?us-ascii?Q?udquokkh+GY2yFja2gOmQBxw7WrVVAcNq5bj5RTbS1KrXzc+OfUdRJcIm3I3?=
 =?us-ascii?Q?bM/AKbFAl1wQQKEVkI3IHiCwHDesrp2YM3ESnU9+PuGWOOT0Oge5c8vyiAFN?=
 =?us-ascii?Q?KGN2yYWmx5tbb1aqBb5B6ConlfvkIfbF7N13nFryly12IzUu/TF1mxceeDwP?=
 =?us-ascii?Q?cU7wsEPp+CsZdrnCMwtNhI5bQCgtDj4BtyWNQ4v2FAM5Ln7ktY3QWJwcJApV?=
 =?us-ascii?Q?4edCBvXOaDA+9DupJOIB2Glm8QIvVs1QL0aiyMHOJLzZsqpuTVWPKow3914k?=
 =?us-ascii?Q?t2wxdrj9asMAH1O0zNxrP+rcCgO4WaQOpNi+Mqzfqxifo8Pip2viVGWAGV3G?=
 =?us-ascii?Q?PKoN70dHgb4eITwsvewmtjxHysj1AXVqUv4rF8OABUEKONWzkSmAJ1C2Utcm?=
 =?us-ascii?Q?n+aizWC7//FjA/U5WSaWD7A7+qd/hXPlKYWruP3KzMpsOteSPEE5AYJJpNmn?=
 =?us-ascii?Q?Vhl9cZM+Cfg26oNQsoR77StASJ/VVorIt4p6wGIS+Ep6Qc0NKUJRzqIIFLtS?=
 =?us-ascii?Q?+RKJ0c5Ml/KJxA3Mr5JhZdsfCuPexgmfSaTBa2kOKE628lly463Yaw9JkBGh?=
 =?us-ascii?Q?YmzcQ3w8RqbBuIoGUB23C1oWGdEVVG+L+tAdi1H5n0CvXgsR1nXBlPSTr9dy?=
 =?us-ascii?Q?fCrPkyVmWrDYrsyHSTfc8EG/V980Jp5D3Qgxu8l+Wz6Fj4NqfDKO0bh+OdDr?=
 =?us-ascii?Q?kGapAw8QYQP7lJXkGuAVFIShSBLcHWG6lI5MZxYv+/W7sQq0PSYa+Mc3MLgK?=
 =?us-ascii?Q?ZuOviAX0qHVdMN28gxQU51L5/XCNNXp0n3ZCh9VjsvGd+zZ7c42pP+LCKP0Q?=
 =?us-ascii?Q?Py+HtdZIV06dnRTiGISx3HQgmeLK4alQtvIPCQaV11W/O+bQegHmQ/Gxk215?=
 =?us-ascii?Q?yGnJEOLJNgw2IYjD8uzczgHy/rz2f45cKhW1KIp30F8HcdCOm5Pg6JNI5gfl?=
 =?us-ascii?Q?AZsET2bzyYs4vy/KlCVnLwuntVefLCiNinfYgRioWUlK/l1koIge9Lu8KOG3?=
 =?us-ascii?Q?b6yG63ooXf3nebwqvW1tYI+i/fnUV0KJ7mAGfB9R5DWTPRbJIYsdeQsw1M2o?=
 =?us-ascii?Q?+mdqK+Ty/AuayA87mtjvWpHYGJ0KpBo1BV1JWqZziZw+s22WnAhMeoxmPYRf?=
 =?us-ascii?Q?MpCg8y1vJuaCujc2Rz2q1FGbzYDvJJOb4ejOj8S6OSh8O/B8cT0x8JlONmdb?=
 =?us-ascii?Q?JVZZ0ulSIAxlpNE+UqLGU5zNCRRBGCqCeb3cgNlinMkKlCjAmdyj4jERWqvz?=
 =?us-ascii?Q?n7dOwXwQmst4QTGKzh8P2YfAu17VO6CJa/AUTRyOn0BVAMYZfQTyZ4DGQLHF?=
 =?us-ascii?Q?tw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?58ECQN04zFkEg4PEkJRDW5Gh4FYhZlliR5d+36L53jTGI+iQ0TaFF6dg6w+0?=
 =?us-ascii?Q?3/Mf3PiucHFmhr3TLwZELjq8MHWxWTHNoT4u+NqtBee5jEZ2RlGBdAhTGnG0?=
 =?us-ascii?Q?NCxsuXwEi2mCRLyZtS2bS4vMlP4cDKAAO/kX2pcyMly8IB8TR7ms0MUKRFRz?=
 =?us-ascii?Q?cDpu3L8q6G356yrKTqczcoF3HIeXeaWW5dwJ0cQ7RJG30c3+4OmdncV9U+TS?=
 =?us-ascii?Q?ax4txCJcmj93WSRIH9O+ebzIW5oUu3AvWrtlunFwgQXNKFvXSDRQyXme1BPX?=
 =?us-ascii?Q?LplZXOyR5sJpAB6kBoBDC+13MKleujVHWb8w0MhUhWfWgbPnrM4NHpl1OHue?=
 =?us-ascii?Q?wj6cXvgLX8RzO1N0090NyYCmO73eAn0te6yTkfXacVAUby/UpUUb68rr5IO1?=
 =?us-ascii?Q?f1CgVYkUgDqL35Xq8vLyD2KGIJuNgCEP0dRZprlic/i+pHZ4HnNl2LSsdJbw?=
 =?us-ascii?Q?NVHOxZ2WEnmszJt321KI1bwQpViPalFCx2/RfX1k2J3wrO14kak70J+50uxb?=
 =?us-ascii?Q?FcILygWpDUIp6qRcBykfsztpuTVo6H6PM2BFZrebTtprbXaY8u1FcBV028KI?=
 =?us-ascii?Q?KNEvAtQU12o9dk1ztUmH3u98ONwNGJPaZCoXP0yTyM0kskYkL5iFHJPaxec6?=
 =?us-ascii?Q?kIH91a4+GDj2oH4sLMGE1N7HgMspZxglhzOiODLk/2uHN7WOPnxrLMqaaJ/S?=
 =?us-ascii?Q?TlwS8b2EFU5czuNxGomsOt9kV26cTs95U73rcq6Wb0/g0R214iWK8tw5cggh?=
 =?us-ascii?Q?c4HAsCooGtfRY+6jU4dr/LRpFuNDTEXqzfiQm1n7kIxAu4Tp7CC7u8CG0KLD?=
 =?us-ascii?Q?WP9qEBOXjbHn4PRg9Ih0USDArfr20offle77a+/q99Qkq1owKjFqhmOuhili?=
 =?us-ascii?Q?1/8MWQ7mH/AMOQCMNkZbpAXKK3wA7VB54dIlOqsBNKm2geXyE0+Hs4LDq7BC?=
 =?us-ascii?Q?w15nbmvBB44VLMRHniXlN5zTWNCKWLIC74CyiVY+bxkYuSIAW8TTkwaDMNYV?=
 =?us-ascii?Q?+H6oci8o4tk8IBGagU2umBEMtg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce46ccdd-b912-46bf-103e-08db0574c7a0
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 23:25:32.8120
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B+Y3FhiRpTK/FcmYNNky6fi5tOOsv0qMKvtiPHD+lh3v2FVFQ+cqfH6T+k6OSclGeIOTNyXfG7qOjosAY2X+WggVN2/yLYbUul882ExMkS8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6643
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-02-02_14,2023-02-02_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0
 suspectscore=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=999
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302020207
X-Proofpoint-ORIG-GUID: OIlJ7ZTPSlTqrpPyao5rFgRqefqZcWIz
X-Proofpoint-GUID: OIlJ7ZTPSlTqrpPyao5rFgRqefqZcWIz
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Qemu will create vhost devices in the kernel which perform network, SCSI,
etc IO and management operations from worker threads created by the
kthread API. Because the kthread API does a copy_process on the kthreadd
thread, the vhost layer has to use kthread_use_mm to access the Qemu
thread's memory and cgroup_attach_task_all to add itself to the Qemu
thread's cgroups, and it bypasses the RLIMIT_NPROC limit which can result
in VMs creating more threads than the admin expected.

This patch adds a new struct vhost_task which can be used instead of
kthreads. They allow the vhost layer to use copy_process and inherit
the userspace process's mm and cgroups, the task is accounted for
under the userspace's nproc count and can be seen in its process tree,
and other features like namespaces work and are inherited by default.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
 MAINTAINERS                      |   2 +
 drivers/vhost/Kconfig            |   5 ++
 include/linux/sched/vhost_task.h |  23 ++++++
 kernel/Makefile                  |   1 +
 kernel/vhost_task.c              | 122 +++++++++++++++++++++++++++++++
 5 files changed, 153 insertions(+)
 create mode 100644 include/linux/sched/vhost_task.h
 create mode 100644 kernel/vhost_task.c

diff --git a/MAINTAINERS b/MAINTAINERS
index 8a5c25c20d00..5f7a3b3af7aa 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -22125,7 +22125,9 @@ L:	virtualization@lists.linux-foundation.org
 L:	netdev@vger.kernel.org
 S:	Maintained
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git
+F:	kernel/vhost_task.c
 F:	drivers/vhost/
+F:	include/linux/sched/vhost_task.h
 F:	include/linux/vhost_iotlb.h
 F:	include/uapi/linux/vhost.h
 
diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig
index 587fbae06182..b455d9ab6f3d 100644
--- a/drivers/vhost/Kconfig
+++ b/drivers/vhost/Kconfig
@@ -13,9 +13,14 @@ config VHOST_RING
 	  This option is selected by any driver which needs to access
 	  the host side of a virtio ring.
 
+config VHOST_TASK
+	bool
+	default n
+
 config VHOST
 	tristate
 	select VHOST_IOTLB
+	select VHOST_TASK
 	help
 	  This option is selected by any driver which needs to access
 	  the core of vhost.
diff --git a/include/linux/sched/vhost_task.h b/include/linux/sched/vhost_task.h
new file mode 100644
index 000000000000..50d02a25d37b
--- /dev/null
+++ b/include/linux/sched/vhost_task.h
@@ -0,0 +1,23 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _LINUX_VHOST_TASK_H
+#define _LINUX_VHOST_TASK_H
+
+#include <linux/completion.h>
+
+struct task_struct;
+
+struct vhost_task {
+	int (*fn)(void *data);
+	void *data;
+	struct completion exited;
+	unsigned long flags;
+	struct task_struct *task;
+};
+
+struct vhost_task *vhost_task_create(int (*fn)(void *), void *arg, int node);
+__printf(2, 3)
+void vhost_task_start(struct vhost_task *vtsk, const char namefmt[], ...);
+void vhost_task_stop(struct vhost_task *vtsk);
+bool vhost_task_should_stop(struct vhost_task *vtsk);
+
+#endif
diff --git a/kernel/Makefile b/kernel/Makefile
index 10ef068f598d..6fc72b3afbde 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -15,6 +15,7 @@ obj-y     = fork.o exec_domain.o panic.o \
 obj-$(CONFIG_USERMODE_DRIVER) += usermode_driver.o
 obj-$(CONFIG_MODULES) += kmod.o
 obj-$(CONFIG_MULTIUSER) += groups.o
+obj-$(CONFIG_VHOST_TASK) += vhost_task.o
 
 ifdef CONFIG_FUNCTION_TRACER
 # Do not trace internal ftrace files
diff --git a/kernel/vhost_task.c b/kernel/vhost_task.c
new file mode 100644
index 000000000000..517dd166bb2b
--- /dev/null
+++ b/kernel/vhost_task.c
@@ -0,0 +1,122 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2021 Oracle Corporation
+ */
+#include <linux/slab.h>
+#include <linux/completion.h>
+#include <linux/sched/task.h>
+#include <linux/sched/vhost_task.h>
+#include <linux/sched/signal.h>
+
+enum vhost_task_flags {
+	VHOST_TASK_FLAGS_STOP,
+};
+
+static int vhost_task_fn(void *data)
+{
+	struct vhost_task *vtsk = data;
+	int ret;
+
+	ret = vtsk->fn(vtsk->data);
+	complete(&vtsk->exited);
+	do_exit(ret);
+}
+
+/**
+ * vhost_task_stop - stop a vhost_task
+ * @vtsk: vhost_task to stop
+ *
+ * Callers must call vhost_task_should_stop and return from their worker
+ * function when it returns true;
+ */
+void vhost_task_stop(struct vhost_task *vtsk)
+{
+	pid_t pid = vtsk->task->pid;
+
+	set_bit(VHOST_TASK_FLAGS_STOP, &vtsk->flags);
+	wake_up_process(vtsk->task);
+	/*
+	 * Make sure vhost_task_fn is no longer accessing the vhost_task before
+	 * freeing it below. If userspace crashed or exited without closing,
+	 * then the vhost_task->task could already be marked dead so
+	 * kernel_wait will return early.
+	 */
+	wait_for_completion(&vtsk->exited);
+	/*
+	 * If we are just closing/removing a device and the parent process is
+	 * not exiting then reap the task.
+	 */
+	kernel_wait4(pid, NULL, __WCLONE, NULL);
+	kfree(vtsk);
+}
+EXPORT_SYMBOL_GPL(vhost_task_stop);
+
+/**
+ * vhost_task_should_stop - should the vhost task return from the work function
+ */
+bool vhost_task_should_stop(struct vhost_task *vtsk)
+{
+	return test_bit(VHOST_TASK_FLAGS_STOP, &vtsk->flags);
+}
+EXPORT_SYMBOL_GPL(vhost_task_should_stop);
+
+/**
+ * vhost_task_create - create a copy of a process to be used by the kernel
+ * @fn: thread stack
+ * @arg: data to be passed to fn
+ * @node: numa node to allocate task from
+ *
+ * This returns a specialized task for use by the vhost layer or NULL on
+ * failure. The returned task is inactive, and the caller must fire it up
+ * through vhost_task_start().
+ */
+struct vhost_task *vhost_task_create(int (*fn)(void *), void *arg, int node)
+{
+	struct kernel_clone_args args = {
+		.flags		= CLONE_FS | CLONE_UNTRACED | CLONE_VM,
+		.exit_signal	= 0,
+		.worker_flags	= USER_WORKER | USER_WORKER_NO_FILES |
+				  USER_WORKER_SIG_IGN,
+		.fn		= vhost_task_fn,
+	};
+	struct vhost_task *vtsk;
+	struct task_struct *tsk;
+
+	vtsk = kzalloc(sizeof(*vtsk), GFP_KERNEL);
+	if (!vtsk)
+		return ERR_PTR(-ENOMEM);
+	init_completion(&vtsk->exited);
+	vtsk->data = arg;
+	vtsk->fn = fn;
+
+	args.fn_arg = vtsk;
+
+	tsk = copy_process(NULL, 0, node, &args);
+	if (IS_ERR(tsk)) {
+		kfree(vtsk);
+		return NULL;
+	}
+
+	vtsk->task = tsk;
+	return vtsk;
+}
+EXPORT_SYMBOL_GPL(vhost_task_create);
+
+/**
+ * vhost_task_start - start a vhost_task created with vhost_task_create
+ * @vtsk: vhost_task to wake up
+ * @namefmt: printf-style format string for the thread name
+ */
+void vhost_task_start(struct vhost_task *vtsk, const char namefmt[], ...)
+{
+	char name[TASK_COMM_LEN];
+	va_list args;
+
+	va_start(args, namefmt);
+	vsnprintf(name, sizeof(name), namefmt, args);
+	set_task_comm(vtsk->task, name);
+	va_end(args);
+
+	wake_up_new_task(vtsk->task);
+}
+EXPORT_SYMBOL_GPL(vhost_task_start);
-- 
2.25.1