Message-ID: <678c5d45-eb91-c000-76d6-7ed9341e52c3@intel.com>
Date:   Thu, 2 Feb 2023 15:47:16 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH v2 07/18] x86/resctrl: Move CLOSID/RMID matching and
 setting to use helpers
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>
References: <20230113175459.14825-1-james.morse@arm.com>
 <20230113175459.14825-8-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230113175459.14825-8-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1pHQ0VjWXJWQjdwZ3FWY2JEWTAySDBZSitOd01DNXZDMWYvZGk3YkNlSzVP?=
 =?utf-8?B?YTNPVTZmZjBwc1lJZG5qWDdFcTZnc1ovcTJWRi9POFBsRWsydFdyR1ZYbEl6?=
 =?utf-8?B?djh6a3dmdkRSdU1rV0VHN1h0cHN2QkUvL1NRSEgxU3RYMStQR2NDRlloVENp?=
 =?utf-8?B?WmM1eTVLRVlRQW43VGJoM3JVV29nU3pNMHRtR0FLaXJXM05wbzIrRTJBMVZH?=
 =?utf-8?B?NlR3RDdpWXVxcXdtZ211Y3RsRm5qVytYS2ZtdEJxcXREVmdMZlpQZGZyMDNM?=
 =?utf-8?B?dU9UT0paTWp3YmtJREx0WWJxaENmM1B0UDdTMXRVT2JkZ1ZpTmE1cFVpa3d3?=
 =?utf-8?B?TW45eUEwQmRLWW9YNmZqZjNYb0ZrUGNnQTlGbENla3dIeUlpbjNkbS80WXJq?=
 =?utf-8?B?U1NLNlRVVjFhTkVOWlFqNU1RajZzaThHOW9tY21ZbjltaUFRaU5nNjVRWmNS?=
 =?utf-8?B?QmJQUm1QSWZselMyNnoyODkwc01qVm0zSzV4YjYzaXdYNHFmTVZWNEd4a0Zs?=
 =?utf-8?B?VXZvWTFKVTRaWDNNZUxQR3hKZGRraVQ3ZDhtM2gyanZKSjErcXo0SGJUeVRP?=
 =?utf-8?B?U09KZDBYUWh3bTFxWDJja0c5TlpETWtDTTd5WWRxa09DN0o1ZlIrUFR1cWdx?=
 =?utf-8?B?djhEeGZjdmNJUkRoK3dxZW8waVpuRUtWWVM1MUlJbnNuMEZGWHNkYzcwbnlt?=
 =?utf-8?B?T3pQV0dONDNCaXh6aUpsQUJiZlRmZTdoaDF0ZXg2WUFuOEY4enI2c3J3dlRL?=
 =?utf-8?B?UDBCcUtMaEZoNk5NM0dneUJNZk9VMTJaWW9TY0o1aDg0RFNlbWhPMG1VWG1t?=
 =?utf-8?B?b0NMbVN2SnFtZkE5dFZVTkoza2lzWE84Vnp0MG5lQUlxd0NKYUozUkQxOUxF?=
 =?utf-8?B?NGZFSzVLeFN1bzhTMTcwVkJiamNhUE9rMUE2WW9vV2VFblk3Y1NBNGd4VDM1?=
 =?utf-8?B?OEhzTFp3RCtBYjluS2dYVzVyL0ExMlEveWhWcEZMWmFPSDRuLytkNmF4ejdo?=
 =?utf-8?B?a21TNmM4ZWhOeWZPZ3I3MWFYRVF6Y2s2cmE3RkZ2QWR1aitKb3VWMmJxbTNS?=
 =?utf-8?B?Yk1uZU16Mkp1Z1Jya1NNMm1PKzJxR21FQnVjRGpsNXlXM0pEMERicG5Ldytz?=
 =?utf-8?B?R21BNVlvNWtsVGZ2QTVmZXFLRWFzN05NczYwZStIRzZVaU8rdG1iYjJJWWZI?=
 =?utf-8?B?MHRyMGhROHU1dDlTcGNiK2lKMVBtOWlrVmJFTUtOU25KcWs5YzlOL3JuYjNV?=
 =?utf-8?B?MjVMc3VxNC80SnkxWENlTFhFYWJMczRJOFNmL0gxSWt4a1NiWHRaR0QxcG81?=
 =?utf-8?B?TVlmMjNISTFoby8xU0dSZ3RpN2lNdHYyN056U1V3U0wwWHh3MWx2UXVHVlk1?=
 =?utf-8?B?MFE1TDRCWXJ6c1QybFRmdkVLOS9Qck9QZUhJN2xsUXp6VUl4YjUwSGtVNnph?=
 =?utf-8?B?NzY5TC9BSEdQY21xMk5mV0gvNnJrYzlzckJvQkNXYURjZlZXMmduZ3pUQVdw?=
 =?utf-8?B?M2U1NVRaZVBnQkRLMzNWQ3J0SnJTa1dQdnU4ekR6czVIYk1EUGMzMHo1bEFt?=
 =?utf-8?B?UzVReC9vL0JmU01DaEE0NVFueEhDOUlVWG9FN0ozUTN2QmRYZC9QV2E1a0Fl?=
 =?utf-8?B?V1NCWXMyVkRUUmwrNHRjY25zdm85S2V5TFlITHFwK1ZCeTdYZk9UREprNnZN?=
 =?utf-8?B?UmVHNklPbGFjTlVoWS9UNzVrdWJ2dmxoMkFwRXRSbDRLK1YxM2hhM2xmR3Y5?=
 =?utf-8?B?QjBVaHBtZG1BT0JiUjFUemNuaU4wUnlETFFic0J6b0lReDIyVk5OUElQVTdB?=
 =?utf-8?B?VW91c3RoK3hiZ1JRWnRubVRrNGtHVkR5NFNSWVNFdnV4UGRxalViMFFhRW13?=
 =?utf-8?B?UmtlRlVHeWovWjFETnJVRW1OMEU0MWpibTF3RnFpdkgyR1lQWFZtYWM5dEZG?=
 =?utf-8?B?K0Fyam5qSW5pN1FtMUFCRkEwYllWV1ViQnN2eGRDSmM5a0hzUmgxM0dvcUxW?=
 =?utf-8?B?MGlXaFRCa0RZdEdkQ2xxZjJ0bnJDQjBKNUZFNDdOaWMrYkZOaGdNN3FTd3Aw?=
 =?utf-8?B?V1lWWEF1OEFYZFEyeGFSK2dWVjZQbTF5RUZmSktaMDh5VVlIaU9iYi9FeE9K?=
 =?utf-8?B?MjR6b1RjMXVlT2FtM1c2dVdkZjBLN3RSMit1b0NlQkJ4VjBsSEkvd01tT1l4?=
 =?utf-8?B?aHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f7c1265d-82df-43ff-5bcc-08db0577d27f
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 23:47:19.6522
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 96t0Cokg3tn6gO4fbIhWAPeOtflA6FkYVqMtjlxcsDr1hwK9x6FcXpdQ0XPbsNgNCq9oot6mgZOwspLBl6T+Rk8bFai5hvz5YnHgFuHhdxs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7295
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

On 1/13/2023 9:54 AM, James Morse wrote:

...

> @@ -567,19 +579,14 @@ static int __rdtgroup_move_task(struct task_struct *tsk,
>  	 * For monitor groups, can move the tasks only from
>  	 * their parent CTRL group.
>  	 */
> -
> -	if (rdtgrp->type == RDTCTRL_GROUP) {
> -		WRITE_ONCE(tsk->closid, rdtgrp->closid);
> -		WRITE_ONCE(tsk->rmid, rdtgrp->mon.rmid);
> -	} else if (rdtgrp->type == RDTMON_GROUP) {
> -		if (rdtgrp->mon.parent->closid == tsk->closid) {
> -			WRITE_ONCE(tsk->rmid, rdtgrp->mon.rmid);
> -		} else {
> -			rdt_last_cmd_puts("Can't move task to different control group\n");
> -			return -EINVAL;
> -		}
> +	if (rdtgrp->type == RDTMON_GROUP &&
> +	    !resctrl_arch_match_closid(tsk, rdtgrp->mon.parent->closid)) {
> +		rdt_last_cmd_puts("Can't move task to different control group\n");
> +		return -EINVAL;
>  	}
>  
> +	resctrl_arch_set_closid_rmid(tsk, rdtgrp->closid, rdtgrp->mon.rmid);

This does not use the intended closid when rdtgrp->type == RDTMON_GROUP.

Reinette