Message-ID: <b8b6cab4-ca7a-6314-7f5a-592440ea3f07@intel.com>
Date:   Thu, 2 Feb 2023 15:48:20 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH v2 13/18] x86/resctrl: Make rdt_enable_key the arch's
 decision to switch
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>
References: <20230113175459.14825-1-james.morse@arm.com>
 <20230113175459.14825-14-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230113175459.14825-14-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWhiU1JXZUhldy9jdGcva0F4KzV2K2JsNlN6dnZhSTl1aXdqRUlYMXZ2cHlK?=
 =?utf-8?B?N2UvQk5ITmFSeVF5dC8wSHpWS01RQndEcTcweU1ueTdUa0RSL2UxRXdndFpU?=
 =?utf-8?B?TVh5UyttVmhyWDdHV2JWNHJ5YlRUd0tKeTBJOG1EY0FVYmMxTXZUaHFJMHEw?=
 =?utf-8?B?ZFZ1enA4bXlvOGQyejZTR29QbkdEam12Y3M2Nm41MC9xRzd6TWxiZjVmTm5j?=
 =?utf-8?B?eE1FSU5neFRLTUE2QXB3N0krbm1EQ1ZMU0tUZi9mVll5VVJyRlN4YTlMNS9B?=
 =?utf-8?B?RW5iUTlvNzNKOStqMHJJdlM1dTlZdDdLSFhING5aVUxHUFlhYXdVUlQ2dmJH?=
 =?utf-8?B?cnhTVTd0RUlSMW9vUUs3QlBOYTNjeWxqYkdkSUNXUzFuUkxJK2VLVWw4ejNl?=
 =?utf-8?B?d1pqYXRoeUQ4OS94dWh0RHN2Y1hCWWRmc21HOS9zVlZJRmh1dlJrdEVkcVpm?=
 =?utf-8?B?Q0dERlFhUFVPalkxNGlYeE9mQVlHNi8xc0s5aE5ocHl5T3hLRkJKK0U1VEM1?=
 =?utf-8?B?Rjh5QlI1SGdxS04wd3IrUzh3QXNwazhGZ0IyeEhvdUpWbWlQYU9La2FZTmk2?=
 =?utf-8?B?WnBjUFFvM0taM0lJN2JlSjZHbk5QcDYwVUtvaUlER1p6TVh4dU4yeUlDa3Rk?=
 =?utf-8?B?RDZzSmdoZDFRVmRGMDJDN3VxNVpIY3lyamhVQUpiVmhkSDNlQjg5azN1Um9G?=
 =?utf-8?B?VzBQbGc4ZVhGUitDOEhxVklVODBBcUdxdEh3N0pqcWthVnp5UjlYUzUwQ2dj?=
 =?utf-8?B?U00zM1ZhNUFlb1B4ZXY1NU9lZ0tIcG5YWWxKeGEvVjR4WlpQK0p4UTl6Q2RY?=
 =?utf-8?B?bzhmdVdnY21KdUFTK3c1V3p3dkl2UDd2alB1STlINzlveDZUYWd3QXpzOGdT?=
 =?utf-8?B?QXpOMG8yME9FR2dWYWlpWm54eU1HYnRNZlVaaGQ1NEF5cEd2YzFCZkZpSFo1?=
 =?utf-8?B?ajVFcGJLTHdhTUtqandkZnFpZk5aMHN6VFZHbTNiQXFURVZHbkJsb2ZjQm1C?=
 =?utf-8?B?d3BtVkllYmNDQWR6NUc3Zm9OczJlNkJkTmxYbUl4VkpzYllVS0djK014RUFZ?=
 =?utf-8?B?SW0wZ2w1UVFHZzltMjhpWGdsZTVtaHpvcHdQWjJEZ2h1WXJmRlVoNStndEt0?=
 =?utf-8?B?MEtseVZFcHhoQmsrMUF0Nkcwc2gyVndqakduN1BlOVhiRFZYejNLTmFUaHRZ?=
 =?utf-8?B?OWFnUTdERUhQNnkzdWlxdWdTK0UwZjNmckNXVXJQSkt0SUJzVUVac0YzeUt1?=
 =?utf-8?B?Q0dtUHNBVzhjeGh0cENJeGVRV2EvVU5HVmhtOWgvc3ZuYnVhU2haNnYzOE5K?=
 =?utf-8?B?ak9pWjY0RFRnMi9LYVBHMlJwbEhCdlpIZGpidDBPQkU2VTVPNzhUL1JjWHRT?=
 =?utf-8?B?L2VUQlhScUZUcXUvRGdVSVFqa2grVG9wQVRhQmh1Vk5XVk13OVlrQjhqczli?=
 =?utf-8?B?RkVucG1US1NlalZ0S2V1Ukg2L2FrSkJqRnFjNnRPdmJ4NGFYVER0c0NlSGlN?=
 =?utf-8?B?ZjZ3Sjd5MTcvV1ZScEtZWDc4aS9EMVpwOVlHdjVRL2hHUXQ0dTh2VVhSd3JB?=
 =?utf-8?B?cTlKMU1WM3FTV0thQU5ScFU2TjlCQUlnUU9OUThrRCtwSmN2eHZUUlBxL016?=
 =?utf-8?B?c2YvZU51Z3ZVRnZESU9XdndGRXdHei9BYUJrTWJYSnhsSEdhVkd0L0JsVzFi?=
 =?utf-8?B?SXVZTGVwRXM0RzdKRXdTekJnc1pJb3oyZ3NGWE5yMzRUaVYzY0RJR0s0SFJU?=
 =?utf-8?B?bDNORmk3WU1VK0Ewd3RWOFFjNEpNOGhFVm41dlVmL0RycHUxUi9tbmlJYWhY?=
 =?utf-8?B?U3FwbGJQQ0I5ZzlYdDA1K1RxeWplN2xpMVJEYkt6ZUF4cHd6cnVyTWwvZldY?=
 =?utf-8?B?VDZDUk9TT3I1dWtrNkpROG9xbnNrK3VTa2ptYmY4OTRDaXVjMmJVc2ZKN3Mz?=
 =?utf-8?B?emFqeitCb29YbnBLYzVpOTF0emlSaVFHRThKTHdlWnU5MkdQVHNadDVvYlZZ?=
 =?utf-8?B?NnRUaTZtRWZ1WEl0ZVBSelByT04vUWREK2t2L2RoNE9rSDRsVnVxOVZLaFVj?=
 =?utf-8?B?Y09aRFhMWUx6YW1GamhUVUkzR3N2bmQ0MlVvbHc2bHgyMkhvUkVQc083cTND?=
 =?utf-8?B?RzJMV29DdkFhYW9LTGlGci9JdHhpY0ZLSitVVDhvSVpXZFJiSlNlNVpQOEEz?=
 =?utf-8?B?V0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 204adaab-336d-4738-e67e-08db0577f905
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 23:48:24.2405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DmjHj6NwrMDt7FNunN5pM6eb2JQ7IMVpyIdliveHhtVS46VsjcKrqOExPBbiJ1uIwvxdNC+ak2OyEvf5fGXYNQuu1ee/8poXJShlWiXzPbg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7295
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

On 1/13/2023 9:54 AM, James Morse wrote:
> rdt_enable_key is switched when resctrl is mounted. It was also previously
> used to prevent a second mount of the filesystem.
> 
> Any other architecture that wants to support resctrl has to provide
> identical static keys.
> 
> Now that we have helpers for enablign and disabling the alloc/mon keys,

Please remove all usage of "we" in changelog and code comments.

enablign -> enabling

Reinette