MIME-Version: 1.0
References: <20230202104452.299048-1-krzysztof.kozlowski@linaro.org>
 <20230202104452.299048-3-krzysztof.kozlowski@linaro.org> <20230203000130.GA2934311-robh@kernel.org>
In-Reply-To: <20230203000130.GA2934311-robh@kernel.org>
From:   Rob Herring <robh@kernel.org>
Date:   Thu, 2 Feb 2023 18:03:48 -0600
Message-ID: <CAL_JsqKnsDJVD-PJNg39=Awdw2XNeUV5b3VgZt3zKCsHzp74bw@mail.gmail.com>
Subject: Re: [PATCH v2 02/10] dt-bindings: pinctrl: qcom,msm8909: correct GPIO
 name pattern and example
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Stephan Gerhold <stephan@gerhold.net>,
        Vinod Koul <vkoul@kernel.org>,
        Vladimir Lypak <vladimir.lypak@gmail.com>,
        Luca Weiss <luca@z3ntu.xyz>, Iskren Chernev <me@iskren.info>,
        linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Feb 2, 2023 at 6:01 PM Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Feb 02, 2023 at 11:44:44AM +0100, Krzysztof Kozlowski wrote:
> > The MSM8909 TLMM pin controller has GPIOs 0-112, so narrow the pattern
> > and gpio-ranges in the example.
> >
> > Fixes: c249ec7ba1b1 ("dt-bindings: pinctrl: Add DT schema for qcom,msm8909-tlmm")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
> > ---
> >  .../devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml        | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> > index 449e6e34be61..85082adc1811 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> > @@ -63,7 +63,7 @@ $defs:
> >            subnode.
> >          items:
> >            oneOf:
> > -            - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-7])$"
> > +            - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$"
> >              - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd,
> >                        sdc2_data, qdsd_clk, qdsd_cmd, qdsd_data0, qdsd_data1,
> >                        qdsd_data2, qdsd_data3 ]
> > @@ -127,7 +127,7 @@ examples:
> >          interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> >          gpio-controller;
> >          #gpio-cells = <2>;
> > -        gpio-ranges = <&tlmm 0 0 117>;
> > +        gpio-ranges = <&tlmm 0 0 113>;
>
> I thought 112 was the max?

That's the count, duh.

Acked-by: Rob Herring <robh@kernel.org>