Date:   Fri, 3 Feb 2023 08:58:23 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Yury Norov <yury.norov@gmail.com>
CC:     <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Barry Song <baohua@kernel.org>,
        Ben Segall <bsegall@google.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Gal Pressman <gal@nvidia.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Haniel Bristot de Oliveira <bristot@redhat.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Ingo Molnar <mingo@redhat.com>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Leon Romanovsky <leonro@nvidia.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Mel Gorman <mgorman@suse.de>,
        Peter Lafreniere <peter@n8pjl.ca>,
        Peter Zijlstra <peterz@infradead.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Tariq Toukan <tariqt@nvidia.com>,
        Tariq Toukan <ttoukan.linux@gmail.com>,
        Tony Luck <tony.luck@intel.com>,
        Valentin Schneider <vschneid@redhat.com>,
        "Vincent Guittot" <vincent.guittot@linaro.org>,
        <linux-crypto@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH 3/9] sched: add sched_numa_find_nth_cpu()
Message-ID: <Y9xcL56hw7nSxiyc@chenyu5-mobl1>
References: <20230121042436.2661843-1-yury.norov@gmail.com>
 <20230121042436.2661843-4-yury.norov@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230121042436.2661843-4-yury.norov@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0IBGDtvt6RUbVvEi3FIvgci7uHB9VUX2oqS0hvzanRnuJONKlJGqdGbvK0sB?=
 =?us-ascii?Q?AflhU+WXJXHGB3VVgZN2dvYjJfv1zQDUc/z8/IFxHm2BtZa+pnPaRmiymEEZ?=
 =?us-ascii?Q?nbmBWibUyDcac2+Z7WXqQHs7Vv950qWra1vTWcbq6i1deqUA0z71REJj8SVd?=
 =?us-ascii?Q?GFE+dy33JCfhTAweWatIxk+v+3ND/mYscxNsTAze1Z4Yj5wtlhqSv8GXIUPR?=
 =?us-ascii?Q?qaMqMZb+LoKn99QLovApktR2eOjaVnKrlckrLSK+6xVw+3kK/0w0FqGwm9BL?=
 =?us-ascii?Q?OjChPTkqludJ6Ftsvs/vwKM8NnwM8TO278QN8JvfKocIYEvgJdiaxYKBJibD?=
 =?us-ascii?Q?RPmInZrQdmqPcJYDCL/k2acrvbZ2PjGx39kxcSivbKbrqrM6zeE2dkX+sXmo?=
 =?us-ascii?Q?h+SVSuHSkANf8K1sE2VMKB6IPPZuA8PGRgtU04QzAkeSm9SfmJpHQZPO9415?=
 =?us-ascii?Q?YfLmwTE1eZz3lWfjdEZEv6EeIhL/IyRl3G2F0C8x6XLWcmtCPzMQO2izVF/q?=
 =?us-ascii?Q?ESDOfB+rOBLLPH1HgrQgBYUnXro0jCBS/gekvqhCdYJzU/XuC3g38YHnRnlL?=
 =?us-ascii?Q?wbmFxjD1CKPNqQtZZCgk8M5a4DJh0Rx014WIaIod7GWppHn5T2PaVHa4GJ0R?=
 =?us-ascii?Q?8iI6/oOidZt/G2I4R5Qko4jreXQNQv3GqTELEqdbpL6PLENq6YTOWXZnrKxy?=
 =?us-ascii?Q?Yu8iUjSPAemfEvpT7VRuCb74aGLXfQIAEiqcNEdLhegWlCxKURM/tpXj8LIV?=
 =?us-ascii?Q?8OvLEnfEcbNECD7vXMxdsKhBKwG+mn6qWthdwGJcmzxHDpCRaQkDX5AQMJZH?=
 =?us-ascii?Q?CEtPlZ8EDx8zuiIbwrA/01m6M6eVPYdbEMhDVm719f0hB2S2Aki23scYxCkL?=
 =?us-ascii?Q?0KJDl+/qTGzGN0aaTYIBCnurGRUVdzoqkvK1FCrekz+Y0XFOdP+rhSUjpYzP?=
 =?us-ascii?Q?Jfxv9suFvnqzbBq+XYdmO6N4UFvB45OUVMtpvEQHOj7+VfDNfZ/hU580/Z+X?=
 =?us-ascii?Q?r2j9j9n7/oppFwVY3yokAq+cDxY9rDDg17rYkv2iksHp2zelIXoqbJBe8ZjA?=
 =?us-ascii?Q?YzWBtV91BvcWcP4wwm6myggSCE2bgci6rmMrm3171vcJBJNpe/NjvjbPtnYw?=
 =?us-ascii?Q?URE7fQsJtKHk4OcYOkjHGgZNvsjI/VSjn2japC9LOU7+0Iy2vcR7T7sI944G?=
 =?us-ascii?Q?MRBNMCruWTuzoQaUDwfH3kJCI9s76pAoi1PMshwqr0d6cTz7TK0fYHsBjut3?=
 =?us-ascii?Q?c+jRxyKMAj1PDsZGoqR4dQd9lG0sB55Ddv7rQM3KINY3GBMdK1gVFr40u8uh?=
 =?us-ascii?Q?+xkitBRxfDG4dZH7n4SiTOzWzl81n2I1Xu1h9Gfs5M/Rf7PsGvhwgVbgnCJA?=
 =?us-ascii?Q?2OTsBmkI9OETd4jNbk4AdA5XglpgDLiZAW7R1qVMEvrz13hRqCU5R1wPiWA5?=
 =?us-ascii?Q?mtPqdJe4x1MxC3/PeCiGIQdA0uNC5TB+21F9xzKs5gvmeHOqedG5SjWuY72a?=
 =?us-ascii?Q?qbww7PXIlM8Tmr1P9OeGVnYT0jqTGOr/CS+KkVVms5Svcs8b6RxQgMSYFdHp?=
 =?us-ascii?Q?VjprcLr/Je9Yml3QIjqpEstfinoL6WucNTP+2amq?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 608a4050-6233-42fd-5ebd-08db0581d0cd
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2023 00:58:51.7284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f22s6EC8C36/8/79BwRDQ1nsHqYYDnI39bT/wdDtCbvnJIbJxOhf9nBhIZWfvKxbprY7YJKB0S3N+5N3oBW5/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7773
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023-01-20 at 20:24:30 -0800, Yury Norov wrote:
> The function finds Nth set CPU in a given cpumask starting from a given
> node.
> 
> Leveraging the fact that each hop in sched_domains_numa_masks includes the
> same or greater number of CPUs than the previous one, we can use binary
> search on hops instead of linear walk, which makes the overall complexity
> of O(log n) in terms of number of cpumask_weight() calls.
> 
> Signed-off-by: Yury Norov <yury.norov@gmail.com>
> Acked-by: Tariq Toukan <tariqt@nvidia.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Reviewed-by: Peter Lafreniere <peter@n8pjl.ca>
> ---
>  include/linux/topology.h |  8 ++++++
>  kernel/sched/topology.c  | 57 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 65 insertions(+)
>
[snip] 
> + * sched_numa_find_nth_cpu() - given the NUMA topology, find the Nth next cpu
> + *                             closest to @cpu from @cpumask.
Just minor question, the @cpu below is used as the index, right? What does "close to @cpu"
mean above?
> + * cpumask: cpumask to find a cpu from
> + * cpu: Nth cpu to find
Maybe also add description for @node?

thanks,
Chenyu