MIME-Version: 1.0
References: <20230203022759.576832-1-zyytlz.wz@163.com> <CAJedcCzNB+1byPEzEgQ6ELjeoRQcZ=GnZg+1J4+FZvfnoK0H2Q@mail.gmail.com>
 <1A4D30F2-5FCB-4498-9571-12B320F4E1A1@suse.de>
In-Reply-To: <1A4D30F2-5FCB-4498-9571-12B320F4E1A1@suse.de>
From:   Zheng Hacker <hackerzheng666@gmail.com>
Date:   Fri, 3 Feb 2023 10:47:55 +0800
Message-ID: <CAJedcCxQdqqmKqN9a8-oiot8FKocGNaaCub0r+aE4ndj24L0Yw@mail.gmail.com>
Subject: Re: [PATCH] bcache: Remove some unnecessary NULL point check for the
 return value of __bch_btree_node_alloc-related pointer
To:     Coly Li <colyli@suse.de>
Cc:     Zheng Wang <zyytlz.wz@163.com>, stable@vger.kernel.org,
        Kent Overstreet <kent.overstreet@gmail.com>,
        linux-bcache@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        alex000young@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Coly Li <colyli@suse.de> =E4=BA=8E2023=E5=B9=B42=E6=9C=883=E6=97=A5=E5=91=
=A8=E4=BA=94 10:46=E5=86=99=E9=81=93=EF=BC=9A
>
>
>
> > 2023=E5=B9=B42=E6=9C=883=E6=97=A5 10:43=EF=BC=8CZheng Hacker <hackerzhe=
ng666@gmail.com> =E5=86=99=E9=81=93=EF=BC=9A
> >
> > Hello,
> >
> > After writing the patch, I found there may be more places to replace
> > IS_ERR_OR_NULL to IS_ERR.
> > If the alloc of node will never be NULL, the additional NULL check of
> > nodes after allocation may also
> > be useless. This patch just fixes the check around the alloc. I'm not
> > sure about other places for my
> > limited understanding of the code in bcache.
>
> This was why I suggested you to post an extra cleanup patch like this.
>
> You may just add more changes as you mentioned into this patch and post a=
nother updated version.
>

Get it. Will do right now.

Thanks,
Zheng Wang