From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        Dhananjay Phadke <dphadke@linux.microsoft.com>
CC:     Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
        "David S . Miller" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 -next] crypto: aspeed: fix type warnings
Thread-Topic: [PATCH v2 -next] crypto: aspeed: fix type warnings
Thread-Index: AQHZNtSCfrVHr/nxikWgl/rP0lzNB668chqAgAAEc4CAABk4oA==
Date:   Fri, 3 Feb 2023 03:25:24 +0000
Message-ID: <SG2PR06MB32070328ACE15F44F32BCD3580D79@SG2PR06MB3207.apcprd06.prod.outlook.com>
References: <20230202070345.191514-1-neal_liu@aspeedtech.com>
 <e2dd4a02-12cb-de5e-4b64-9d6a4a1ad316@linux.microsoft.com>
 <Y9xowUpO+Y7M0hho@gondor.apana.org.au>
In-Reply-To: <Y9xowUpO+Y7M0hho@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SjtEiFvYok46UZXVGIsp4Kl+qC8ZzxfG2jDtvDfIEM3LuwH2UwCamwR2kxuK?=
 =?us-ascii?Q?+4dX4E4RN4t+RM47DH8b/r0TWosdXW/B1g9ntvUSrpOB7x7MEIY1+Ywsuw76?=
 =?us-ascii?Q?V9TlUPYXSDMLI4P+yUbxs5l3XTVxXOHryyFKuPx4S+Tbvm2PK8z4sBeiA97b?=
 =?us-ascii?Q?0iorvZGrwcJ0vveUnp2jAK5xz/gGuK9to/U9VXNwbHpdhZcpFCxa/i86lJqH?=
 =?us-ascii?Q?S5NzCS7nHdHKCi6eC+n9JIokP03Wegls8XsW5a5NYvMxHmvKi/6MbZQfgEQR?=
 =?us-ascii?Q?VHhLsRLRs2kGEDo3B+1x7vV6WBLYiMkwAh37wPZb0ypBAIumEb+mn1ymBys5?=
 =?us-ascii?Q?00nLdsQSwNWN1ZbSUi+e7X9cJcdjfuVgRQDuHs8VUfOAV6lFvtZn+QEE7MHu?=
 =?us-ascii?Q?n5WXlJ+KmPrRi+TqvU76TyOjBz/tijV2Kd+i+ZH4hvuC08Mffwb2kS5+q+V3?=
 =?us-ascii?Q?C/5JtJydxIaxbhRqOA0d+VlLUR0HWA+sEvSFvA0mcymfdC/JWWRteDzFAyRD?=
 =?us-ascii?Q?Kfpw46zEdcfaMqFVypvF4cP1RsHVKqjzmgTsYMCDiieeFwXv9pt2l4ptR3eT?=
 =?us-ascii?Q?+2S6GAxSnkV5JGpSABdgab4oNbr5QbcEmBtywrZaXnGHJ1K+4EYSD0+L8IjI?=
 =?us-ascii?Q?MTc3AE9Updvz6ul/F8z/C9iYbsSbfK8OfYcILYqTr6EtySNaAg7/RLD1IVqX?=
 =?us-ascii?Q?jMQTdZ5mUUmz9zFIFTLp6pQTp8hC1qZsifgRrjH5o0FLAZmzh2dCzCzXqVYP?=
 =?us-ascii?Q?C0wQ4g0jbgKkzcbwpMQ23m+fDCDZ362CqeviB0bWduX/AeR7rEB3CNEh3uPi?=
 =?us-ascii?Q?RL6KVNdcn1ygphxJvw6a+/8hnBBYf3ANOtXRtpdQO4RJMOzkjS9nHtzC3Eog?=
 =?us-ascii?Q?ugeo2KINLwTJB03w29bzbHTPM0t/CnIIIjXEnePDlzXVM0Ik8bQB1uN66hw2?=
 =?us-ascii?Q?sQ3xjaKh8onlBlqYVyCEQxAK/vqprNT8TdDCFwbxzLXhiamf4+U40PAaiU3A?=
 =?us-ascii?Q?S9yNFuQ6/d4h1ujWWxiMXwYbTdHX3WFygpXwrjCfb89FBN6U0bXLt3BqmAZ2?=
 =?us-ascii?Q?FoVTxyvcqMb8yRQu0PccawquO8CbUMe0VUvKnKtuIuWC+U5WHqSQ7heLuQ3o?=
 =?us-ascii?Q?vLUFqYMPdxzmtLKnSC7C9QSm0ogUSn10yU/zv21gHP5vAu3btzGQK6Fl3Do9?=
 =?us-ascii?Q?ZbeT0BswgYud/nk6hxiEC8P+4nLwAs9JSi/7rDrt7hNMF0F7HfzXAuTSACj0?=
 =?us-ascii?Q?zUZqEe8sp4F46/TOCEYaNW6Hq4bBxM3Q1NiY2y5cBizcwbGU7k3MNRhouwFP?=
 =?us-ascii?Q?iUctw820qInYxf7gbt0DK8rWsqheZnDTskX0LSrJR4+2pWsp7GyyhIlJ8hdD?=
 =?us-ascii?Q?s30tOw2dd9qdFG81h8KKUu/+Pgx3i7tykP0EHEoBvvSZswn1QXmABviI9ORg?=
 =?us-ascii?Q?Z5rNtLw2OdV6KxFGO0Q6FQyyNJQUcZMyQzrFAkPTzlQpLoAwD1isBQfMqyKp?=
 =?us-ascii?Q?V5CGifJeTT0PtBbe7LFBA0awneEuXrNviC57aG+iHDkRxEKQoGJrsjwOSrnG?=
 =?us-ascii?Q?MMDSp4CRwUrUgzyuw0Hc/QE+EkL31L9z+R8vDQkF?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3207.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c11c09a-0874-4c35-3d39-08db059649d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2023 03:25:24.4820
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EVUbBEFt2YyhYylldIHCLE+Tgr3Rp4pW5d2LWgQ0c+9sN9x5PVKNxA3Layx8ZpcRugLERWif+FVaWBCrG+nshw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5671
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > > diff --git a/drivers/crypto/aspeed/aspeed-acry.c
> > > b/drivers/crypto/aspeed/aspeed-acry.c
> > > index 164c524015f0..f2429e699d14 100644
> > > --- a/drivers/crypto/aspeed/aspeed-acry.c
> > > +++ b/drivers/crypto/aspeed/aspeed-acry.c
> > > @@ -252,7 +252,7 @@ static int aspeed_acry_rsa_ctx_copy(struct
> aspeed_acry_dev *acry_dev, void *buf,
> > >   				    enum aspeed_rsa_key_mode mode)
> > >   {
> > >   	const u8 *src =3D xbuf;
> > > -	u32 *dw_buf =3D (u32 *)buf;
> > > +	__le32 *dw_buf =3D (__le32 *)buf;
> >
> > All callers are passing acry_dev->buf_addr as buf, can just change
> > that type to __le32 * and deref here directly?
>=20
> As buf is already void *, the cast can simply be removed.

I'll just remove the cast. Thanks for your suggestion.

> >
> > >   	int nbits, ndw;
> > >   	int i, j, idx;
> > >   	u32 data =3D 0;
> > > @@ -302,7 +302,7 @@ static int aspeed_acry_rsa_ctx_copy(struct
> aspeed_acry_dev *acry_dev, void *buf,
> > >   static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_de=
v)
> > >   {
> > >   	struct akcipher_request *req =3D acry_dev->req;
> > > -	u8 *sram_buffer =3D (u8 *)acry_dev->acry_sram;
> > > +	u8 __iomem *sram_buffer =3D (u8 __iomem *)acry_dev->acry_sram;
> >
> > u8 cast seems unnecessary, readb takes (void *) and using "+ data_idx"
> > offset below anyway.
>=20
> Either way a cast is unnecessary as (void __iomem *) converts to
> (u8 __iomem *) just fine.

I'll just remove the cast too.

-Neal