Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A3D4C636CC for ; Fri, 3 Feb 2023 05:49:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232055AbjBCFto (ORCPT ); Fri, 3 Feb 2023 00:49:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231245AbjBCFtm (ORCPT ); Fri, 3 Feb 2023 00:49:42 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A83F885D4; Thu, 2 Feb 2023 21:49:28 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 2931068C4E; Fri, 3 Feb 2023 06:49:25 +0100 (CET) Date: Fri, 3 Feb 2023 06:49:24 +0100 From: Christoph Hellwig To: Dave Chinner Cc: Marcelo Tosatti , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Alexander Viro , Matthew Wilcox , Christoph Hellwig , Jens Axboe , Frederic Weisbecker , Leonardo Bras , Yair Podemsky , P J P Subject: Re: [PATCH v3] fs/buffer.c: update per-CPU bh_lru cache via RCU Message-ID: <20230203054924.GA22730@lst.de> References: <20230202223653.GF937597@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202223653.GF937597@dread.disaster.area> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 03, 2023 at 09:36:53AM +1100, Dave Chinner wrote: > Rather than adding more complexity to the legacy bufferhead code, > wouldn't it be better to switch the block device mapping to use > iomap+folios and get rid of the use of bufferheads altogether? It's not that simple unfortunately :( All file systems that use buffer heads also use them on the block device for metadata. I have a WIP block device iomap conversion, but it still has to offer buffer_heads similar to the legacy path in iomap to make all that work.