Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD0FEC636CC for ; Fri, 3 Feb 2023 06:07:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231261AbjBCGHt (ORCPT ); Fri, 3 Feb 2023 01:07:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230504AbjBCGHq (ORCPT ); Fri, 3 Feb 2023 01:07:46 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F2D6709B4 for ; Thu, 2 Feb 2023 22:07:45 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id cr11so2844030pfb.1 for ; Thu, 02 Feb 2023 22:07:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eeDs8HDvvAhEGfhdUR1XjfNZXXjxNqlsBQOOR5XCK4M=; b=tVZ6NeDxk/W+lNCZyWJ9IwYjDBeP11WFEJi09dOY6iE4X5Ff2R2dSZpmjhh5VhplrV XOGyDkqmLqPQr8ngKfHUJt7LMYdhghQ7HFtwaOiOIqmKuhVv/J6tYf9w0tpUkbL/bZlm nTQj1ZPAZ8hXV9IpjEibn9RdgRW0T5j6EHTacs6qYg03B2MagqMzV6hI1fq4x02G3/7b T5sDsqwKYnBP+tDz4GkQsP4fJUYEMt1FBuR4sUiJ53/HLlVc9chWMaT0ejd8QRi7gvNS b8Z6+8C3wp28xXNkJSAHruP5/0Je6Ox2nE1+IGILfkoGFQwaZMRaLdKXZREcJ4Jpso0I 3sUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eeDs8HDvvAhEGfhdUR1XjfNZXXjxNqlsBQOOR5XCK4M=; b=LoMZe6cJf7nQlmGcMeh0LmYQsF4lJ0x3r+Pm5V8VT76IxhiINJ7rITg4YkbFmcYYuv XGbwYFfLjj9LUfnnbjuQb7/KCfg4vlLW/a93RqtJl6ppqQMEmdsApMifmCC72kG+skLM yZCSl8VZZF9YAcyi1/x80JBFgnUBwSmLAWeXbzheIqIRhg+Vn0pJvpPcP9a3NZ0U4dG6 Li0nnSy0iMqAJzKTKpxo3JMqIwro55uaku7wGFUwY42fBvByyUGUgtNZvKGgrVhhWrX8 ya9fOL0AWOsxPHSOBZdZJSHB8Vl04V8yIuJQVjYGM/lC9bTfmHGhf0hS9zoZl9VJEA1N Mgww== X-Gm-Message-State: AO0yUKUM9dRIrZEge2t0F7NuLB5g7EtFSWZP6SeS973nZL9whCzkL4gy rs980Z1U18WjhmP327BSlagk47hUMc1JANaLsvOkGw== X-Google-Smtp-Source: AK7set/p/WShA1xHjrVygScWQh0RWoSwu/3Y2FJcA3yi0yR9YqseOEw+tIN5ANw1DiIcVpMTldQPwJ9ijNbmDGlsYNs= X-Received: by 2002:a62:1a57:0:b0:593:bac2:b49 with SMTP id a84-20020a621a57000000b00593bac20b49mr2250496pfa.44.1675404463277; Thu, 02 Feb 2023 22:07:43 -0800 (PST) MIME-Version: 1.0 References: <20230127001141.407071-1-saravanak@google.com> <20230130085542.38546-1-naresh.kamboju@linaro.org> <20230131101813.goaoy32qvrowvyyb@bogus> In-Reply-To: From: Saravana Kannan Date: Thu, 2 Feb 2023 22:07:06 -0800 Message-ID: Subject: Re: [PATCH v2 00/11] fw_devlink improvements To: Maxim Kiselev Cc: Sudeep Holla , Naresh Kamboju , abel.vesa@linaro.org, alexander.stein@ew.tq-group.com, andriy.shevchenko@linux.intel.com, brgl@bgdev.pl, colin.foster@in-advantage.com, cristian.marussi@arm.com, devicetree@vger.kernel.org, dianders@chromium.org, djrscally@gmail.com, dmitry.baryshkov@linaro.org, festevam@gmail.com, fido_max@inbox.ru, frowand.list@gmail.com, geert+renesas@glider.be, geert@linux-m68k.org, gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com, jpb@kernel.org, jstultz@google.com, kernel-team@android.com, kernel@pengutronix.de, lenb@kernel.org, linus.walleij@linaro.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux@roeck-us.net, lkft@linaro.org, luca.weiss@fairphone.com, magnus.damm@gmail.com, martin.kepplinger@puri.sm, maz@kernel.org, miquel.raynal@bootlin.com, rafael@kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de, sakari.ailus@linux.intel.com, shawnguo@kernel.org, tglx@linutronix.de, tony@atomide.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 2, 2023 at 9:36 AM Maxim Kiselev wrote: > > Hi Saravana, > > > Can you try the patch at the end of this email under these > > configurations and tell me which ones fail vs pass? I don't need logs > > I did these tests and here is the results: Did you hand edit the In-Reply-To: in the header? Because in the thread you are reply to the wrong email, but the context in your email seems to be from the right email. For example, see how your reply isn't under the email you are replying to in this thread overview: https://lore.kernel.org/lkml/20230127001141.407071-1-saravanak@google.com/#r > 1. On top of this series - Not works > 2. Without this series - Works > 3. On top of the series with the fwnode_dev_initialized() deleted - Not works > 4. Without this series, with the fwnode_dev_initialized() deleted - Works > > So your nvmem/core.c patch helps only when it is applied without the series. > But despite the fact that this helps to avoid getting stuck at probing > my ethernet device, there is still regression. > > When the ethernet module is loaded it takes a lot of time to drop dependency > from the nvmem-cell with mac address. > > Please look at the kernel logs below. The kernel logs below really aren't that useful for me in their current state. See more below. ---8<---- --->8---- > P.S. Your nvmem patch definitely helps to avoid a device probe stuck > but look like it is not best way to solve a problem which we discussed > in the MTD thread. > > P.P.S. Also I don't know why your nvmem-cell patch doesn't help when it was > applied on top of this series. Maybe I missed something. Yeah, I'm not too sure if the test was done correctly. You also didn't answer my question about the dts from my earlier email. https://lore.kernel.org/lkml/CAGETcx8FpmbaRm2CCwqt3BRBpgbogwP5gNB+iA5OEtuxWVTNLA@mail.gmail.com/#t So, can you please retest config 1 with all pr_debug and dev_dbg in drivers/core/base.c changed to the _info variants? And then share the kernel log from the beginning of boot? Maybe attach it to the email so it doesn't get word wrapped by your email client. And please point me to the .dts that corresponds to your board. Without that, I can't debug much. Thanks, Saravana