Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60951C636D7 for ; Fri, 3 Feb 2023 06:11:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232088AbjBCGLn (ORCPT ); Fri, 3 Feb 2023 01:11:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230384AbjBCGLh (ORCPT ); Fri, 3 Feb 2023 01:11:37 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFF1373765; Thu, 2 Feb 2023 22:10:59 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id pj3so4091080pjb.1; Thu, 02 Feb 2023 22:10:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=PasdPm0ruMjHHc/jYxUTTUFHsqQQeYT3E3v9depPqSY=; b=DeACYSWRHZY/AFaLkDELrVwTfnkYEIXW9gUX9VEH2WyEQpuQjadz5JmoUE2PKOgQby rlcp5jKrLmiq2EwWgKMrIQdd/2+1mmlAo4X98HU1rb+rpCKNquYMgy2HDoZFdykEBPt7 fn/CfPmz4VmYV0fCs/NTKKmpCSaFCKLDxYcJF7vKaYnyn56rwDTsnBS0FoFwPOcyzbtk 56/9aEfBEaFWhbqaiFLxmkxl2Ze1w3Cay59mhWgZKE5WxD+PhdS0lvHzIYIcRs4Pao5F jns68q2f/hCo9uvkJPxpsCO83Dx+YjBEtFs1qH8kua8cZHMbxDdG7Ty96+3TKR8OB92C E54Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PasdPm0ruMjHHc/jYxUTTUFHsqQQeYT3E3v9depPqSY=; b=zqYBLm4cZlmuTQ3xpo/s7e0+nFZmZ3xLYY2+PzioLeZ9eOpxZ/zGAaWuZagIHgG9xM +MTfwAIiCmQ92yZ+h5+JYYIOL+Bj4sFYRSt5q6orqj0ei0ljzMYyECm/o6oY4d5Lyvma 2ri5Ei2f2YzYfkVSbKcR1fiMBeF7/6LVSAOx3aELFHjDulGCM+plZ2a7VfZGG9saRYeD OByLem9GlXLS391Z+phyLDpceYeU96AUEOgP3tOzXnUAVKpnLE9F1Eni588imiKNMYNk 8OHNZeyk14J2OHSnMHutLDdddS0PtHZ/4icZSjzAHMJD0UghTY4XVuLqgPiPkrwnHYOV jzlQ== X-Gm-Message-State: AO0yUKWySuxa7ZvCoFcRz9DkzrbgeUAW6xaXiJxoV0SgHk7Rycyrn53X dTsTWydcd+IvdepMBVqq7QA= X-Google-Smtp-Source: AK7set/e9dLgRCkJF7IYel+eMA6xqP6bK7pJPkdXSX/O1LRdAarjnBvhvfKDUL+QUH7nAEU+GrG2tQ== X-Received: by 2002:a17:90b:3b90:b0:22c:1986:553b with SMTP id pc16-20020a17090b3b9000b0022c1986553bmr9606862pjb.38.1675404657549; Thu, 02 Feb 2023 22:10:57 -0800 (PST) Received: from ?IPV6:2404:f801:0:5:8000::75b? ([2404:f801:9000:1a:efea::75b]) by smtp.gmail.com with ESMTPSA id m12-20020a63710c000000b004cd2eebc551sm743098pgc.62.2023.02.02.22.10.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 22:10:57 -0800 (PST) Message-ID: Date: Fri, 3 Feb 2023 14:10:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH V3 10/16] x86/hyperv: Add smp support for sev-snp guest To: "Michael Kelley (LINUX)" , "luto@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "seanjc@google.com" , "pbonzini@redhat.com" , "jgross@suse.com" , Tianyu Lan , "kirill@shutemov.name" , "jiangshan.ljs@antgroup.com" , "peterz@infradead.org" , "ashish.kalra@amd.com" , "srutherford@google.com" , "akpm@linux-foundation.org" , "anshuman.khandual@arm.com" , "pawan.kumar.gupta@linux.intel.com" , "adrian.hunter@intel.com" , "daniel.sneddon@linux.intel.com" , "alexander.shishkin@linux.intel.com" , "sandipan.das@amd.com" , "ray.huang@amd.com" , "brijesh.singh@amd.com" , "michael.roth@amd.com" , "thomas.lendacky@amd.com" , "venu.busireddy@oracle.com" , "sterritt@google.com" , "tony.luck@intel.com" , "samitolvanen@google.com" , "fenghua.yu@intel.com" Cc: "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-arch@vger.kernel.org" References: <20230122024607.788454-1-ltykernel@gmail.com> <20230122024607.788454-11-ltykernel@gmail.com> From: Tianyu Lan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/1/2023 2:34 AM, Michael Kelley (LINUX) wrote: >> + pr_err("HvCallStartVirtualProcessor failed: %llx\n", ret); >> + goto done; >> + } >> + >> +done: >> + local_irq_restore(flags); >> + return ret; >> +} >> + > Like a comment in an earlier patch, I'm wondering if the bulk of > this code could move to ivm.c, to avoid overloading mshyperv.c. Sure. Will update in the next version. >