Date:   Fri, 03 Feb 2023 06:30:24 +0000
From:   Conor Dooley <conor@kernel.org>
To:     JeeHeng Sia <jeeheng.sia@starfivetech.com>,
        Alexandre Ghiti <alexghiti@rivosinc.com>
CC:     "paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
        "palmer@dabbelt.com" <palmer@dabbelt.com>,
        "aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Leyfoon Tan <leyfoon.tan@starfivetech.com>,
        Mason Huo <mason.huo@starfivetech.com>
Subject: =?US-ASCII?Q?RE=3A_=5BPATCH_v3_4/4=5D_RISC-V=3A_Add_arch_functi?= =?US-ASCII?Q?ons_to_support_hibernation/suspend-to-disk?=
User-Agent: K-9 Mail for Android
In-Reply-To: <debdfe40909c4b4787868b11730170c9@EXMBX066.cuchost.com>
References: <20230127091051.1465278-1-jeeheng.sia@starfivetech.com> <20230127091051.1465278-5-jeeheng.sia@starfivetech.com> <Y9hTGo6dfgeusW4B@spud> <debdfe40909c4b4787868b11730170c9@EXMBX066.cuchost.com>
Message-ID: <26A8AAC0-D477-45CD-A7D1-55218992B25F@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 3 February 2023 03:43:35 GMT, JeeHeng Sia <jeeheng=2Esia@starfivetech=
=2Ecom> wrote:
>
>
>> -----Original Message-----
>> From: Conor Dooley <conor@kernel=2Eorg>
>> Sent: Tuesday, 31 January, 2023 7:31 AM
>> To: JeeHeng Sia <jeeheng=2Esia@starfivetech=2Ecom>; Alexandre Ghiti <al=
exghiti@rivosinc=2Ecom>
>> Cc: paul=2Ewalmsley@sifive=2Ecom; palmer@dabbelt=2Ecom; aou@eecs=2Eberk=
eley=2Eedu; linux-riscv@lists=2Einfradead=2Eorg; linux-
>> kernel@vger=2Ekernel=2Eorg; Leyfoon Tan <leyfoon=2Etan@starfivetech=2Ec=
om>; Mason Huo <mason=2Ehuo@starfivetech=2Ecom>
>> Subject: Re: [PATCH v3 4/4] RISC-V: Add arch functions to support hiber=
nation/suspend-to-disk
>>=20
>> +CC Alex
>>=20
>> Alex, could you take a look at the page table bits here when you get a
>> chance please?
>>=20
>> > + * @a0 - destination
>> > + * @a1 - source
>> > + */
>> > +	=2Emacro	copy_page a0, a1
>> > +		lui	a2, 0x1
>> > +		add	a2, a2, a0
>> > +=2E1 :
>> > +		REG_L	t0, 0(a1)
>> > +		REG_L	t1, SZREG(a1)
>> > +
>> > +		REG_S	t0, 0(a0)
>> > +		REG_S	t1, SZREG(a0)
>> > +
>> > +		addi	a0, a0, 2 * SZREG
>> > +		addi	a1, a1, 2 * SZREG
>> > +		bne	a2, a0, =2E1
>>=20
>> allmodconfig, clang 15=2E0=2E4:
>>=20
>> <instantiation>:3:1: error: unexpected token at start of statement
>> =2E1 :
>> ^
>> /stuff/linux/arch/riscv/kernel/hibernate-asm=2ES:83:2: note: while in m=
acro instantiation
>>  copy_page a0, a1
>>  ^
>> <instantiation>:12:15: error: unknown operand
>>   bne a2, a0, =2E1
>>               ^
>> /stuff/linux/arch/riscv/kernel/hibernate-asm=2ES:83:2: note: while in m=
acro instantiation
>>  copy_page a0, a1
>>  ^
>> make[5]: *** [/stuff/linux/scripts/Makefile=2Ebuild:384: arch/riscv/ker=
nel/hibernate-asm=2Eo] Error 1
>Hi Conor, I couldn't reproduce the above error, could you share the build=
 command please?

It was just allmodconfig with LLVM=3D1

>>=20
>> > +	=2Eendm
>> > +
>> >  #endif	/* __ASM_ASSEMBLER_H */
>=20
>> Thanks,
>> Conor=2E
>