From:   Oleksandr Natalenko <oleksandr@natalenko.name>
To:     tj@kernel.org, axboe@kernel.dk, Yu Kuai <yukuai1@huaweicloud.com>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com,
        yangerkun@huawei.com
Subject: Re: [PATCH -next] block: Revert "block: increase BLKCG_MAX_POLS"
Date:   Fri, 03 Feb 2023 08:59:13 +0100
Message-ID: <2666358.mvXUDI8C0e@natalenko.name>
In-Reply-To: <20230203081357.1385168-1-yukuai1@huaweicloud.com>
References: <20230203081357.1385168-1-yukuai1@huaweicloud.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

Hello.

On p=E1tek 3. =FAnora 2023 9:13:57 CET Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>=20
> This reverts commit ec645dc96699ea6c37b6de86c84d7288ea9a4ddf.
>=20
> This can save some memory, because after commit 0f7839955114 ("Revert
> "block/mq-deadline: Add cgroup support""), there are total 5 policies.
>=20
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
>  include/linux/blkdev.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 41a41561b773..c6861c7fdad9 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -54,7 +54,7 @@ extern struct class block_class;
>   * Maximum number of blkcg policies allowed to be registered concurrentl=
y.
>   * Defined here to simplify include dependency.
>   */
> -#define BLKCG_MAX_POLS		6
> +#define BLKCG_MAX_POLS		5
> =20
>  #define DISK_MAX_PARTS			256
>  #define DISK_NAME_LEN			32

Last time I asked about reverting this change, it was suggested that we may=
 keep it [1].

[1] https://lore.kernel.org/linux-block/1dc051a8-4d59-8137-2406-f74026b170b=
d@kernel.dk/

=2D-=20
Oleksandr Natalenko (post-factum)