Date:   Fri, 3 Feb 2023 08:36:01 +0000
From:   Wyes Karny <wyes.karny@amd.com>
To:     Russell Haley <yumpusamongus@gmail.com>
Cc:     Rafael J Wysocki <rafael@kernel.org>,
        Huang Rui <ray.huang@amd.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Mario.Limonciello@amd.com, Perry.Yuan@amd.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, Bagas Sanjaya <bagasdotme@gmail.com>,
        santosh.shukla@amd.com, Len Brown <lenb@kernel.org>,
        Robert Moore <robert.moore@intel.com>,
        Borislav Petkov <bp@alien8.de>,
        Ananth Narayan <ananth.narayan@amd.com>,
        gautham.shenoy@amd.com, Tor Vic <torvic9@mailbox.org>
Subject: Re: [PATCH v4 5/6] cpufreq: amd_pstate: Add guided mode control
 support via sysfs
Message-ID: <Y9zHcXYm1a8nYkYf@beas>
References: <20230131052141.96475-1-wyes.karny@amd.com>
 <20230131052141.96475-6-wyes.karny@amd.com>
 <8b21feb3-624c-0c91-7dc7-708b5bb19a93@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8b21feb3-624c-0c91-7dc7-708b5bb19a93@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QRFEXqemZjqTc+bfs5lvMw9i1S1DM/si2Lx1B2crw8DkD/pTr+/oZMEnH8bQ?=
 =?us-ascii?Q?eqAHjNSmn0GqOdbJL2fp4xVzOLmA37M4SqpkTqaomM5ppf2Zt9M0Fehqr+9P?=
 =?us-ascii?Q?/ka8AVG/2enzGF5oMw3myb9TdoLtIskiaZq9P+hs255s3PmfDqnF3tCrc9zr?=
 =?us-ascii?Q?bJ7pq49P04nLLXjBzB5T2WL/KbSyR0C7JHfr31UWWTVmYtoJvMU3KgZv43Wt?=
 =?us-ascii?Q?BHseqg4dlZ2h+va9b7iuNk7K3TGPd87mbqnRjAO1SvyGrHAO/zZc+s+vvNH5?=
 =?us-ascii?Q?6LJQcJ147m0e+z6Iukok/D262wxB8qm6IIK9aEmO8AeXJ7cGsyjRbTAtrEN8?=
 =?us-ascii?Q?zG4KSDpBNAp5Tw+8gnFIfaqPouSQMbGWZaPmNHDvWnMVX9Uo/lDVFpykSoL8?=
 =?us-ascii?Q?3lriiIOjL/FJZbUOwI6cUSq9coSGFaAIPG2nCHtmtaKjLE/98rcNEHheZRDV?=
 =?us-ascii?Q?AlzlHcrjGGLka5zFpUdF8yixwoqaPyCOmXdd2f4NN78ZT+3s+3Nvnnk8YUmm?=
 =?us-ascii?Q?AjZ7FoSv3I7xDseZYOE4Chz+qK9ngCpUo2DZigvAc7VvmjKROZCtMh0D2BZa?=
 =?us-ascii?Q?9UU+NeDu0QsYbyFH2hVz+T/oYounfKm95uVI9w/mx5NMyR71ZClyTNX5GuHm?=
 =?us-ascii?Q?HOkw9jI7UAGJP1csWf0toKeIoJZXyaSvBsiTqIX1g94Dh4gyZDV/Y68T5Sc4?=
 =?us-ascii?Q?SLXN/WIasc5ydiE5qAsWPoLTtmgtXnUxVoWWLfSOqCrIQZqmAjxNJMMhc5yq?=
 =?us-ascii?Q?AgtMqfUU72gXczJpjeVSYH3lgXxKbtGsHUukUI9ddh+8Dhmbh6xhkju3oGND?=
 =?us-ascii?Q?TNsTL61iEnb6DdbTXxi8lNCcJgqAr8KRqKv8fsjerLoJXHVZYbdkv9zkF2Hw?=
 =?us-ascii?Q?JgoJ7xjT9sO/TFxiU3vlGWt1Ed6XuzNhCBNHgHwL+n8dNhos1wHU4xM0H9xB?=
 =?us-ascii?Q?EfibjrrGKvx/iPweJyP+7mrmDtWzlFglTWTj/vUagzjPmsUkiafBrIZN2FMT?=
 =?us-ascii?Q?RTd18QbpQqS9R22ulrrZO2XkMwRoZZgr3RcOSQmhepET1eaBkqUzAn+nGdxg?=
 =?us-ascii?Q?IS/9hg0l0MgVcN4qfZra9StZZ/oO7so9qTtAvzMoeTcrtmEaCtsGQCwxIDoy?=
 =?us-ascii?Q?76RJ+wCmlLVNvH/M51VmTkzAGGpJfgSq884yl7vSuEDYdW9XJfjcvSLwLAyj?=
 =?us-ascii?Q?r3TsQ+OF6H35pMymG9ue2uo5AT5jS27iyxubvPnYYgThZe0CwROBHsn9e3Pk?=
 =?us-ascii?Q?sJwNUfL1jOUsE+0Zl2uJWfaqQJe6gK5t8gilT1+mCb8C9gznTLbwvTHL6S6q?=
 =?us-ascii?Q?2xZaOaaL+JQnHR9IBa6quo1zq340OBrDUedB+o2+LVX7WWcu8v4Xa0ydMufE?=
 =?us-ascii?Q?MkDZWGvYst572jUAooXMEMFUaT82Cp4xeiqUpgmvrRhsdjSrZ5Y9mvQM1/vO?=
 =?us-ascii?Q?axlQyNSuyalA/QpFw6KWrIiWuafKcjLoQJb53j6uCtWAJs3ie9GoY0O7XKhH?=
 =?us-ascii?Q?W1uhPYUp/tRTcU4GD9fjb7McJ+yzGiqLSmkrPlffbUfJ4v+l+m+a1nSjBPHZ?=
 =?us-ascii?Q?JBFQnhR9ky4eePRfZBpGZZBY7+me63XWvjQrs5u7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc91fbed-0dac-4fa6-2449-08db05c1b660
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2023 08:36:15.3231
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /ltuP0Z+edKzd6Wy4gHkmt+/MW5XNG9HdYeGD8O+Xpj7PdTpqzLjn83Phm71Lakrvlmhp6lpxlvIqd7Y7s+NRg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7886
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Russell,

On 02 Feb 01:41, Russell Haley wrote:
> 
> 
> On 1/30/23 23:21, Wyes Karny wrote:
> 
> > Only if the state requested matches
> > with the current state then -EBUSY value is returned.
> 
> This differs from the behavior of intel_pstate, where writing the
> current state to the status file always succeeds.
> 
> Why not do the same thing here?

Make sense. Will change this to return 0.
Thanks for reviewing.

Thanks,
Wyes