Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AF42C636D6 for ; Fri, 3 Feb 2023 09:26:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232327AbjBCJ05 (ORCPT ); Fri, 3 Feb 2023 04:26:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232222AbjBCJ0z (ORCPT ); Fri, 3 Feb 2023 04:26:55 -0500 Received: from dilbert.mork.no (dilbert.mork.no [IPv6:2a01:4f9:c010:a439::d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 739246E89; Fri, 3 Feb 2023 01:26:50 -0800 (PST) Received: from canardo.dyn.mork.no ([IPv6:2a01:799:c9a:3200:0:0:0:1]) (authenticated bits=0) by dilbert.mork.no (8.15.2/8.15.2) with ESMTPSA id 3139PiLf773660 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Fri, 3 Feb 2023 09:25:45 GMT Received: from miraculix.mork.no ([IPv6:2a01:799:c9a:3202:549f:9f7a:c9d8:875b]) (authenticated bits=0) by canardo.dyn.mork.no (8.15.2/8.15.2) with ESMTPSA id 3139PcbS1534444 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Fri, 3 Feb 2023 10:25:38 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mork.no; s=b; t=1675416339; bh=VBtFXiOaxjapiMDewgSuvRBSynlE/nLpzbKpUvxzZ4U=; h=From:To:Cc:Subject:References:Date:Message-ID:From; b=T+WP/6kLczsZbbKv+POC7djUJLTqQWawcXIjaJh0dxew66z6DdtXzOluohHttOPfm cCcq4mR9tptxsD34OuqlIDjWHIdBy1a4MMAuBsIsL0x0laZebqITfRFj/voICcHRUH SIk67RuPLR+/9DRaqtUqQgkkx9xfdS6ESIzGlyJQ= Received: (nullmailer pid 337756 invoked by uid 1000); Fri, 03 Feb 2023 09:25:38 -0000 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Daniel Golle Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Heiner Kallweit , Lorenzo Bianconi , Mark Lee , John Crispin , Felix Fietkau , AngeloGioacchino Del Regno , Matthias Brugger , DENG Qingfang , Landen Chao , Sean Wang , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Andrew Lunn , Jianhui Zhao Subject: Re: [PATCH 8/9] net: ethernet: mtk_eth_soc: switch to external PCS driver Organization: m References: <3bac780184867e111c3a1567d8b55658abd931da.1675407169.git.daniel@makrotopia.org> Date: Fri, 03 Feb 2023 10:25:38 +0100 In-Reply-To: <3bac780184867e111c3a1567d8b55658abd931da.1675407169.git.daniel@makrotopia.org> (Daniel Golle's message of "Fri, 3 Feb 2023 07:06:10 +0000") Message-ID: <87357nt819.fsf@miraculix.mork.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: clamav-milter 0.103.7 at canardo X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel Golle writes: > - ss->pcs[i].ana_rgc3 =3D ana_rgc3; > - ss->pcs[i].regmap =3D syscon_node_to_regmap(np); > - > - ss->pcs[i].flags =3D 0; > + flags =3D 0; > if (of_property_read_bool(np, "pn_swap")) > - ss->pcs[i].flags |=3D MTK_SGMII_FLAG_PN_SWAP; > + flags |=3D MTK_SGMII_FLAG_PN_SWAP; >=20=20 patch 1 added "mediatek,pn_swap" so this doesn't apply. We've all done last minute cleanups - never a good idea :-) Bj=C3=B8rn