Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [PATCH v2 0/2] media: rc: add keymap and bindings for Dreambox
 remotes
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <20230203093405.1616564-1-christianshewitt@gmail.com>
Date:   Fri, 3 Feb 2023 13:41:46 +0400
Cc:     Sean Young <sean@mess.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        devicetree@vger.kernel.org,
        Emanuel Strobel <emanuel.strobel@yahoo.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <EA8F3DCB-793D-41BC-AD02-51677D86FEF8@gmail.com>
References: <20230203093405.1616564-1-christianshewitt@gmail.com>
To:     Christian Hewitt <christianshewitt@gmail.com>
Precedence: bulk


> On 3 Feb 2023, at 1:34 pm, Christian Hewitt =
<christianshewitt@gmail.com> wrote:
>=20
> This series adds bindings and common keymap for the Dreambox RC10/RC0
> and RC20/RC-BT remote devices.
>=20
> Changes since v1:
> - Split bindings and keymap into separate patches
> - Revise keymap description to clarify non-IR keys and mappings
> - Revise tagging and key ordering in the keymap
>=20
> In v1 the RC10/RC0 keymap is incorrectly tagged as RC20/RC-BT and vice
> versa, resulting in some missing //RADIO and //TV keys. Correcting the
> tagging then reordering the keys to match physical layouts [0] and [1]
> results in no missing keys. The keymaps worked, but I've gotten things
> confused when translating from Emanuel's original keymap. So apologies
> for the confusion.

[0] =
https://www.satking.de/receiver--sat-technik/receiver-zubehoer/fernbedienu=
ngen/fernbedienung-dreambox-original-rc10-500hd-525hd-7020hd-dm900-dm920

[1] =
https://www.satking.de/receiver--sat-technik/receiver-zubehoer/fernbedienu=
ngen/dreambox-original-ir-fernbedienung-rc20-fuer-alle-dreamboxen

^ missed these references

> Christian Hewitt (1):
>  dt-bindings: media: rc: add rc-dreambox binding
>=20
> Emanuel Strobel (1):
>  media: rc: add common keymap for Dreambox RC10/RC0 and RC20/RC-BT
>    remotes
>=20
> .../devicetree/bindings/media/rc.yaml         |   1 +
> drivers/media/rc/keymaps/Makefile             |   1 +
> drivers/media/rc/keymaps/rc-dreambox.c        | 151 ++++++++++++++++++
> include/media/rc-map.h                        |   1 +
> 4 files changed, 154 insertions(+)
> create mode 100644 drivers/media/rc/keymaps/rc-dreambox.c
>=20
> --=20
> 2.34.1
>=20