Message-ID: <c0642b4b-5a36-8d30-017b-5585a124211a@quicinc.com>
Date:   Fri, 3 Feb 2023 15:48:32 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH] firmware: qcom_scm: modify qcom_scm_set_download_mode()
Content-Language: en-US
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>
CC:     <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1674562755-5378-1-git-send-email-quic_mojha@quicinc.com>
 <0e3b9803-2492-87ec-3ae9-00ac820c87ce@linaro.org>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <0e3b9803-2492-87ec-3ae9-00ac820c87ce@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2/2/2023 4:47 PM, Srinivas Kandagatla wrote:
> 
> 
> On 24/01/2023 12:19, Mukesh Ojha wrote:
>> -static int __qcom_scm_set_dload_mode(struct device *dev, bool enable)
>> +static int __qcom_scm_set_dload_mode(struct device *dev, enum 
>> qcom_download_mode mode)
>>   {
>>       struct qcom_scm_desc desc = {
>>           .svc = QCOM_SCM_SVC_BOOT,
>>           .cmd = QCOM_SCM_BOOT_SET_DLOAD_MODE,
>>           .arginfo = QCOM_SCM_ARGS(2),
>> -        .args[0] = QCOM_SCM_BOOT_SET_DLOAD_MODE,
>> +        .args[0] = mode,
> 
> Is this a bug fix? why are we changing arg[0]?

Thanks.

This is legacy scm call and it is deprecated.
Let's not change this.
I will fix this in v2.

-Mukesh
> 
> --srini
>>           .owner = ARM_SMCCC_OWNER_SIP,
>>       };
>> -    desc.args[1] = enable ? QCOM_SCM_BOOT_SET_DLOAD_MODE : 0;
>> +    desc.args[1] = mode;
>>       return qcom_scm_call_atomic(__scm->dev, &desc, NULL);
>>   }