Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Fri, 03 Feb 2023 20:21:55 +1000
Message-Id: <CQ8UPZX0BERP.2TFM4914IGJZF@bobo>
Cc:     "Claudio Imbrenda" <imbrenda@linux.ibm.com>,
        "Janosch Frank" <frankja@linux.ibm.com>,
        "Suzuki K Poulose" <suzuki.poulose@arm.com>,
        "Marc Zyngier" <maz@kernel.org>,
        "David Hildenbrand" <david@redhat.com>,
        <linux-kernel@vger.kernel.org>,
        "Oliver Upton" <oliver.upton@linux.dev>,
        "Zenghui Yu" <yuzenghui@huawei.com>,
        "James Morse" <james.morse@arm.com>,
        <kvm-riscv@lists.infradead.org>, <kvmarm@lists.linux.dev>,
        "Christian Borntraeger" <borntraeger@linux.ibm.com>,
        <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 4/7] KVM: PPC: Standardize on "int" return types in the
 powerpc KVM code
From:   "Nicholas Piggin" <npiggin@gmail.com>
To:     "Thomas Huth" <thuth@redhat.com>, <kvm@vger.kernel.org>,
        "Paolo Bonzini" <pbonzini@redhat.com>,
        "Sean Christopherson" <seanjc@google.com>
References: <20230203094230.266952-1-thuth@redhat.com>
 <20230203094230.266952-5-thuth@redhat.com>
In-Reply-To: <20230203094230.266952-5-thuth@redhat.com>
Precedence: bulk

On Fri Feb 3, 2023 at 7:42 PM AEST, Thomas Huth wrote:
> Most functions that are related to kvm_arch_vm_ioctl() already use
> "int" as return type to pass error values back to the caller. Some
> outlier functions use "long" instead for no good reason (they do not
> really require long values here). Let's standardize on "int" here to
> avoid casting the values back and forth between the two types.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Thanks for the patch. It looks fine to me, it should be okay to
go via Paolo's tree if he's going to take the series.

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>

> ---
>  arch/powerpc/include/asm/kvm_ppc.h  | 14 +++++++-------
>  arch/powerpc/kvm/book3s_64_mmu_hv.c | 14 +++++++-------
>  arch/powerpc/kvm/book3s_64_vio.c    |  4 ++--
>  arch/powerpc/kvm/book3s_hv.c        |  6 +++---
>  arch/powerpc/kvm/book3s_pr.c        |  4 ++--
>  5 files changed, 21 insertions(+), 21 deletions(-)