Date:   Fri, 3 Feb 2023 12:27:20 +0100
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Bjorn Andersson <quic_bjorande@quicinc.com>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        Subbaraman Narayanamurthy <quic_subbaram@quicinc.com>,
        Johan Hovold <johan@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH v4 4/4] power: supply: Introduce Qualcomm PMIC GLINK
 power supply
Message-ID: <20230203112720.oa7e2psevbazicqo@mercury.elektranox.org>
References: <20230201041853.1934355-1-quic_bjorande@quicinc.com>
 <20230201041853.1934355-5-quic_bjorande@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ab6rsa56fkougaat"
Content-Disposition: inline
In-Reply-To: <20230201041853.1934355-5-quic_bjorande@quicinc.com>
Precedence: bulk


--ab6rsa56fkougaat
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Jan 31, 2023 at 08:18:53PM -0800, Bjorn Andersson wrote:
=2E..
> +static const enum power_supply_property sm8350_bat_props[] =3D {
> +	POWER_SUPPLY_PROP_STATUS,
> +	POWER_SUPPLY_PROP_HEALTH,
> +	POWER_SUPPLY_PROP_PRESENT,
> +	POWER_SUPPLY_PROP_CHARGE_TYPE,
> +	POWER_SUPPLY_PROP_CAPACITY,
> +	POWER_SUPPLY_PROP_VOLTAGE_OCV,
> +	POWER_SUPPLY_PROP_VOLTAGE_NOW,
> +	POWER_SUPPLY_PROP_VOLTAGE_MAX,
> +	POWER_SUPPLY_PROP_CURRENT_NOW,
> +	POWER_SUPPLY_PROP_TEMP,
> +	POWER_SUPPLY_PROP_TECHNOLOGY,
> +	POWER_SUPPLY_PROP_CHARGE_COUNTER,
> +	POWER_SUPPLY_PROP_CYCLE_COUNT,
> +	POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN,
> +	POWER_SUPPLY_PROP_CHARGE_FULL,

no CHARGE_NOW?

> +	POWER_SUPPLY_PROP_MODEL_NAME,
> +	POWER_SUPPLY_PROP_TIME_TO_FULL_AVG,
> +	POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG,
> +	POWER_SUPPLY_PROP_POWER_NOW,
> +};

=2E..

> +static struct auxiliary_driver qcom_battmgr_driver =3D {
> +	.name =3D "pmic_glink_power_supply",
> +	.probe =3D qcom_battmgr_probe,
> +	.id_table =3D qcom_battmgr_id_table,
> +};
> +
> +static int __init qcom_battmgr_init(void)
> +{
> +	return auxiliary_driver_register(&qcom_battmgr_driver);
> +}
> +module_init(qcom_battmgr_init);
> +
> +static void __exit qcom_battmgr_exit(void)
> +{
> +	auxiliary_driver_unregister(&qcom_battmgr_driver);
> +}
> +module_exit(qcom_battmgr_exit);

module_auxiliary_driver()

Otherwise LGTM.

-- Sebastian=20

--ab6rsa56fkougaat
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmPc75UACgkQ2O7X88g7
+pr4fw//Z1DMQADqDkOFF9D967X8R7vHQhf+RCwXgMknxBdCaIw650zcMzdKH+9L
9PCr4nFXlHIqMUYaTaEFV5BTitoCPdKGCoQ0fKMzeHYvX/LYlZhjD3HYyhhOQaLF
iZRR5IuX1iW0TG6Kv0GKd8hZxHH2/VdaYZYUESAPJa6qX6/k/zc+D4AYc5PxRzuZ
D8avHBiwts+3zZnSaAlaNBh51jeHrfMGwZCU93gbySXhatHzQGDFatV1UNr34/j4
ZWPCn8pgCTBTIfg8qeXEDmteYwkHt61CBZu7j2A1h367g8pbz+KInZlZAMlipEHF
SK7EHwO30m5AK6Fz+kJKWiNxL80O1WqUwvoUCJ6tivPCFKEB+/FUjWs0GZ5OvZfX
i9R/dB0FXuACz59pPJkS8rk1q5lZtBgSHV1kgrI/dIgxFSf2y078UiJwX0JTSBhw
Rqk/VehvCHlXO1Qs3J3EOKiHu7l0VpSfQsRUBbLnichQQurg+/uzaJZ2OYULQ2do
+uQUrp/8gfl/a5lBN2r7P3YaBzEj3YHNEfRhAf9RW96XzUSe5nncv7cIu6ftfAtO
r6OK4Or2ntCuaTLATnllK+9fIKUPNArPh2ggU98ZBERXR0zsgGHwEZRGOYiYcswx
dU+1oqzEt3TDZq77KlVjZR6hlOwvOeHM/ExI763HwvolUkkttdQ=
=PQ0S
-----END PGP SIGNATURE-----

--ab6rsa56fkougaat--