Date:   Fri, 3 Feb 2023 12:28:32 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Herve Codina <herve.codina@bootlin.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 2/3] ASoC: codecs: Add support for the Renesas X9250
 potentiometers
Message-ID: <Y9z98CXXyI7UkrkZ@sirena.org.uk>
References: <20230203111422.142479-1-herve.codina@bootlin.com>
 <20230203111422.142479-3-herve.codina@bootlin.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="h0liV1/NW0xnlBov"
Content-Disposition: inline
In-Reply-To: <20230203111422.142479-3-herve.codina@bootlin.com>
Precedence: bulk


--h0liV1/NW0xnlBov
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Feb 03, 2023 at 12:14:21PM +0100, Herve Codina wrote:

> +static const struct snd_kcontrol_new x9250_controls_std[] = {
> +	SOC_SINGLE_EXT("CMD0", 0, 0, 255, 0, x8250_kctrl_cmd_get, x8250_kctrl_cmd_put),
> +	SOC_SINGLE_EXT("CMD1", 1, 0, 255, 0, x8250_kctrl_cmd_get, x8250_kctrl_cmd_put),
> +	SOC_SINGLE_EXT("CMD2", 2, 0, 255, 0, x8250_kctrl_cmd_get, x8250_kctrl_cmd_put),
> +	SOC_SINGLE_EXT("CMD3", 3, 0, 255, 0, x8250_kctrl_cmd_get, x8250_kctrl_cmd_put),
> +};

These control names feel a bit icky but given that they have board
specific functions I don't see a way to sensibly rewrite them.  However
I do wonder if we might be better off having this as an IIO driver and
having a binding that lets us import IIO outputs into sound cards - I'm
guessing there are other non-audio applications for this hardware?

--h0liV1/NW0xnlBov
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPc/e8ACgkQJNaLcl1U
h9DANgf8Drcef0r+SN0lM5Hjl/HwDavvrxI99u+GtYEKjIhU0tvGOR/va8iwO2H9
ELv+YEOqHmHQu8jafBktqSqFXMo5Ji/BUPt4N4OU0OtDrpzKkM4MvTYREYWLVlLs
AVq125SrM0p7rLLfeKwjUP6QB8qB65nBoIjUazcEqYaHtHeZUJhoXJMskoH6tbCv
3/BD8dylapfR1wKbjIXNgUyMXCVD17Oeul+n0s63ZrxXfrrPXSRD/A/nrl21q1H4
nRfD2uUZfdfmzQ3so3n5DW2AVmnM4TV2uvZbcfgfc66eJAm+koamH8kd6thLIJ0P
vP7HXp8cy9ZBETaseK+rgEMZ7z9uag==
=LGok
-----END PGP SIGNATURE-----

--h0liV1/NW0xnlBov--