Message-ID: <b3c1e629-179f-d2c3-d3eb-3556a7df10ae@quicinc.com>
Date:   Fri, 3 Feb 2023 18:04:34 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.0
Subject: Re: [PATCH V6 2/7] clk: qcom: Add Global Clock Controller driver for
 IPQ9574
To:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Devi Priya <quic_devipriy@quicinc.com>, <agross@kernel.org>,
        <andersson@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <mturquette@baylibre.com>,
        <sboyd@kernel.org>, <linus.walleij@linaro.org>,
        <catalin.marinas@arm.com>, <will@kernel.org>,
        <p.zabel@pengutronix.de>, <shawnguo@kernel.org>, <arnd@arndb.de>,
        <marcel.ziswiler@toradex.com>, <dmitry.baryshkov@linaro.org>,
        <nfraprado@collabora.com>, <broonie@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
CC:     <quic_srichara@quicinc.com>, <quic_gokulsri@quicinc.com>,
        <quic_sjaganat@quicinc.com>, <quic_arajkuma@quicinc.com>,
        <quic_anusha@quicinc.com>, <quic_poovendh@quicinc.com>
References: <20230202150619.22425-1-quic_devipriy@quicinc.com>
 <20230202150619.22425-3-quic_devipriy@quicinc.com>
 <1d144aa4-6f0f-b10f-1d32-4acf4e06ae85@quicinc.com>
 <e34f36b0-35a8-0b77-e6ab-49851213108e@linaro.org>
Content-Language: en-US
From:   Kathiravan T <quic_kathirav@quicinc.com>
In-Reply-To: <e34f36b0-35a8-0b77-e6ab-49851213108e@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2/3/2023 4:25 PM, Konrad Dybcio wrote:
>
> On 3.02.2023 06:47, Kathiravan T wrote:
>> On 2/2/2023 8:36 PM, Devi Priya wrote:
>>> Add Global Clock Controller (GCC) driver for ipq9574 based devices
>>>
>>> Co-developed-by: Anusha Rao <quic_anusha@quicinc.com>
>>> Signed-off-by: Anusha Rao <quic_anusha@quicinc.com>
>>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>
>>> ---
> [...]
>
>>> +static int gcc_ipq9574_probe(struct platform_device *pdev)
>>> +{
>>> +    struct regmap *regmap;
>>> +    struct qcom_cc_desc ipq9574_desc = gcc_ipq9574_desc;
>>> +
>>> +    regmap = qcom_cc_map(pdev, &ipq9574_desc);
>>> +    if (IS_ERR(regmap))
>>> +        return PTR_ERR(regmap);
>>> +
>>> +    return qcom_cc_really_probe(pdev, &ipq9574_desc, regmap);
>>
>> can we use qcom_cc_probe as suggested here https://lore.kernel.org/linux-arm-msm/84f68577f5629e6ef6d6b14357a79f84.sboyd@kernel.org/ ?
> Yes we can.
>
> When you're answering a long long long long email, please cut off
> parts that you aren't replying to, I had to scroll and scroll and
> scroll and scroll to get to this sentence and I'm not even sure if
> you said something inbetween that I missed..


Got it, Thanks.


>
> Konrad
>>
>>> +}
>>> +
>>> +static struct platform_driver gcc_ipq9574_driver = {
>>> +    .probe = gcc_ipq9574_probe,
>>> +    .driver = {
>>> +        .name   = "qcom,gcc-ipq9574",
>>> +        .of_match_table = gcc_ipq9574_match_table,
>>> +    },
>>> +};
>>> +
>>> +static int __init gcc_ipq9574_init(void)
>>> +{
>>> +    return platform_driver_register(&gcc_ipq9574_driver);
>>> +}
>>> +core_initcall(gcc_ipq9574_init);
>>> +
>>> +static void __exit gcc_ipq9574_exit(void)
>>> +{
>>> +    platform_driver_unregister(&gcc_ipq9574_driver);
>>> +}
>>> +module_exit(gcc_ipq9574_exit);
>>> +
>>> +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. GCC IPQ9574 Driver");
>>> +MODULE_LICENSE("GPL");