Date:   Fri, 3 Feb 2023 14:00:45 +0100
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     cgel.zte@gmail.com
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Minghao Chi <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] power: supply: use strscpy() is more robust and safer
Message-ID: <20230203130045.shjvwqkopic65wox@mercury.elektranox.org>
References: <20220919024919.211210-1-chi.minghao@zte.com.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="f2t2axxher2oxzor"
Content-Disposition: inline
In-Reply-To: <20220919024919.211210-1-chi.minghao@zte.com.cn>
Precedence: bulk


--f2t2axxher2oxzor
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Sep 19, 2022 at 02:49:19AM +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>=20
> The implementation of strscpy() is more robust and safer.
>=20
> That's now the recommended way to copy NUL terminated strings.
>=20
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---

Sorry, this fell between the cracks. Applied now, thanks!

-- Sebastian

>  drivers/power/supply/max1721x_battery.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/power/supply/max1721x_battery.c b/drivers/power/supp=
ly/max1721x_battery.c
> index 473e53cd2801..0f948db958d5 100644
> --- a/drivers/power/supply/max1721x_battery.c
> +++ b/drivers/power/supply/max1721x_battery.c
> @@ -384,7 +384,7 @@ static int devm_w1_max1721x_add_device(struct w1_slav=
e *sl)
>  	}
> =20
>  	if (!info->ManufacturerName[0])
> -		strncpy(info->ManufacturerName, DEF_MFG_NAME,
> +		strscpy(info->ManufacturerName, DEF_MFG_NAME,
>  			2 * MAX1721X_REG_MFG_NUMB);
> =20
>  	if (get_string(info, MAX1721X_REG_DEV_STR,
> @@ -403,15 +403,15 @@ static int devm_w1_max1721x_add_device(struct w1_sl=
ave *sl)
> =20
>  		switch (dev_name & MAX172XX_DEV_MASK) {
>  		case MAX172X1_DEV:
> -			strncpy(info->DeviceName, DEF_DEV_NAME_MAX17211,
> +			strscpy(info->DeviceName, DEF_DEV_NAME_MAX17211,
>  				2 * MAX1721X_REG_DEV_NUMB);
>  			break;
>  		case MAX172X5_DEV:
> -			strncpy(info->DeviceName, DEF_DEV_NAME_MAX17215,
> +			strscpy(info->DeviceName, DEF_DEV_NAME_MAX17215,
>  				2 * MAX1721X_REG_DEV_NUMB);
>  			break;
>  		default:
> -			strncpy(info->DeviceName, DEF_DEV_NAME_UNKNOWN,
> +			strscpy(info->DeviceName, DEF_DEV_NAME_UNKNOWN,
>  				2 * MAX1721X_REG_DEV_NUMB);
>  		}
>  	}
> --=20
> 2.25.1

--f2t2axxher2oxzor
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmPdBXUACgkQ2O7X88g7
+prhaw/9HGLScrgq/kceuN/lTUZENnhal350PLcsqUeOOTk63o7LJC2yYWf594WP
kjEyXvXocvcAyhQPoFHKXi9uhIXWtk85av/d+TyC19gnfP+GMugVGt0N0ndn98h3
fK7qpMqkvyCxSx3PeWYGP+rxzh8kf9M83k1r2LY0CSVizq4rFN88HIc19Y0nxytq
Ft4E6lsjsq+ulFMkjR2nhWy/sdJDnCzlVxlWrHzIgYa4EyuaMFqcmBHuWX6WUXlx
gJyCcwexKUVIXowL4ql4JPR6JTxsNJERtxPuLTVaEQXWh4Z0o2TFxGe0k7xrCrFP
gnHndUnhhu3vzIWTyxB5q5nl0J1oj7+mspxbmA4SthoRwrHAZj3Fgl+t+q/AZ770
kRN2Q2oOIHrK86d2dylimr2fsWiqyPB+A2HT1BfVrRUQDjhIYMRfjq6f4zWg2fTy
JSr2/Wq4g2yOxzSTdb7ln+z0taCVie23ZcHXe8ECjqDO23mfO8bjZz1u+AkmbTGY
QAAZ7O77VZx9j3OFJ6zmwQyiInutxAvcnhfcafG7Nu4mfQ0ha5inUVe8RJ9G2/vK
y66CA3HHbsC8Kc6DeR0OhajowuNsMDDkpcZHu2cf9n/KqwfjxpHLUX3BBvPxQCOT
YGMknFCklRjv5yMvmpbVjM/yKW2W9zn6Xsuv+8OPc+EMP2MEK0Y=
=+h3N
-----END PGP SIGNATURE-----

--f2t2axxher2oxzor--